Matt-Yorkley
dcad00d047
Merge pull request #8484 from Matt-Yorkley/stripe-session-checks
...
Stripe checkout alerting
2021-12-05 12:04:00 +00:00
Matt-Yorkley
527a53bd0f
Merge pull request #8485 from Matt-Yorkley/stripe-addresses
...
Checkout address handling
2021-11-18 15:19:27 +00:00
Matt-Yorkley
f8349434bf
Skip address setup logic if we're coming from Stripe
...
The code here runs from a callback which was originally designed to make sure the checkout page was set up correctly in the "normal" checkout workflow. It wasn't really designed to be run when the page is being loaded a second time due to the user being redirected back from Stripe (with SCA). The things it's doing here are necessary in the former case, but a really bad idea in the latter (potentially messing up the order's ship and bill addresses in certain cases like guest checkout).
2021-11-14 16:54:44 +00:00
Matt-Yorkley
48acc0ecd0
Add Bugsnag notice when an OC closes during checkout completion
...
This info could be useful to know whilst debugging order completion issues.
2021-11-14 13:58:15 +00:00
Maikel Linke
6212ad18a8
Test for concurrent checkouts reliably
...
Apparently, controller specs are not thread safe and we got random test
failures. I converted it into a request spec and fine-tuned it to make
it more reliable.
2021-11-12 14:09:17 +11:00
Matt-Yorkley
439a2318fb
Move API response under top-level :data node
2021-11-04 14:55:23 +00:00
Matt-Yorkley
97b22ec65d
Update related specs
2021-11-04 14:55:23 +00:00
Matt-Yorkley
817f0942dd
Pull in reports POC work replacing Packing reports
2021-11-04 14:55:23 +00:00
Matt-Yorkley
cf5d964133
Update usages of old preference getters and setters
2021-11-04 11:48:30 +00:00
Maikel
43514f61ea
Merge pull request #8312 from mariodz95/8249_fix_snail_on_shipping_method_fees
...
Fix snail on shipping method fees
2021-10-29 12:04:25 +11:00
Maikel
1b79fdd333
Merge pull request #8409 from luisAzcuaga/task/rubocop
...
[6055] Task: Run rubocop over existing todo
2021-10-29 12:01:12 +11:00
Maikel
2e8f4c1538
Merge pull request #8367 from bellvat/bug-show-error
...
Add test and change order_cycle#show to redirect to edit page.
2021-10-28 16:36:47 +11:00
Luis Azcuaga
e8fd89a6d2
Run rubocop over existing todo
2021-10-25 21:28:28 -05:00
Monica Sirathanarun
ebaf96ddae
Add test and change order_cycle#show to redirect to edit page.
2021-10-19 23:20:54 +07:00
mariodz95
d1160ec66a
Fix snail on shipping method fees
2021-10-19 09:56:35 +02:00
Jean-Baptiste Bellet
115dac3ca9
Add tax_category_id for a line_item
2021-10-18 10:56:27 +02:00
Adrien Chauve
f256bb7d28
Add new failing test on sorting orders by total (api/v0/orders)
2021-10-01 18:32:59 +02:00
Maikel
a3c31f7d86
Revert "Kill stripe connect"
2021-09-20 08:39:34 +10:00
Nihal
98a879a0e9
Restore removed spec to profile_storer_spec
2021-09-10 14:43:34 +05:30
Luis Ramos
f90e34bb47
Adapt specs to use stripe_sca_payment_method factory and delete stripe_connect_payment_method
2021-09-10 14:43:34 +05:30
Luis Ramos
9de9b41575
Remove stripe connect spec, there's a similar spec for stripesca below
2021-09-10 14:43:34 +05:30
Maikel
9affc6a945
Merge pull request #8108 from Matt-Yorkley/andand
...
Remove `andand` gem
2021-09-10 15:06:00 +10:00
Andy Brett
f8486bcbf8
Merge pull request #7769 from Matt-Yorkley/payment-status-checking
...
Stripe: payment status debugging
2021-09-08 15:21:38 -07:00
Matt-Yorkley
1d5077061e
Remove andand
...
This old gem implemented some functionality for handling nils which is no longer needed, as it's provided natively by Ruby with the &. operator.
2021-09-08 14:28:31 +01:00
Matt-Yorkley
7e3b9be506
Allow StripeSCA Gateway to actually void payments
2021-07-30 11:48:57 +01:00
Matt-Yorkley
e1393c96ca
Correctly void transactions when payments are cancelled due to stock issues
2021-07-27 23:24:00 +01:00
Matt-Yorkley
886e03af2f
Merge pull request #7805 from Matt-Yorkley/adjustments-admin
...
[Adjustments] Admin adjustments
2021-07-27 12:23:29 +02:00
Matt-Yorkley
091bfc710f
Add test for applying multiple tax rates per tax zone
2021-07-25 22:47:40 +01:00
Nihal Mohammed
5864e2d36e
Update states controller spec
2021-07-14 13:18:01 +01:00
Matt-Yorkley
8e1631bfc7
Set adjustments associated with voided payments to ineligible.
...
Otherwise we can end up with duplicate transaction fees for voided payments.
2021-07-12 08:28:32 +01:00
Matt-Yorkley
fe92c31f4a
Update AdjustmentsController specs
2021-07-09 21:49:36 +01:00
Matt-Yorkley
32a2610e7d
Refactor arguments for PaymentIntentValidator
2021-07-09 13:42:41 +01:00
Matt-Yorkley
e5a85caef6
Refactor Stripe::PaymentIntentValidator
...
This makes the interface a lot simpler and moves the fetching of the information it requires inside the service itself.
2021-07-09 13:39:52 +01:00
Matt-Yorkley
e6d9545c30
Use :incomplete scope when voiding payments that can't be processed due to stock changes
2021-07-09 13:31:00 +01:00
Matt-Yorkley
a199f80ed4
Add test for insufficient stock behavior after Stripe redirect
2021-07-09 13:14:43 +01:00
Matt-Yorkley
2cd6b05aba
Use Order::Contents service in test setup
2021-07-09 13:14:43 +01:00
Andy Brett
9b1da14380
mark payment failed after failed authorization
2021-06-29 11:54:51 -07:00
Andy Brett
aa8067f96b
process payments separately from completing the order
2021-06-29 11:54:48 -07:00
Pau Pérez Fabregat
db993652c4
Merge branch 'master' into payment-states
2021-06-18 12:20:26 +02:00
Andy Brett
d9aa1b054a
update payments to be in requires_authorization state in specs
2021-06-17 18:10:41 -07:00
Andy Brett
2699e17b63
update specs to create payment in requires_authorization state
2021-06-17 14:23:59 -07:00
Luis Ramos
23627c5453
Run rubocop -a (safe corrections) removing all exceptions so all possible fixes are applied
...
9290 issues fixed
2021-06-17 22:19:26 +01:00
Pau Pérez Fabregat
a8efbffca6
Merge pull request #7429 from Matt-Yorkley/adjustments-taxrate
...
[Adjustments] TaxRate changes
2021-06-17 11:51:01 +02:00
Andy Brett
d145d3a8ec
add create/delete specs for admin and non-admin users
2021-06-09 14:06:55 +10:00
Andy Brett
a4bb697787
add spec for trying to create TOS with no file
2021-06-09 14:06:54 +10:00
Andy Brett
ba6ebdee15
Merge pull request #7686 from shen-sat/7470-add-delete-action-test-to-shipping-categories-controller-spec
...
[7470] Add delete action test to ShippingCategoriesController spec
2021-06-08 10:31:26 -07:00
Andy Brett
ede966f2d1
Merge pull request #7640 from apricot12/closed_OC_bheaviour
...
Checkout made to redirect to shop front when OC closed
2021-06-08 10:30:13 -07:00
Matt-Yorkley
8e0a84a502
Merge pull request #7729 from Matt-Yorkley/delayed-cleanup
...
Delayed::Cleanup
2021-06-07 19:11:37 +02:00
Matt-Yorkley
00988dc1e7
Use :order_with_totals factory in payments controller spec
...
This factory makes an order that actually has a line item 👍
2021-06-06 20:20:41 +01:00
Matt-Yorkley
7007de752d
Update BulkLineItemsController spec now that taxes on enterprise fees are updated correctly
...
Tax on fees previously stayed the same unless the fees were deleted recreated from scratch, instead of updating when the fee amounts changed
2021-06-06 20:20:41 +01:00