cyrillefr
d6daf25b98
Spec checking order in confirmation state transition to payment
2023-10-29 21:58:03 +01:00
cyrillefr
cd6c3c45e6
Allow an order in confirmation state to transition to payment
2023-10-29 21:58:03 +01:00
Ahmed Ejaz
df773aaee9
Merge branch 'master' into bugfix/11667-clone-tags-issue-for-OC
2023-10-28 14:57:43 +05:00
Ahmed Ejaz
adf65acee5
#11667 , fix existing test case
2023-10-28 14:03:27 +05:00
Ahmed Ejaz
0e0b322707
#11667 , assign tag_list to cloned exchange tag_list
2023-10-28 14:02:44 +05:00
dependabot[bot]
743a5e1a3c
chore(deps): bump browserify-sign from 4.2.1 to 4.2.2
...
Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign ) from 4.2.1 to 4.2.2.
- [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md )
- [Commits](https://github.com/crypto-browserify/browserify-sign/compare/v4.2.1...v4.2.2 )
---
updated-dependencies:
- dependency-name: browserify-sign
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-27 16:23:32 +00:00
dependabot[bot]
255872ebe3
chore(deps): bump valid_email2 from 5.1.0 to 5.1.1
...
Bumps [valid_email2](https://github.com/micke/valid_email2 ) from 5.1.0 to 5.1.1.
- [Changelog](https://github.com/micke/valid_email2/blob/master/CHANGELOG.md )
- [Commits](https://github.com/micke/valid_email2/compare/v5.1.0...v5.1.1 )
---
updated-dependencies:
- dependency-name: valid_email2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-27 09:45:13 +00:00
Gaetan Craig-Riou
33de80f13c
Fix checking if shipping method changed
...
We now check if the shipping method changed before we actually select
it. Fix the related spec.The spec was wrong because order.select_shipping_method
fails silently. That means the shipping method wasn't getting
updated on the order, thus the test was passing.
2023-10-27 14:20:31 +11:00
Gaetan Craig-Riou
4f961098c4
Update all locales with the latest Transifex translations
v4.4.17
2023-10-27 11:36:13 +11:00
Filipe
f1d4ec9fe7
Merge pull request #11684 from ccozkan/issue-11609
...
Fix content aligning in subscriptions table
2023-10-26 16:20:33 +01:00
Filipe
aa9cacada8
Merge pull request #11676 from openfoodfoundation/dependabot/bundler/stripe-10.0.0
...
chore(deps): bump stripe from 9.4.0 to 10.0.0
2023-10-26 15:41:49 +01:00
dependabot[bot]
0919b2bc6c
chore(deps-dev): bump rubocop from 1.57.1 to 1.57.2
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.57.1 to 1.57.2.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.57.1...v1.57.2 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-26 12:57:54 +00:00
Filipe
a54de4b522
Merge pull request #11691 from openfoodfoundation/dependabot/bundler/combine_pdf-1.0.24
...
chore(deps): bump combine_pdf from 1.0.23 to 1.0.24
2023-10-26 13:56:44 +01:00
Filipe
b67acaae21
Merge pull request #11694 from prateek0411999/bugfix/11666-warning_forfeit_remaining_amount
...
add condition on warning_forfeit_remaining_amount note
2023-10-26 13:44:22 +01:00
Filipe
3da8341946
Merge pull request #11695 from ccozkan/issue-8943
...
Make update button on enterprises primary details form clickable upon input to name field
2023-10-26 13:12:27 +01:00
Filipe
7b3c6e9f58
Merge pull request #11688 from mkllnk/enterprise-fee-report
...
Avoid error when generating Enterprise fees w/ Tax Report by Producer
2023-10-26 12:43:19 +01:00
Mohamed ABDELLANI
d6890e9828
check key class before call Rails.cache.delete
2023-10-26 10:27:00 +01:00
dependabot[bot]
38485a8010
chore(deps): bump active_storage_validations from 1.0.4 to 1.1.1
...
Bumps [active_storage_validations](https://github.com/igorkasyanchuk/active_storage_validations ) from 1.0.4 to 1.1.1.
- [Release notes](https://github.com/igorkasyanchuk/active_storage_validations/releases )
- [Changelog](https://github.com/igorkasyanchuk/active_storage_validations/blob/master/CHANGES.md )
- [Commits](https://github.com/igorkasyanchuk/active_storage_validations/compare/1.0.4...1.1.1 )
---
updated-dependencies:
- dependency-name: active_storage_validations
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-26 09:25:54 +00:00
Mohamed ABDELLANI
5360df6cee
replace hiredis gem with hiredis-client
2023-10-26 10:10:51 +01:00
David Cook
ed520ea679
Merge pull request #11703 from abdellani/remove-mini-portile2
...
removes mini_portile2
2023-10-26 09:40:38 +11:00
David Cook
7195314dc6
Merge pull request #11697 from openfoodfoundation/dependabot/bundler/mini_portile2-2.8.5
...
chore(deps): bump mini_portile2 from 2.8.4 to 2.8.5
2023-10-26 09:23:06 +11:00
Çağrı Özkan
924cee0876
Trigger build (empty commit)
2023-10-25 18:21:39 +03:00
Çağrı Özkan
7b21126a9c
Use both onchange and oninput on ng_form.html.haml
2023-10-25 17:32:25 +03:00
Filipe
6280bfcebe
Merge pull request #11706 from yasirazgar/11318_flaky_packing_report_spec
...
11318 - Fix flaky packing_report_spec.rb
2023-10-25 15:22:04 +01:00
Çağrı Özkan
38d1de896c
Use oninput on ng_form.html.haml instead of onchange
2023-10-25 17:11:30 +03:00
dependabot[bot]
8fc4d6cd4d
chore(deps): bump mini_portile2 from 2.8.4 to 2.8.5
...
Bumps [mini_portile2](https://github.com/flavorjones/mini_portile ) from 2.8.4 to 2.8.5.
- [Release notes](https://github.com/flavorjones/mini_portile/releases )
- [Changelog](https://github.com/flavorjones/mini_portile/blob/main/CHANGELOG.md )
- [Commits](https://github.com/flavorjones/mini_portile/compare/v2.8.4...v2.8.5 )
---
updated-dependencies:
- dependency-name: mini_portile2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-25 08:20:25 +00:00
Mohamed ABDELLANI
d77a94d377
add comment about mini_protile2 gem
2023-10-25 09:17:21 +01:00
David Cook
fac354e678
Merge pull request #11700 from macanudo527/fix_stylehash_12
...
Fix Style/HashSyntax 13/13
2023-10-25 10:40:52 +11:00
yasir azgar
3ba208e3d3
11318 - fix flaky packing_report_spec
...
fix rubocop DurationArithmetic
2023-10-24 22:21:42 +05:30
David Cook
08ac46fd91
Refactor spec: Only create necessary records
...
This was creating a lot of records for every single test. Now it's much more efficient and spec conditions are clearer.
2023-10-24 16:44:34 +11:00
David Cook
671dc570ec
Refactor: with form builder
2023-10-24 15:21:14 +11:00
David Cook
aa4630d74c
Mark fields as changed if they contain unsaved values.
...
This can happen when there's a validation error. The field with error will also be marked changed, but the error style will override it.
I'd like to move this into a FormBuilder. Existing formbuilder gems don't seem to support it (though I didn't look very hard).
2023-10-24 15:21:14 +11:00
David Cook
04032e61e2
Prettier
2023-10-24 15:21:13 +11:00
David Cook
fdad45bb46
Rename 'modified' state to 'changed'
...
This conveniently matches the terminology used in both JavaScript and ActiveModel::Dirty.
2023-10-24 15:21:13 +11:00
David Cook
ceb9d9af92
Add comment
...
I decided to look into why this is so complicated, in case some of the complexity can be removed. It can't :(
2023-10-24 15:21:13 +11:00
David Cook
1534908895
Move generic method to base class
...
Because rubocop complained about the size of ProductSet.
2023-10-24 15:21:13 +11:00
David Cook
89e53c88f3
Move context up a level
...
Best viewed with whitespace ignored.
2023-10-24 15:21:13 +11:00
David Cook
8293f24ed3
Remove redundant context
...
Best viewed with whitespace ignored.
2023-10-24 15:21:13 +11:00
David Cook
224b6f514b
Remove concept of master variant
...
from old bulk product screen. Hmm I just realised we're deleting that screen soon anyway.
But this helps clean up the spec before I refactor it further.
2023-10-24 15:21:13 +11:00
David Cook
be6481dac3
Refactor spec: combine expectations
...
These expectations have the same conditions, so why set it up three times?
2023-10-24 15:21:13 +11:00
David Cook
3710aa2149
Refactor spec
...
Better to explicitly test for the change, and specify expected values.
2023-10-24 15:21:13 +11:00
Neal Chambers
cf072fb56f
Update .rubocop_todo.yml
2023-10-24 08:49:48 +09:00
Neal Chambers
dc607b654d
Fix Style/HashSyntax
2023-10-24 08:49:34 +09:00
David Cook
a2f8b0db16
Update ansible group name
2023-10-24 10:37:32 +11:00
Maikel
42f5469de5
Merge pull request #11674 from mkllnk/money
...
Format money amounts according to locale, not currency
2023-10-24 09:47:37 +11:00
Sigmund Petersen
0d557eb0f2
Merge branch 'master' into dependabot/bundler/combine_pdf-1.0.24
2023-10-23 09:38:02 +02:00
prateek0411999
a113b5ba01
add condition on warning_forfeit_remaining_amount note
2023-10-23 10:45:35 +05:30
Gaetan Craig-Riou
d5d043880a
Fix scenario when no shipment available
...
I though that once the shipping method was set it's available on the
order, but apparently it's not always the case. At least some of the
test scenario have order with no shipment, thus no shipping method set.
2023-10-23 15:38:01 +11:00
Gaetan Craig-Riou
25af178011
Refactor updating order state
...
It makes the code a bit easier to read
2023-10-23 15:37:53 +11:00
Gaetan Craig-Riou
9f426add8d
Merge pull request #11690 from openfoodfoundation/dependabot/npm_and_yarn/tom-select-2.2.3
...
chore(deps): bump tom-select from 2.2.2 to 2.2.3
2023-10-23 09:48:48 +11:00