Matt-Yorkley
2864f62a08
Fix missing semicolons in spree_paypal_express.js
2021-01-09 13:22:25 +00:00
Matt-Yorkley
ab43c04ca8
Bring in translations
2021-01-09 13:22:25 +00:00
Matt-Yorkley
5c7dc6621b
Bring in views (and convert from ERB to HAML)
2021-01-09 13:22:25 +00:00
Matt-Yorkley
7f8fe631dd
Bring in Spree::PaypalExpressCheckout
2021-01-09 13:22:25 +00:00
Matt-Yorkley
2a27da1cc5
Bring in Spree::Gateway::PayPalExpress
2021-01-09 13:22:25 +00:00
Matt-Yorkley
2dce66f079
Fix some simple Rubocop offences
2021-01-09 13:22:25 +00:00
Matt-Yorkley
4ca3e29458
Apply changes from and remove Spree::PaypalController decorator
2021-01-09 13:22:25 +00:00
Matt-Yorkley
94549e98ba
Bring in Spree::PaypalController
2021-01-09 13:22:09 +00:00
Matt-Yorkley
597eed5285
Bring in Spree::Admin::PaypalPaymentsController
2021-01-09 13:22:09 +00:00
Matt-Yorkley
42468e2ef3
Apply Spree::Admin::PaymentsController decorator
2021-01-09 13:22:09 +00:00
Matt-Yorkley
2fb7dfa430
Bring in Paypal Express javascript
2021-01-09 13:22:09 +00:00
Matt-Yorkley
478f761188
Add Spree::Gateway::PayPalExpress to spree payment_methods list
2021-01-09 13:22:09 +00:00
Matt-Yorkley
dd5a197fb3
Remove ManagerInvitationJob
2021-01-09 11:56:27 +00:00
Matt-Yorkley
ca42b1fff7
Remove ConfirmSignupJob
2021-01-09 11:38:29 +00:00
Matt-Yorkley
6a7f795f64
Remove WelcomeEnterpriseJob
2021-01-09 11:33:10 +00:00
Andy Brett
3877721209
Merge pull request #6631 from Matt-Yorkley/actionmailer-deliver
...
[Deprecation] Replace ActionMailer#deliver with ActionMailer#deliver_now
2021-01-08 17:42:31 -08:00
Andy Brett
d6656804eb
Merge pull request #6557 from luisramos0/rubocop
...
Rubocop exceptions update
2021-01-08 17:36:23 -08:00
Andy Brett
08dcb13fca
Merge pull request #6578 from Matt-Yorkley/products-endpoint-content-type
...
Products endpoint content type
2021-01-08 17:34:26 -08:00
Andy Brett
ebecabdda5
Merge pull request #22 from Matt-Yorkley/sanitizer-service
...
Content Sanitizer
2021-01-08 17:31:59 -08:00
Matt-Yorkley
b7ecf4791a
Extract more sanitizing logic from Api::ProductSerializer and make service more generic/re-usable.
2021-01-09 01:07:11 +00:00
Matt-Yorkley
69640dc785
Tidy up producer mailer spec
...
This is covered in two other spec files relating to order cycles, the producer mailer spec doesn't need to know what calls the producer mailer.
2021-01-09 00:07:50 +00:00
Matt-Yorkley
a9706fa5f1
Update syntax in rake task
2021-01-08 23:18:55 +00:00
Matt-Yorkley
9d5eaa1790
Delete dead code in delayed job spec helper
2021-01-08 23:18:55 +00:00
Matt-Yorkley
496f2dab69
Ensure Jobs are instantiated correctly
...
We should not be using `Delayed::Job.enqueue` anywhere...
2021-01-08 23:18:55 +00:00
Matt-Yorkley
2dc918ff59
Ensure all Job classes correctly inherit from ActiveJob
2021-01-08 23:18:55 +00:00
Matt-Yorkley
ff962c1c9b
Change various Mailer invocations from #deliver_now to #deliver_later
2021-01-08 23:18:55 +00:00
Luis Ramos
2e4a206825
Add new offenses to exceptions file
2021-01-08 22:43:15 +00:00
Luis Ramos
0b45533237
Update rubocop todo list
2021-01-08 22:43:15 +00:00
Luis Ramos
42fff560fb
Attempt at rails 5 upgrade
2021-01-08 22:40:47 +00:00
Andy Brett
53b119ddb7
Merge pull request #6630 from coopdevs/update-haml-lint-config
...
Update haml lint config
2021-01-08 13:46:57 -08:00
Andy Brett
05f6337e7d
Merge pull request #6622 from openfoodfoundation/dependabot/bundler/ddtrace-0.44.0
...
Bump ddtrace from 0.43.0 to 0.44.0
2021-01-08 13:39:07 -08:00
Andy Brett
59527ab38a
refactor filter to a service
2021-01-08 13:37:18 -08:00
Luis Ramos
c2c491ced2
Setup dualboot for rails 5 upgrade
2021-01-08 21:34:13 +00:00
Matt-Yorkley
3e6445c51c
Replace deprecated ActionMailer#deliver with ActionMailer#deliver_now
...
DEPRECATION WARNING: `#deliver` is deprecated and will be removed in Rails 5. Use `#deliver_now` to deliver immediately or `#deliver_later` to deliver through Active Job.
2021-01-08 20:35:47 +00:00
Matt-Yorkley
87b14f0237
Avoid using #allow_any_instance_of
2021-01-08 17:47:09 +00:00
Matt-Yorkley
3b1ad29d20
Fix view rendering in Api::BaseController
2021-01-08 17:47:09 +00:00
Matt-Yorkley
eec9f27353
Move controller concern to correct directory
...
This is a controller concern, it should live in app/controllers/concerns/
2021-01-08 17:47:09 +00:00
Matt-Yorkley
d90ed56603
Add missing test for Api::OrderCyclesController responses
2021-01-08 17:47:09 +00:00
Matt-Yorkley
0dd57fc3de
Render an empty JSON object instead of a blank string
2021-01-08 17:47:09 +00:00
Matt-Yorkley
04e4893723
Update route declarations in caching spec
2021-01-08 17:47:09 +00:00
Matt-Yorkley
4ba3c81f90
Update route declaration in karma test
2021-01-08 17:47:09 +00:00
Matt-Yorkley
261ed751cb
Remove explicit content_type declarations in Api::OrderCyclesController
...
This should be handled in `Api::BaseController`
2021-01-08 17:47:09 +00:00
Matt-Yorkley
d0800b5e32
Specify json format for API routes that return json in OrderCycleResource
2021-01-08 17:47:09 +00:00
Pau Pérez Fabregat
95ab6c7d83
Merge pull request #6627 from Matt-Yorkley/dead-code-product-available
...
Delete dead code Spree::Product#available?
2021-01-08 17:35:21 +01:00
Pau Perez
b08a918ba5
Do not check for spaces inside the braces of hash
...
This shuts the annoying lint error
```
Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace
```
and it aligns with our existing style. See
https://github.com/openfoodfoundation/openfoodnetwork/pull/6629 as an
example.
2021-01-08 17:22:37 +01:00
Pau Perez
03bb9899fa
Copy Hound's default Haml lint config
2021-01-08 17:22:36 +01:00
dependabot[bot]
96cf1c0514
Bump ddtrace from 0.43.0 to 0.44.0
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 0.43.0 to 0.44.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v0.43.0...v0.44.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-01-08 16:20:47 +00:00
Pau Pérez Fabregat
8ca51c8b72
Merge pull request #6626 from Matt-Yorkley/flaky-oc-simple-spec
...
[Flaky Spec] Improve simple OC spec
2021-01-08 17:18:43 +01:00
Matt-Yorkley
0949e72c88
Merge pull request #6597 from Matt-Yorkley/cancancan
...
Switch from cancan to cancancan
2021-01-08 17:15:08 +01:00
Matt-Yorkley
139773bc22
Add inverse_of to associations between shipping methods and rates
...
See 20d913c21c
2021-01-08 15:42:58 +00:00