Pau Perez
76fe1c7ee9
Auto correct Rubocop's Layout/IndentAssignment cop
2018-04-09 18:47:18 +02:00
Pau Perez
6593dea4f6
Auto correct Rubocop's Layout/EmptyLinesAroundMethodBody cop
2018-04-09 18:47:17 +02:00
Pau Perez
746fcd5802
Auto correct Rubocop's Layout/EmptyLinesAroundAccessModifier cop
2018-04-09 18:47:17 +02:00
Hugo Daniel
3fa5ca7eae
Use accessible_by method instead of involving_managed_distributors method to fetch all order cycles
2018-02-21 17:33:28 +11:00
Hugo Daniel
65fea6291e
CodeClimate requested changes
2018-02-21 17:33:28 +11:00
Hugo Daniel
64c2bdda1c
Added loading of all active or complete order cycles concerned by the current user to the reports form collection
...
User will see all order cycles he is concerned by as producer, distributor or coordinator
2018-02-21 17:33:28 +11:00
Rob Harrington
e7eb02dfe3
Reduce cognitive complexity of VariantsController#search
2018-02-09 14:44:12 +11:00
Rob Harrington
d3937e5c80
Move customer address lookup action to CustomersController
2018-02-09 14:44:03 +11:00
Rob Harrington
9137f68a57
Adding logic to SearchController#customer_addresses for case when customer is not found
2018-02-09 14:44:00 +11:00
Rob Harrington
6ac49a7694
Adding route and controller action for searching for customer addresses using AddressFinder
2018-02-09 14:44:00 +11:00
Rob Harrington
946046e53b
Moving action for estimating standing_line_item prices into StandingLineItemController#build
2018-02-09 14:43:31 +11:00
Rob Harrington
415955e7b3
SO: Adding variants to a new standing order, price estimate provided
2018-02-09 14:43:30 +11:00
Matt-Yorkley
b893dea810
Make sure userSelect directive uses our Admin::UserSerializer instead of base Spree api view
2018-02-07 10:41:53 +11:00
Pierre de Lacroix
e13063e0c6
Fix before_filter for Spree::Admin::OrdersController#print_ticket
2017-11-23 11:01:41 +11:00
Julius Pabrinkis
94e31e35ba
Fix Spree::Admin::BaseController related issues
2017-11-10 08:47:12 +11:00
Rob Harrington
0bbaafbd41
Use guard clause
2017-09-23 14:58:34 +10:00
Rob Harrington
ca1987fc87
Prevent Stripe payment methods without account owners from being saved
2017-09-23 14:58:34 +10:00
Rob Harrington
6133b302af
Use guard clause in PaymentMethodsController#restrict_stripe_account_change
2017-09-23 14:58:33 +10:00
Rob Harrington
4865533f26
Restrict edit permissions on Stripe payment methods
2017-09-23 14:58:33 +10:00
Rob Harrington
42dd58426e
Auto-correct rubocop offences for stripe-connect
2017-09-23 14:58:32 +10:00
Rob Harrington
f890927423
Implementing the Stripe Connect feature toggle
2017-09-23 14:58:32 +10:00
stveep
d374ab569d
Undo dodgy redirect changes and set spec to pending
2017-09-23 14:57:02 +10:00
stveep
47df2dc20b
Tweaking redirects and links
2017-09-23 14:57:02 +10:00
stveep
5ae473e07f
Add specs, fix redirect after requring relogin
2017-09-23 14:57:02 +10:00
Pau Perez
5b1947429e
Fix odd-even background by relying on Spree
...
This removes unnecessary duplication of #destroy. We can make it work by
adding a simple fix in Spree.
2017-09-08 23:55:50 +10:00
Pau Perez
8db1fa4e77
Move JSON line items responses to a new controller
...
Extracts the JSON response from the admin's line item controller which
are only used by the bulk management feature into its own controller.
This decouples spree from an OFN-only feature and allows to remove
unnecessary code. Furthermore, Admin::LineItemsController is gone in
Spree 2.4.0.beta. See: https://github.com/spree/spree/pull/5280
2017-09-08 23:55:50 +10:00
Pau Perez
b3c94fd688
Revert "Load order also on open and close adjustments"
...
This reverts commit d77588431aa26422e2956fd3510a20b35dab1b1c.
2017-09-08 23:55:50 +10:00
Pau Perez
4d94b65d25
Load order also on open and close adjustments
...
@order is not loaded by Spree because we overrode the :before_filter in
spree/admin/orders_controller_decorator.rb. We need to also specify so in the
decorator.
2017-09-08 23:55:50 +10:00
Enrico Stano
d8e17231ec
Revert "Order email translation keys"
...
This reverts commit dc30e0b1042602ed8f03fe97444ccce8526e51b3.
2017-09-08 23:55:50 +10:00
Enrico Stano
ff2b2e17d9
Order email translation keys
2017-09-08 23:55:50 +10:00
Rob Harrington
595d7b5594
Remove conditional assignment from PaymentsController#fire decorator
2017-09-08 23:55:50 +10:00
Enrico Stano
62c5ccf904
Address CodeClimate complains
2017-09-08 23:55:50 +10:00
Enrico Stano
d09e0cd44a
Deal with both JS and JSON format
2017-09-08 23:55:50 +10:00
Enrico Stano
790bc5b187
Use JS format for #update
2017-09-08 23:55:50 +10:00
Pau Perez
f0e2d426c3
Fix getting HTML when deleting line item in admin
...
In the step 6 of the spree upgrade, when deleting an order's line item
from /admin we get an HTML response (the whole edit form) that gets
inserted into the flash error.
It's not 100% clear why we added a respond_to block for JSON but since
juery-rails sends ajax requests with application/javascript, */* in
the ACCEPTS request header, Rails falls back to the first specified respond_to
block, which is HTML. We don't hit the JSON block.
In order for this to work, this commit replaces the JSON respond_to
block with one for JS with the exact same behaviour; returning a 204.
This is also the format the spree controller action we duplicated originally
has besides HTML.
2017-09-08 23:55:50 +10:00
Pau Perez
8c56bd23fc
Add missing translation
2017-09-08 23:55:50 +10:00
enricostano
513330cfff
Add JSON api for products clone
2017-09-08 23:55:49 +10:00
Rohan Mitchell
c47af55bb9
Fix: When a user fires an event (eg. capture payment), take them back to where they came from
2017-09-08 23:55:49 +10:00
Rohan Mitchell
0a8e8dfbbb
Add specs and fix line items HTML response
2017-09-08 23:55:49 +10:00
Rohan Mitchell
1170897587
Add our own JSON handling actions for update and delete. Spree no longer does this for us.
2017-09-08 23:55:48 +10:00
Rohan Mitchell
2c374b448a
check_authorization removed in Spree. Add load_order before_filter to cover our custom actions.
2017-09-08 23:55:48 +10:00
Rohan Mitchell
5ad197278c
Fix rendering of order form for JSON requests
2017-09-08 23:55:48 +10:00
Julius Pabrinkis
9429695e15
Add i18n helper for controllers to switch language by params
2017-08-02 09:57:32 +10:00
Rob Harrington
7c0feab08f
Fix #1526 : add descriptions for reports *before* they are filtered
2017-07-28 17:15:57 +10:00
Julius Pabrinkis
ba0b17e168
Extract translations from controllers
2017-07-21 12:17:12 +10:00
Julius Pabrinkis
55b2c19b64
Extract translations from lib folder
2017-07-21 12:17:12 +10:00
Julius Pabrinkis
60060a7017
Start admin/reports extract translations
2017-07-21 12:17:12 +10:00
Pau Perez
cee24dcca7
Use indented style for multiline method calls
...
This enables the Rubocop's Style/MultilineMethodCallIndentation cop with
indentend enforced style. Which makes you split multiline method calls like:
orders = Spree::Order
.an_scope
.another_scope
.where(id: list_of_ids)
It also autofixes the current violations and updates the
rubocop_todo.yml
2017-07-12 10:40:53 +02:00
Rob Harrington
e5340cb53a
Rubocop: Correct Lint/UselessAssignment offences, disable for /spec in main config
2017-06-23 16:49:08 +10:00
Rob Harrington
7bb58342fc
Rubocop: Auto-correct Style/EmptyLineBetweenDefs offences
2017-06-23 16:49:08 +10:00
