Maikel
49d345e608
Merge pull request #13597 from deivid-rodriguez/fix-rspec-warning
...
Fix RSpec warning when running `Reporting::ReportRenderer.render_as` unit spec
2025-10-14 14:02:42 +11:00
David Rodríguez
98889365f1
Fix RSpec warning when running Reporting::ReportRenderer.render_as unit spec
...
Before:
```
$ bundle exec rspec -e ".render_as"
(...)
Run options: include {:full_description=>/\.render_as/}
WARNING: Using the `raise_error` matcher without providing a specific error or message risks false positives, since `raise_error` will match when Ruby raises a `NoMethodError`, `NameError` or `ArgumentError`, potentially allowing the expectation to pass without even executing the method you are intending to call. Actual error raised was #<ActionController::BadRequest: report_format should be in [:csv, :json, :html, :xlsx, :pdf]>. Instead consider providing a specific error class or message. This message can be suppressed by setting: `RSpec::Expectations.configuration.on_potential_false_positives = :nothing`. Called from /path/to/spec/lib/reports/report_renderer_spec.rb:34:in `block (3 levels) in <main>'.
.
Finished in 0.02544 seconds (files took 4.08 seconds to load)
1 example, 0 failures
```
After this patch:
```
$ bundle exec rspec -e ".render_as"
(...)
Run options: include {:full_description=>/\.render_as/}
.
Finished in 0.02488 seconds (files took 4.09 seconds to load)
1 example, 0 failures
```
2025-10-13 20:46:15 +02:00
David Rodríguez
bdafc1ff02
Use supported RSpec syntax
...
This spec was using a very old syntax no longer supported by RSpec. It's
not currently influencing specs result because the spec running into
the error is currently set as "pending". However, the spec is still run
and the error is still visible.
Fixing the syntax does not fix the spec, but lets it get a bit further.
2025-10-13 16:05:59 +02:00
David Cook
4852ee2c6e
Merge pull request #13587 from mkllnk/json-response
...
Clean up request specs testing JSON
2025-10-13 14:24:26 +11:00
Maikel Linke
d3319cfd69
Replace global spec helpers with faster let
2025-10-10 16:44:50 +11:00
Maikel Linke
378b5e656e
Use already parsed JSON in specs
...
Existing helpers provide indifferent access already.
2025-10-10 16:44:08 +11:00
Maikel Linke
9460d17417
Publish DFC endpoints as JSON
2025-10-10 16:18:22 +11:00
Maikel Linke
404c07a590
Spec DFC endpoint configuration
...
It looks like puma finds the file only under `/.well-known/dfc` and not
`/.well-known/dfc/` with a slash in staging environment while it works
here in dev and test.
And in any case, just placing the file in `public/` doesn't produce the
right content type.
2025-10-10 16:18:22 +11:00
Maikel Linke
1028d42e35
Update test token for new dev client id
2025-10-10 16:18:22 +11:00
Maikel Linke
bf661159c6
Notify data proxy of permission changes
2025-10-10 16:18:21 +11:00
Maikel Linke
ad78ef14ef
Automate replacement of generated image URLs in Swagger doc
2025-10-10 16:18:21 +11:00
Gareth Rogers
dc61580da1
Merge branch 'master' into add-report-name-and-details
2025-10-08 17:23:28 -04:00
Gareth
b956d6f21b
Added test coverage, converted instance_double to double as we do not need the actual method
2025-10-08 17:17:04 -04:00
David Cook
60ee33053d
Apply suggestions from code review
2025-10-08 14:15:56 +11:00
Maikel Linke
5b383237ea
Deactivate Puffing Billy to avoid hanging specs
2025-10-08 13:26:37 +11:00
Gareth Rogers
585073a326
Merge branch 'master' into add-report-name-and-details
2025-10-07 11:02:56 -04:00
Gareth
c3189892af
Removed other rows for now. Can be added in future PRs
2025-10-07 11:01:55 -04:00
David Cook
037030cf60
Merge pull request #13548 from mkllnk/test_rake
...
Configure rake specs in one place
2025-10-07 09:31:02 +11:00
Gareth Rogers
f414e04dea
Merge branch 'master' into add-report-name-and-details
2025-10-01 09:54:51 -04:00
Filipe
ef4d3ec138
Merge pull request #13506 from chahmedejaz/task/13505-remove-stripe-redirect-monkey-patch
...
Remove Stripe redirect monkeypatch and ensure reliable checkout flow
2025-10-01 13:03:58 +01:00
Gareth Rogers
0a9eb173ea
Add report name and details to CSV files
2025-10-01 13:59:43 +10:00
Filipe
ff2e0f4d45
Merge pull request #13533 from chahmedejaz/task/13435-sort-products-by-on-hand-amount
...
Sort product list by 'on hand' amount
2025-09-29 15:07:00 +01:00
Maikel Linke
6d284023fe
Configure rake specs in one place
...
So we don't have to add it to every rake spec file.
2025-09-22 17:27:58 +10:00
Maikel Linke
570b72868b
Simplify task loading code
2025-09-22 17:27:58 +10:00
Maikel Linke
286d9f8e7d
Remove unneeded declaration of Rails environment task in specs
2025-09-22 17:27:58 +10:00
Ahmed Ejaz
b0c3265cdb
update migration test to assert nil cvv_response_message for ineligible payments
2025-09-22 11:57:38 +05:00
Ahmed Ejaz
6bb709e85e
update test description to reflect patching of redirect_auth_url in cvv_result
2025-09-22 11:57:37 +05:00
Ahmed Ejaz
2df0078ea9
fix lint issues
2025-09-22 11:55:43 +05:00
Ahmed Ejaz
ca079e6e26
add migration to migrate cvv_message_response value to redirect_auth_url
...
- As per the patch, cvv_message_response contains 3D verification URL for those payments which require it. So need to migrate to the new column to maintain data integrity
2025-09-22 11:55:43 +05:00
Ahmed Ejaz
ac06126f59
replace cvv_response_message usage with redirect_auth_url
2025-09-22 11:55:43 +05:00
Ahmed Ejaz
aecb5f49c9
fix spec as per current response we get for cvv_result
2025-09-22 11:54:20 +05:00
Maikel
9e746d1b40
Merge pull request #13531 from rioug/better-stimulus-name-for-component
...
Load component stimulus controller with a shorter name
2025-09-17 17:10:37 +10:00
Filipe
bd1d9892a2
Merge pull request #13487 from rioug/security-241-fix-url-sanitization
...
Fix url sanitization for Stripe authorisation URL
2025-09-16 16:40:11 +01:00
Filipe
bfcadfd7c0
Merge pull request #13404 from cyrillefr/UnsavedChangesMustAppearOnRemovingSingleTagFromOrderCycle
...
Fixes Save button does not enable when removing only tag in OC
2025-09-15 13:27:26 +01:00
Ahmed Ejaz
1987f0b667
Remove redundant SQL string checks in product sorting specs for clarity
2025-09-15 11:57:33 +05:00
Ahmed Ejaz
0b5efae8c4
Refactor sorting expectations in product_sort_by_stocks_spec for clarity and accuracy
2025-09-15 11:56:07 +05:00
Gaetan Craig-Riou
36bb7cb317
Fix vertical ellipsis menu compoenent spec
2025-09-15 10:46:16 +10:00
Ahmed Ejaz
49dbe1d039
Refactor comments for clarity in product sorting concerns
2025-09-15 02:15:03 +05:00
Ahmed Ejaz
c326aa6b23
Add comprehensive specs for sorting functionality
2025-09-15 01:59:40 +05:00
Gaetan Craig-Riou
1c7fbd1d2d
Rename vertical ellipsis menu component files
...
There is no need to have a different name scheme to shorten stimulus
controller name. It's now inline with the other components
2025-09-10 15:27:56 +10:00
Gaetan Craig-Riou
8042dac74f
Fix stimulus controller name to use the shorter version
2025-09-10 15:10:10 +10:00
Filipe
da66a2947c
Merge pull request #13502 from cillian/replace-darker-background-disable-dynamically-inline-alert-page-alert-directives
...
Replace darker-background, disable-dynamically, inline-alert and page-alert Angular directives
2025-09-08 16:28:51 +01:00
David Cook
646d3b8ed9
Merge pull request #13524 from mkllnk/cleanup
...
Code cleanup
2025-09-08 14:31:34 +10:00
Gaetan Craig-Riou
1f15f094ce
Per review, check the URL is from a stripe subdomain
2025-09-08 11:00:11 +10:00
Cillian O'Ruanaidh
74e7bd5172
Update spec/system/consumer/shopping/cart_spec.rb test to use new disabled selector
2025-09-05 09:38:20 +01:00
Cillian O'Ruanaidh
66859f44ca
Include LinkHelper which includes new :link_to_or_disable method to fix spec/views/spree/orders/edit.html.haml_spec.rb test
2025-09-05 09:38:20 +01:00
Cillian O'Ruanaidh
6f7a547e15
Add a :link_to_or_disabled helper method
2025-09-05 09:38:20 +01:00
Maikel Linke
6c313a1b5a
Remove duplicate include of TimeHelpers in specs
2025-09-05 14:30:46 +10:00
filipefurtad0
589315780c
Adds coverage to homepage alert HTML content
2025-09-04 19:07:29 +01:00
Filipe
ddb8b2d08f
Merge pull request #13496 from dacook/fix-link
...
Fix link to enterprise payment methods tab
2025-08-28 19:17:37 +01:00
