Matt-Yorkley
072f4f4c60
Use new stripe confirm path and remove dead code
2022-01-14 19:41:08 +00:00
Filipe
cc0de4618c
Merge pull request #8692 from jibees/8691-make-first-name-and-last-name-fields-mandatory
...
Validate the presence of first/last name if there is no company
2022-01-12 19:48:35 +00:00
Filipe
d66dac4ccb
Merge pull request #8621 from apricot12/Unit-value-shop-front
...
Update units when variant unit name is edited
2022-01-11 17:41:20 +00:00
Jean-Baptiste Bellet
1a270af82b
Test the presence of the firstname and the lastname if company is not present
...
Co-Authored-By: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com >
2022-01-11 10:30:45 +01:00
Matt-Yorkley
aa6a4925ac
Update default images paths for logos
2021-12-27 17:45:06 +00:00
Filipe
750411fd15
Merge pull request #8592 from openfoodfoundation/gateway-redirects
...
Refactor payment gateway redirects handling
2021-12-23 21:35:45 +00:00
Matt-Yorkley
570eb21469
Merge pull request #8638 from cillian/store-payment-captured-at
...
Add a :captured_at column on payments to store when they are captured
2021-12-22 15:21:55 +00:00
Filipe
4001fa985b
Merge pull request #8612 from Matt-Yorkley/packing-reports-filtering
...
Packing reports filtering
2021-12-22 13:03:17 +00:00
Cillian O'Ruanaidh
84eaafb822
Add a :captured_at column on payments to store when they are captured
...
Fixes #8611 .
2021-12-17 14:45:47 +00:00
Matt-Yorkley
0fc4b851f2
Refactor payment gateway redirects handling
...
The checkout was holding a lot of responsibility for knowing which kinds of payment gateways are available and how to initiate the process of redirecting to the external payment page (if needed). This was being hidden somewhat by the way the logic was tucked away in services.
PaymentMethod objects now know whether or not they require an external payment process, and know how that process should be started and how to build the required URL.
So we can now *ask* any payment method if it requires external payment processing or not, and *tell* it to start the process and return the relevant URL (if needed).
2021-12-15 21:20:58 +00:00
Filipe
fd94f26765
Merge pull request #8557 from Matt-Yorkley/card-brand-formatting
...
Credit card brand formatting
2021-12-15 20:18:21 +00:00
Nihal M. Kelanthodika
44c3820a8f
Update units when variant unit name is edited
2021-12-15 12:30:10 +05:30
Matt-Yorkley
aecdfee364
Reorganise :though associations on line_item and allow searching/filtering on product, supplier, order_cycle
2021-12-12 13:23:56 +00:00
Matt-Yorkley
6d2521bf5f
Remove Spree.user_class
...
This construct was previously used in Spree to switch out the user class with a dummy class during certain tests. We don't use this any more, so it's just mess.
🔥
2021-12-10 18:18:20 +00:00
Maikel Linke
207cc8908a
Remove useless assignments
...
Rubocop highlighted this. The todo list actually contains these files
but somehow the cop still runs and reports these as violations.
2021-12-10 09:26:57 +11:00
Maikel Linke
64d25b2999
Remove dead code highlighted by Rubocop
...
The assignments here didn't actually do anything and `number` was
restricted to numbers only already. No whitespace to remove.
2021-12-10 09:26:57 +11:00
Matt-Yorkley
2408b7f74e
Simplify card formatting
2021-12-06 15:20:39 +00:00
Matt-Yorkley
87fe341b5b
Remove dead code: Order#backordered?
2021-12-05 15:17:27 +00:00
Matt-Yorkley
4cdb892c75
Refactor formatting of credit card brand names and reformat automatically when saving
...
This little bit of "translation" between what we might receive as input and what ActiveMerchant requires is important, but currently the responsibility for this job is spread all over the code base. It can now just live in the CreditCard model (in one place) and doesn't need to be duplicated anywhere else (like several different places in frontend Javascript!)
2021-12-02 16:22:52 +00:00
Jean-Baptiste Bellet
57a94d64f2
Revoke adjustment if payment is cancelled
2021-11-26 16:31:25 +01:00
Maikel
5f87c30d3e
Merge pull request #8465 from jibees/7963-permission-to-delete-relationship-both-ways
...
Manager can delete enterprises relationship in both direction
2021-11-23 09:20:32 +11:00
Matt-Yorkley
0efa370211
Merge pull request #8405 from jibees/7961-translate-stripe-error-message
...
Translate stripe error messages during payment processing
2021-11-16 11:49:12 +00:00
Jean-Baptiste Bellet
7041ec71a4
Translate some error messages during payment processing if exists
...
- Stripe error messages aren't translated. But, Stripe send the error code. Use it (if found it, and translation key does exist) to translated the error message
- Populate the en.yml file with some of the most known errors
Co-Authored-By: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com >
2021-11-11 12:04:38 +01:00
Jean-Baptiste Bellet
d2dbe6c738
Use distinct to return unique product
...
- Product were displayed twice (or more) in certain condition under order cycle incoming products admin interface
2021-11-10 14:49:19 +01:00
Jean-Baptiste Bellet
6266c3c5ae
User can delete relationship between enterprises in both direction
...
A permits B
B permits A
Manager for A and B enterprises can delete the two relations.
Update specs as well
2021-11-08 14:21:42 +01:00
Matt-Yorkley
817f0942dd
Pull in reports POC work replacing Packing reports
2021-11-04 14:55:23 +00:00
Luis Azcuaga
e8fd89a6d2
Run rubocop over existing todo
2021-10-25 21:28:28 -05:00
Adrien Chauve
3d6654a4b5
Cleanup errors on wrong image format
...
-> Remove all duplicates and use the same error message than in product
creation.
2021-10-17 22:47:12 +02:00
Nihal M. Kelanthodika
82d9b041c9
Remove unnecessary spaces and newlines
2021-10-06 15:06:57 +05:30
Nihal
f6e66de52b
Update phone validation to simple validation
2021-10-06 15:06:56 +05:30
Nihal
7eb0c6c33c
Add module to set unused ship, bill address fields
2021-10-06 15:06:56 +05:30
Nihal
5f1a326a05
Add before_validation callback to set unused addressed fields in customer, order, user, subscription, enterprise_group
2021-10-06 15:06:56 +05:30
Nihal
372326debc
Updated validation to include phone and edit address_spec to requires phone
2021-10-06 15:06:56 +05:30
Nihal Mohammed
32d8ce78ef
Re-add :country validation to spree_address model
2021-10-06 15:06:56 +05:30
Nihal Mohammed
7096667c6f
Add business_address form to business details section
2021-10-06 15:06:56 +05:30
Andy Brett
7a49b304d1
Merge pull request #8279 from Matt-Yorkley/orphaned-adjustments
...
Orphaned adjustments handing
2021-10-05 17:19:58 -07:00
Matt-Yorkley
65f08ee8f4
Deal with edge cases where an adjustment is left referencing a deleted item
2021-10-04 17:55:27 +01:00
Adrien Chauve
45eefb627d
Fix sorting orders by total in admin/ via api/v0/orders
2021-10-01 18:32:59 +02:00
Maikel
a3c31f7d86
Revert "Kill stripe connect"
2021-09-20 08:39:34 +10:00
Luis Ramos
60a8ae6675
Remove Stripe Connect gateway and related code
2021-09-10 14:43:24 +05:30
Maikel
9affc6a945
Merge pull request #8108 from Matt-Yorkley/andand
...
Remove `andand` gem
2021-09-10 15:06:00 +10:00
Maikel Linke
e013d81e3d
Simplify safe navigation operator use < and []
2021-09-10 14:40:46 +10:00
Andy Brett
069cb043ee
Merge pull request #8148 from jibees/5236-remove-incomplete-orders-from-admin-interface-2
...
Only shows order that actually have at least one line_item V2
2021-09-09 16:49:30 -07:00
Andy Brett
f8486bcbf8
Merge pull request #7769 from Matt-Yorkley/payment-status-checking
...
Stripe: payment status debugging
2021-09-08 15:21:38 -07:00
Matt-Yorkley
1d5077061e
Remove andand
...
This old gem implemented some functionality for handling nils which is no longer needed, as it's provided natively by Ruby with the &. operator.
2021-09-08 14:28:31 +01:00
Matt-Yorkley
b53371d870
Fix not_empty scope
2021-09-08 12:14:53 +01:00
Jean-Baptiste Bellet
0ec35b1f0d
Only shows order that actually have at least one line_item
...
Filter inside the API to shows only orders that have at least one line items
2021-09-07 17:25:46 +02:00
Matt-Yorkley
b4278aabbf
Merge branch 'master' into 8009-handling-shipping-adress
2021-09-07 09:44:49 +02:00
Matt-Yorkley
71412f8d4b
Update validations
2021-09-06 14:22:28 +01:00
Matt-Yorkley
c3b52ef00a
Remove payments validation
2021-09-06 14:19:35 +01:00
