From ff7c23c8f9661cc98c63cc358235a973e2918022 Mon Sep 17 00:00:00 2001 From: David Cook Date: Wed, 26 Feb 2025 16:05:28 +1100 Subject: [PATCH] Rename OrderCycleOpenedJob This name better reflects what it's doing. As this job is scheduled automatically by Sidekiq, I think there shouldn't be any jobs with the old name in redis. So I didn't bother keeping a placholder for the old name. And Clean up unused include --- ...e_opened_job.rb => trigger_order_cycles_to_open_job.rb} | 2 +- config/sidekiq.yml | 2 +- ...ob_spec.rb => trigger_order_cycles_to_open_job_spec.rb} | 7 ++----- 3 files changed, 4 insertions(+), 7 deletions(-) rename app/jobs/{order_cycle_opened_job.rb => trigger_order_cycles_to_open_job.rb} (88%) rename spec/jobs/{order_cycle_opened_job_spec.rb => trigger_order_cycles_to_open_job_spec.rb} (76%) diff --git a/app/jobs/order_cycle_opened_job.rb b/app/jobs/trigger_order_cycles_to_open_job.rb similarity index 88% rename from app/jobs/order_cycle_opened_job.rb rename to app/jobs/trigger_order_cycles_to_open_job.rb index 98977a9ba2..ca1d5c8393 100644 --- a/app/jobs/order_cycle_opened_job.rb +++ b/app/jobs/trigger_order_cycles_to_open_job.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true # Trigger jobs for any order cycles that recently opened -class OrderCycleOpenedJob < ApplicationJob +class TriggerOrderCyclesToOpenJob < ApplicationJob def perform recently_opened_order_cycles.find_each do |order_cycle| OpenOrderCycleJob.perform_later(order_cycle.id) diff --git a/config/sidekiq.yml b/config/sidekiq.yml index eab2b061db..bcd4e31909 100644 --- a/config/sidekiq.yml +++ b/config/sidekiq.yml @@ -15,7 +15,7 @@ every: "5m" SubscriptionConfirmJob: every: "5m" - OrderCycleOpenedJob: + TriggerOrderCyclesToOpenJob: every: "5m" OrderCycleClosingJob: every: "5m" diff --git a/spec/jobs/order_cycle_opened_job_spec.rb b/spec/jobs/trigger_order_cycles_to_open_job_spec.rb similarity index 76% rename from spec/jobs/order_cycle_opened_job_spec.rb rename to spec/jobs/trigger_order_cycles_to_open_job_spec.rb index d29be89ac1..9b27202503 100644 --- a/spec/jobs/order_cycle_opened_job_spec.rb +++ b/spec/jobs/trigger_order_cycles_to_open_job_spec.rb @@ -1,11 +1,8 @@ # frozen_string_literal: true require 'spec_helper' -require_relative '../../engines/dfc_provider/spec/support/authorization_helper' - -RSpec.describe OrderCycleOpenedJob do - include AuthorizationHelper +RSpec.describe TriggerOrderCyclesToOpenJob do let(:oc_opened_before) { create(:simple_order_cycle, orders_open_at: 1.hour.ago) } @@ -17,7 +14,7 @@ RSpec.describe OrderCycleOpenedJob do } it "enqueues jobs for recently opened order cycles only" do - expect{ OrderCycleOpenedJob.perform_now } + expect{ TriggerOrderCyclesToOpenJob.perform_now } .to enqueue_job(OpenOrderCycleJob).with(oc_opened_now.id) .and enqueue_job(OpenOrderCycleJob).with(oc_opened_before.id).exactly(0).times .and enqueue_job(OpenOrderCycleJob).with(oc_opening_soon.id).exactly(0).times