From fe5288c01549bb09f9a63d69ff5d063967962614 Mon Sep 17 00:00:00 2001 From: Neal Chambers Date: Tue, 15 Aug 2023 16:50:32 +0900 Subject: [PATCH] Update .rubocop_todo.yml --- .rubocop_todo.yml | 53 +++++++++++++++++++---------------------------- 1 file changed, 21 insertions(+), 32 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 50cdb2ef99..2a88db9bfe 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 1400 --no-auto-gen-timestamp` -# using RuboCop version 1.55.1. +# using RuboCop version 1.56.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -45,7 +45,7 @@ Lint/DuplicateRequire: Exclude: - 'spec/lib/open_food_network/scope_variants_to_search_spec.rb' -# Offense count: 19 +# Offense count: 18 # Configuration parameters: AllowComments, AllowEmptyLambdas. Lint/EmptyBlock: Exclude: @@ -184,7 +184,7 @@ Metrics/BlockNesting: Exclude: - 'app/models/spree/payment/processing.rb' -# Offense count: 48 +# Offense count: 45 # Configuration parameters: CountComments, Max, CountAsOne. Metrics/ClassLength: Exclude: @@ -197,7 +197,6 @@ Metrics/ClassLength: - 'app/controllers/api/v0/products_controller.rb' - 'app/controllers/application_controller.rb' - 'app/controllers/payment_gateways/paypal_controller.rb' - - 'app/controllers/split_checkout_controller.rb' - 'app/controllers/spree/admin/orders_controller.rb' - 'app/controllers/spree/admin/payment_methods_controller.rb' - 'app/controllers/spree/admin/payments_controller.rb' @@ -218,7 +217,6 @@ Metrics/ClassLength: - 'app/models/spree/payment.rb' - 'app/models/spree/product.rb' - 'app/models/spree/shipment.rb' - - 'app/models/spree/shipping_method.rb' - 'app/models/spree/user.rb' - 'app/models/spree/variant.rb' - 'app/models/spree/zone.rb' @@ -415,10 +413,11 @@ Naming/VariableNumber: - 'spec/requests/api/orders_spec.rb' # Offense count: 1 -# This cop supports unsafe autocorrection (--autocorrect-all). -Rails/ApplicationController: +# Configuration parameters: Severity, Include. +# Include: app/models/**/*.rb +Rails/ActiveRecordOverride: Exclude: - - 'engines/dfc_provider/app/controllers/dfc_provider/base_controller.rb' + - 'app/models/spree/product.rb' # Offense count: 8 # Configuration parameters: Include. @@ -488,12 +487,6 @@ Rails/I18nLocaleTexts: Exclude: - 'app/controllers/admin/stripe_accounts_controller.rb' -# Offense count: 1 -# This cop supports unsafe autocorrection (--autocorrect-all). -Rails/IgnoredColumnsAssignment: - Exclude: - - 'app/models/spree/variant.rb' - # Offense count: 22 # Configuration parameters: IgnoreScopes, Include. # Include: app/models/**/*.rb @@ -594,22 +587,17 @@ Rails/PluckInWhere: Exclude: - 'app/models/spree/variant.rb' -# Offense count: 30 +# Offense count: 22 # This cop supports unsafe autocorrection (--autocorrect-all). Rails/RedundantPresenceValidationOnBelongsTo: Exclude: - - 'app/models/enterprise.rb' - 'app/models/enterprise_fee.rb' - - 'app/models/enterprise_group.rb' - - 'app/models/enterprise_relationship.rb' - - 'app/models/enterprise_role.rb' - 'app/models/exchange.rb' - 'app/models/inventory_item.rb' - 'app/models/order_cycle.rb' - 'app/models/spree/address.rb' - 'app/models/spree/line_item.rb' - 'app/models/spree/order.rb' - - 'app/models/spree/product.rb' - 'app/models/spree/product_property.rb' - 'app/models/spree/return_authorization.rb' - 'app/models/spree/state.rb' @@ -915,13 +903,6 @@ Style/GuardClause: - 'spec/support/request/shop_workflow.rb' - 'spec/system/support/precompile_assets.rb' -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: braces, no_braces -Style/HashAsLastArrayItem: - Exclude: - # Offense count: 12 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: AllowSplatArgument. @@ -944,7 +925,7 @@ Style/HashLikeCase: Exclude: - 'app/models/enterprise.rb' -# Offense count: 1792 +# Offense count: 1782 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols. # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys @@ -1193,7 +1174,6 @@ Style/HashSyntax: - 'spec/models/concerns/order_shipment_spec.rb' - 'spec/models/concerns/product_stock_spec.rb' - 'spec/models/customer_spec.rb' - - 'spec/models/enterprise_caching_spec.rb' - 'spec/models/enterprise_fee_spec.rb' - 'spec/models/enterprise_relationship_spec.rb' - 'spec/models/enterprise_spec.rb' @@ -1207,7 +1187,6 @@ Style/HashSyntax: - 'spec/models/spree/address_spec.rb' - 'spec/models/spree/adjustment_spec.rb' - 'spec/models/spree/calculator_spec.rb' - - 'spec/models/spree/classification_spec.rb' - 'spec/models/spree/credit_card_spec.rb' - 'spec/models/spree/gateway/stripe_sca_spec.rb' - 'spec/models/spree/inventory_unit_spec.rb' @@ -1491,6 +1470,17 @@ Style/RedundantRegexpArgument: - 'app/models/spree/shipping_method.rb' - 'lib/spree/i18n.rb' +# Offense count: 5 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowMultipleReturnValues. +Style/RedundantReturn: + Exclude: + - 'app/models/product_import/entry_validator.rb' + - 'app/models/spree/stock/availability_validator.rb' + - 'lib/reporting/reports/enterprise_fee_summary/summarizer.rb' + - 'lib/stripe/authorize_response_patcher.rb' + - 'lib/tasks/data.rake' + # Offense count: 4 # This cop supports safe autocorrection (--autocorrect). Style/RedundantStringEscape: @@ -1508,10 +1498,9 @@ Style/ReturnNilInPredicateMethodDefinition: - 'app/serializers/api/admin/customer_serializer.rb' - 'engines/order_management/app/services/order_management/subscriptions/validator.rb' -# Offense count: 205 +# Offense count: 204 Style/Send: Exclude: - - 'app/controllers/split_checkout_controller.rb' - 'spec/controllers/admin/subscriptions_controller_spec.rb' - 'spec/controllers/payment_gateways/paypal_controller_spec.rb' - 'spec/controllers/spree/admin/base_controller_spec.rb'