From e863c3dec8cee3045f4be5e60cdd070427986e12 Mon Sep 17 00:00:00 2001 From: haseleyi Date: Tue, 4 Dec 2018 10:18:21 -0800 Subject: [PATCH 1/3] Fix broken link in register call partial --- app/views/shared/_register_call.html.haml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/views/shared/_register_call.html.haml b/app/views/shared/_register_call.html.haml index f4c03b7b92..f9456396f5 100644 --- a/app/views/shared/_register_call.html.haml +++ b/app/views/shared/_register_call.html.haml @@ -1,6 +1,6 @@ .alert-cta %h6 - %a{href: registration_path, target: "_blank"} + %a{href: "/register", target: "_blank"} = t '.selling_on_ofn'   %strong From 4a0744dd94e87cbb10a399b9c0b4052b7201f0b3 Mon Sep 17 00:00:00 2001 From: haseleyi Date: Thu, 6 Dec 2018 11:49:39 -0800 Subject: [PATCH 2/3] Add comment to explain hard-coded link --- app/views/shared/_register_call.html.haml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/views/shared/_register_call.html.haml b/app/views/shared/_register_call.html.haml index f9456396f5..be7a8242fc 100644 --- a/app/views/shared/_register_call.html.haml +++ b/app/views/shared/_register_call.html.haml @@ -1,5 +1,9 @@ .alert-cta %h6 + -# Please forgive the hard-coded link: + The more elegant 'registration_path' resolves to /signup due to spree_auth_device > config > routes.rb + This is one of several possible fixes. Long-term, we'd like to bring the accounts page into OFN. + View the discussion here: https://github.com/openfoodfoundation/openfoodnetwork/pull/3174 %a{href: "/register", target: "_blank"} = t '.selling_on_ofn'   From 3f6e96dd5de163bd99e51b7ddf553d7695b39f39 Mon Sep 17 00:00:00 2001 From: haseleyi Date: Thu, 6 Dec 2018 14:05:53 -0800 Subject: [PATCH 3/3] Fix comment --- app/views/shared/_register_call.html.haml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/views/shared/_register_call.html.haml b/app/views/shared/_register_call.html.haml index be7a8242fc..54c55af680 100644 --- a/app/views/shared/_register_call.html.haml +++ b/app/views/shared/_register_call.html.haml @@ -1,9 +1,9 @@ .alert-cta %h6 -# Please forgive the hard-coded link: - The more elegant 'registration_path' resolves to /signup due to spree_auth_device > config > routes.rb - This is one of several possible fixes. Long-term, we'd like to bring the accounts page into OFN. - View the discussion here: https://github.com/openfoodfoundation/openfoodnetwork/pull/3174 + -# The more elegant 'registration_path' resolves to /signup due to spree_auth_device > config > routes.rb + -# This is one of several possible fixes. Long-term, we'd like to bring the accounts page into OFN. + -# View the discussion here: https://github.com/openfoodfoundation/openfoodnetwork/pull/3174 %a{href: "/register", target: "_blank"} = t '.selling_on_ofn'