From fd68cbf56dab10dcc380c8e8e642bd1ad7484b0e Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Wed, 22 Mar 2023 14:40:20 +1100 Subject: [PATCH] Remove on-the-fly adding of feature toggle entries We now have a new source of truth. You shouldn't use a feature toggle without adding it to OpenFoodNetwork::FeatureToggle first. All toggles are added at boot time already. --- lib/open_food_network/feature_toggle.rb | 4 +--- spec/lib/open_food_network/feature_toggle_spec.rb | 7 ------- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/lib/open_food_network/feature_toggle.rb b/lib/open_food_network/feature_toggle.rb index 981155e5d6..e0b8e49451 100644 --- a/lib/open_food_network/feature_toggle.rb +++ b/lib/open_food_network/feature_toggle.rb @@ -60,9 +60,7 @@ module OpenFoodNetwork end def self.enabled?(feature_name, user = nil) - feature = Flipper.feature(feature_name) - feature.add unless feature.exist? - feature.enabled?(user) + Flipper.enabled?(feature_name, user) end def self.disabled?(feature_name, user = nil) diff --git a/spec/lib/open_food_network/feature_toggle_spec.rb b/spec/lib/open_food_network/feature_toggle_spec.rb index ce18fb5bba..97e41108a6 100644 --- a/spec/lib/open_food_network/feature_toggle_spec.rb +++ b/spec/lib/open_food_network/feature_toggle_spec.rb @@ -13,13 +13,6 @@ module OpenFoodNetwork Flipper.enable(:foo) expect(FeatureToggle.enabled?(:foo)).to be true end - - it "adds features to the database for easy admin in the UI" do - feature = Flipper.feature(:sparkling_new) - - expect { FeatureToggle.enabled?(:sparkling_new) }. - to change { feature.exist? }.from(false).to(true) - end end end end