From fcdc627ce360879435207aa6d81cbaeeb6fe3c6b Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Thu, 18 Mar 2021 17:01:04 +0000
Subject: [PATCH] Add fallbacks in migration for migrating locally with
 RAILS_ENV=test

Instances have these preference values set, but when running this migration locally with RAILS_ENV=test, the preference does not exist in the database.
---
 db/migrate/20210224190247_migrate_shipping_taxes.rb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/db/migrate/20210224190247_migrate_shipping_taxes.rb b/db/migrate/20210224190247_migrate_shipping_taxes.rb
index f305de7862..84721310e7 100644
--- a/db/migrate/20210224190247_migrate_shipping_taxes.rb
+++ b/db/migrate/20210224190247_migrate_shipping_taxes.rb
@@ -25,11 +25,11 @@ class MigrateShippingTaxes < ActiveRecord::Migration
   end
 
   def instance_uses_shipping_tax?
-    Spree::Preference.find_by(key: '/spree/app_configuration/shipment_inc_vat').value
+    Spree::Preference.find_by(key: '/spree/app_configuration/shipment_inc_vat')&.value || false
   end
 
   def instance_shipping_tax_rate
-    Spree::Preference.find_by(key: '/spree/app_configuration/shipping_tax_rate').value
+    Spree::Preference.find_by(key: '/spree/app_configuration/shipping_tax_rate')&.value || 0.0
   end
   
   def shipping_tax_category