diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index bd2b7c9b67..d0292c2fd8 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -121,16 +121,6 @@ Lint/SelfAssignment: Exclude: - 'app/models/spree/order/checkout.rb' -# Offense count: 9 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: strict, consistent -Lint/SymbolConversion: - Exclude: - - 'app/models/spree/preferences/preferable_class_methods.rb' - - 'app/services/sets/product_set.rb' - - 'lib/spree/core/environment_extension.rb' - # Offense count: 1 # This cop supports unsafe autocorrection (--autocorrect-all). Lint/UselessMethodDefinition: diff --git a/app/models/spree/preferences/preferable_class_methods.rb b/app/models/spree/preferences/preferable_class_methods.rb index 4bff9406f6..71f6b746f7 100644 --- a/app/models/spree/preferences/preferable_class_methods.rb +++ b/app/models/spree/preferences/preferable_class_methods.rb @@ -70,31 +70,31 @@ module Spree end def preference_getter_method(name) - "preferred_#{name}".to_sym + :"preferred_#{name}" end def preference_setter_method(name) - "preferred_#{name}=".to_sym + :"preferred_#{name}=" end def prefers_getter_method(name) - "prefers_#{name}?".to_sym + :"prefers_#{name}?" end def prefers_setter_method(name) - "prefers_#{name}=".to_sym + :"prefers_#{name}=" end def preference_default_getter_method(name) - "preferred_#{name}_default".to_sym + :"preferred_#{name}_default" end def preference_type_getter_method(name) - "preferred_#{name}_type".to_sym + :"preferred_#{name}_type" end def preference_description_getter_method(name) - "preferred_#{name}_description".to_sym + :"preferred_#{name}_description" end end end diff --git a/app/services/sets/product_set.rb b/app/services/sets/product_set.rb index 362acae3f1..1adcdcb579 100644 --- a/app/services/sets/product_set.rb +++ b/app/services/sets/product_set.rb @@ -118,7 +118,7 @@ module Sets # Copy any variant errors to product variant&.errors&.each do |error| # The name is namespaced to avoid confusion with product attrs of same name. - product.errors.add("variant_#{error.attribute}".to_sym, error.message) + product.errors.add(:"variant_#{error.attribute}", error.message) end variant&.errors.blank? end diff --git a/lib/spree/core/environment_extension.rb b/lib/spree/core/environment_extension.rb index 674ed9dbf2..56d54517ea 100644 --- a/lib/spree/core/environment_extension.rb +++ b/lib/spree/core/environment_extension.rb @@ -8,7 +8,7 @@ module Spree def add_class(name) instance_variable_set "@#{name}", Set.new - create_method( "#{name}=".to_sym ) { |val| + create_method( :"#{name}=" ) { |val| instance_variable_set( "@" + name, val) }