From fb2467865483a3283dff461da86756ed4113c55c Mon Sep 17 00:00:00 2001 From: Mohamed ABDELLANI Date: Tue, 31 Oct 2023 18:57:42 +0100 Subject: [PATCH] update units list on Spree::Admin::GeneralSettingsHelper#all_units added a test to make sure that all units on WeightsAndMeasures::UNITS are list on all_units --- app/helpers/spree/admin/general_settings_helper.rb | 7 ++++++- spec/services/weights_and_measures_spec.rb | 8 ++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/app/helpers/spree/admin/general_settings_helper.rb b/app/helpers/spree/admin/general_settings_helper.rb index a370354c37..a40ef75940 100644 --- a/app/helpers/spree/admin/general_settings_helper.rb +++ b/app/helpers/spree/admin/general_settings_helper.rb @@ -4,7 +4,12 @@ module Spree module Admin module GeneralSettingsHelper def all_units - ["g", "oz", "lb", "kg", "T", "mL", "L", "kL"] + [ + "mg", "g", "kg", "T", + "oz", "lb", + "mL", "cL", "dL", "L", "kL", + "gal" + ] end end end diff --git a/spec/services/weights_and_measures_spec.rb b/spec/services/weights_and_measures_spec.rb index c6f98e6e5a..5be6e012f3 100644 --- a/spec/services/weights_and_measures_spec.rb +++ b/spec/services/weights_and_measures_spec.rb @@ -90,4 +90,12 @@ describe WeightsAndMeasures do end end end + + describe "UNITS" do + include Spree::Admin::GeneralSettingsHelper + it "should include all the available untis" do + units = WeightsAndMeasures::UNITS.values.flat_map(&:values).pluck("name").sort.uniq + expect(units).to eq(all_units.sort.uniq) + end + end end