From fb09a7f1e62de5333fce89c960bcbccc9ee9cf33 Mon Sep 17 00:00:00 2001 From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com> Date: Tue, 8 Aug 2023 19:42:26 +0100 Subject: [PATCH] Fix product filtering --- app/assets/javascripts/admin/bulk_product_update.js.coffee | 4 ++-- .../darkswarm/controllers/products_controller.js.coffee | 2 +- app/reflexes/products_reflex.rb | 2 +- spec/controllers/api/v0/order_cycles_controller_spec.rb | 2 +- spec/controllers/api/v0/products_controller_spec.rb | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/app/assets/javascripts/admin/bulk_product_update.js.coffee b/app/assets/javascripts/admin/bulk_product_update.js.coffee index 4598669203..5adb65c399 100644 --- a/app/assets/javascripts/admin/bulk_product_update.js.coffee +++ b/app/assets/javascripts/admin/bulk_product_update.js.coffee @@ -48,7 +48,7 @@ angular.module("ofn.admin").controller "AdminProductEditCtrl", ($scope, $timeout params = { 'q[name_cont]': $scope.q.query, 'q[supplier_id_eq]': $scope.q.producerFilter, - 'q[primary_taxon_id_eq]': $scope.q.categoryFilter, + 'q[variants_primary_taxon_id_eq]': $scope.q.categoryFilter, 'q[s]': $scope.sorting, import_date: $scope.q.importDateFilter, page: $scope.page, @@ -218,7 +218,7 @@ angular.module("ofn.admin").controller "AdminProductEditCtrl", ($scope, $timeout filters: 'q[name_cont]': $scope.q.query 'q[supplier_id_eq]': $scope.q.producerFilter - 'q[primary_taxon_id_eq]': $scope.q.categoryFilter + 'q[variants_primary_taxon_id_eq]': $scope.q.categoryFilter 'q[s]': $scope.sorting import_date: $scope.q.importDateFilter page: $scope.page diff --git a/app/assets/javascripts/darkswarm/controllers/products_controller.js.coffee b/app/assets/javascripts/darkswarm/controllers/products_controller.js.coffee index 521859f7ab..79f1db42ab 100644 --- a/app/assets/javascripts/darkswarm/controllers/products_controller.js.coffee +++ b/app/assets/javascripts/darkswarm/controllers/products_controller.js.coffee @@ -68,7 +68,7 @@ angular.module('Darkswarm').controller "ProductsCtrl", ($scope, $sce, $filter, $ per_page: $scope.per_page, 'q[name_or_meta_keywords_or_variants_display_as_or_variants_display_name_or_supplier_name_cont]': $scope.query, 'q[with_properties][]': $scope.activeProperties, - 'q[primary_taxon_id_in_any][]': $scope.activeTaxons + 'q[variants_primary_taxon_id_in_any][]': $scope.activeTaxons } $scope.searchKeypress = (e)-> diff --git a/app/reflexes/products_reflex.rb b/app/reflexes/products_reflex.rb index b312c74205..650ce2b23f 100644 --- a/app/reflexes/products_reflex.rb +++ b/app/reflexes/products_reflex.rb @@ -173,7 +173,7 @@ class ProductsReflex < ApplicationReflex if @search_term.present? query.merge!(Spree::Variant::SEARCH_KEY => @search_term) end - query.merge!(primary_taxon_id_in: @category_id) if @category_id.present? + query.merge!(variants_primary_taxon_id_in: @category_id) if @category_id.present? query end diff --git a/spec/controllers/api/v0/order_cycles_controller_spec.rb b/spec/controllers/api/v0/order_cycles_controller_spec.rb index 7a8aaa0a24..a8640fa581 100644 --- a/spec/controllers/api/v0/order_cycles_controller_spec.rb +++ b/spec/controllers/api/v0/order_cycles_controller_spec.rb @@ -126,7 +126,7 @@ module Api context "with taxon filters" do it "filters by taxon" do api_get :products, id: order_cycle.id, distributor: distributor.id, - q: { primary_taxon_id_in_any: [taxon2.id] } + q: { variants_primary_taxon_id_in_any: [taxon2.id] } expect(product_ids).to include product2.id, product3.id expect(product_ids).not_to include product1.id, product4.id diff --git a/spec/controllers/api/v0/products_controller_spec.rb b/spec/controllers/api/v0/products_controller_spec.rb index 96f22a9fe8..90480a6f2e 100644 --- a/spec/controllers/api/v0/products_controller_spec.rb +++ b/spec/controllers/api/v0/products_controller_spec.rb @@ -267,7 +267,7 @@ describe Api::V0::ProductsController, type: :controller do end it "filters results by product category" do - api_get :bulk_products, { page: 1, per_page: 15, q: { primary_taxon_id_eq: taxon.id } }, + api_get :bulk_products, { page: 1, per_page: 15, q: { variants_primary_taxon_id_eq: taxon.id } }, format: :json expect(returned_product_ids).to eq [product3.id, product2.id] end