From faf7e3c02be90d3ffeda964359a0e10e658bcb0d Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Wed, 24 Feb 2021 12:35:53 +0000
Subject: [PATCH] Simplify filtering items with zero price

---
 app/services/paypal_items_builder.rb | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/app/services/paypal_items_builder.rb b/app/services/paypal_items_builder.rb
index dadfb04283..b0497c3372 100644
--- a/app/services/paypal_items_builder.rb
+++ b/app/services/paypal_items_builder.rb
@@ -15,11 +15,9 @@ class PaypalItemsBuilder
     # Because PayPal doesn't accept $0 items at all.
     # See https://github.com/spree-contrib/better_spree_paypal_express/issues/10
     # "It can be a positive or negative value but not zero."
-    items.reject! do |item|
+    items.reject do |item|
       item[:Amount][:value].zero?
     end
-
-    items
   end
 
   private