From faa7c0a7c595a81234dec6050554e25ea4b87b64 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Fri, 3 Jul 2020 14:02:14 +0200
Subject: [PATCH] Extract save_cookies_from_locale comment-method

---
 app/services/user_locale_setter.rb | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/app/services/user_locale_setter.rb b/app/services/user_locale_setter.rb
index c3dee48bf7..99fcd57e4e 100644
--- a/app/services/user_locale_setter.rb
+++ b/app/services/user_locale_setter.rb
@@ -9,11 +9,7 @@ class UserLocaleSetter
 
   def call
     save_locale_from_params
-
-    # After logging in, check if the user chose a locale before
-    if current_user_locale.nil? && cookies[:locale] && available_locale?(params_locale)
-      current_user&.update!(locale: params_locale)
-    end
+    save_locale_from_cookies
 
     I18n.locale = valid_current_locale
   end
@@ -47,6 +43,13 @@ class UserLocaleSetter
     cookies[:locale] = params_locale
   end
 
+  def save_locale_from_cookies
+    return unless current_user_locale.nil? && cookies[:locale] &&
+                  available_locale?(params_locale)
+
+    current_user&.update!(locale: params_locale)
+  end
+
   def available_locale?(locale)
     self.class.available_locale?(locale)
   end