From fa14a802950be7cbc87d8df1f7545967a0c2e513 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Sun, 11 Apr 2021 13:09:49 +0100
Subject: [PATCH] Adapt order payment creation in failing specs

In the test setups here order.payments is empty
---
 spec/controllers/api/v0/orders_controller_spec.rb | 2 +-
 spec/features/admin/orders_spec.rb                | 2 +-
 spec/models/spree/order_spec.rb                   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/spec/controllers/api/v0/orders_controller_spec.rb b/spec/controllers/api/v0/orders_controller_spec.rb
index cfae14f85a..4a76605138 100644
--- a/spec/controllers/api/v0/orders_controller_spec.rb
+++ b/spec/controllers/api/v0/orders_controller_spec.rb
@@ -274,7 +274,7 @@ module Api
 
       before do
         order.finalize!
-        create(:check_payment, order: order, amount: order.total)
+        order.payments << create(:check_payment, order: order, amount: order.total)
         allow(controller).to receive(:spree_current_user) { order.distributor.owner }
       end
 
diff --git a/spec/features/admin/orders_spec.rb b/spec/features/admin/orders_spec.rb
index 7408d53005..63e9feb687 100644
--- a/spec/features/admin/orders_spec.rb
+++ b/spec/features/admin/orders_spec.rb
@@ -65,7 +65,7 @@ feature '
     context "with a capturable order" do
       before do
         order.finalize! # ensure order has a payment to capture
-        create :check_payment, order: order, amount: order.total
+        order.payments << create(:check_payment, order: order, amount: order.total)
       end
 
       scenario "capture payment" do
diff --git a/spec/models/spree/order_spec.rb b/spec/models/spree/order_spec.rb
index 3a1b6988bd..a143290fe7 100644
--- a/spec/models/spree/order_spec.rb
+++ b/spec/models/spree/order_spec.rb
@@ -1174,7 +1174,7 @@ describe Spree::Order do
       it "advances to complete state without error" do
         advance_to_delivery_state(order)
         order.next!
-        create(:payment, order: order)
+        order.payments << create(:payment, order: order)
 
         expect { order.next! }.to change { order.state }.from("payment").to("complete")
       end