From f9322ac71b6b3838557f29c6a26e6d3732deca3a Mon Sep 17 00:00:00 2001
From: Maikel Linke <maikel@email.org.au>
Date: Tue, 25 Feb 2025 16:11:55 +1100
Subject: [PATCH] Style: simplify controller method

---
 .../admin/dfc_product_imports_controller.rb     | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/app/controllers/admin/dfc_product_imports_controller.rb b/app/controllers/admin/dfc_product_imports_controller.rb
index 5b35082908..4e87b6b2ac 100644
--- a/app/controllers/admin/dfc_product_imports_controller.rb
+++ b/app/controllers/admin/dfc_product_imports_controller.rb
@@ -20,12 +20,7 @@ module Admin
       catalog = DfcCatalog.from_json(@catalog_json)
 
       # Render table and let user decide which ones to import.
-      @items = catalog.products.map do |subject|
-        [
-          subject,
-          @enterprise.supplied_variants.linked_to(subject.semanticId)&.product
-        ]
-      end
+      @items = list_products(catalog)
     rescue URI::InvalidURIError
       flash[:error] = t ".invalid_url"
       redirect_to admin_product_import_path
@@ -75,5 +70,15 @@ module Admin
         .managed_product_enterprises.is_primary_producer
         .find(params.require(:enterprise_id))
     end
+
+    # List internal and external products for the preview.
+    def list_products(catalog)
+      catalog.products.map do |subject|
+        [
+          subject,
+          @enterprise.supplied_variants.linked_to(subject.semanticId)&.product
+        ]
+      end
+    end
   end
 end