From 695f76d3b6993447eb4629ba4b2808b982306aa4 Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Bellet Date: Wed, 19 Jul 2023 16:28:03 +0200 Subject: [PATCH 1/2] Update format to be solve prettier warnings --- app/webpacker/controllers/tabs_and_panels_controller.js | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/app/webpacker/controllers/tabs_and_panels_controller.js b/app/webpacker/controllers/tabs_and_panels_controller.js index 0f67dd8c85..9c2839ab49 100644 --- a/app/webpacker/controllers/tabs_and_panels_controller.js +++ b/app/webpacker/controllers/tabs_and_panels_controller.js @@ -49,9 +49,7 @@ export default class extends Controller { } updateActivePanel(panel_id) { - const newActivePanel = this.panelTargets.find( - (panel) => panel.id == panel_id - ); + const newActivePanel = this.panelTargets.find((panel) => panel.id == panel_id); if (newActivePanel === undefined) { // No panel found @@ -84,8 +82,6 @@ export default class extends Controller { } get currentActivePanel() { - return this.panelTargets.find( - (panel) => panel.id == `${this.currentActiveTab.id}_panel` - ); + return this.panelTargets.find((panel) => panel.id == `${this.currentActiveTab.id}_panel`); } } From 1750575f8c83d10d14e0e1581d3d991ca5aeae39 Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Bellet Date: Wed, 19 Jul 2023 16:28:10 +0200 Subject: [PATCH 2/2] Need to update tab before updating panel since we retrieve panel from tab --- app/webpacker/controllers/tabs_and_panels_controller.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/webpacker/controllers/tabs_and_panels_controller.js b/app/webpacker/controllers/tabs_and_panels_controller.js index 9c2839ab49..d3ea9a44fe 100644 --- a/app/webpacker/controllers/tabs_and_panels_controller.js +++ b/app/webpacker/controllers/tabs_and_panels_controller.js @@ -40,8 +40,8 @@ export default class extends Controller { } simulateClick(tab, panel) { - this.updateActiveTab(tab); this.updateActivePanel(panel); + this.updateActiveTab(tab); } changeActivePanel(event) {