From f76bdf0c6f48ae21c388cdd856999876b59c9f3b Mon Sep 17 00:00:00 2001 From: Gaetan Craig-Riou Date: Fri, 3 Nov 2023 16:46:42 +1100 Subject: [PATCH] Fix rubocop warning --- engines/dfc_provider/lib/dfc_provider/supplied_product.rb | 5 ++--- .../spec/services/supplied_product_builder_spec.rb | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/engines/dfc_provider/lib/dfc_provider/supplied_product.rb b/engines/dfc_provider/lib/dfc_provider/supplied_product.rb index dcaf35d9b5..2e9e3a22c2 100644 --- a/engines/dfc_provider/lib/dfc_provider/supplied_product.rb +++ b/engines/dfc_provider/lib/dfc_provider/supplied_product.rb @@ -2,8 +2,7 @@ module DfcProvider class SuppliedProduct < DataFoodConsortium::Connector::SuppliedProduct - attr_accessor :spree_product_id - attr_accessor :image + attr_accessor :spree_product_id, :image def initialize(semantic_id, spree_product_id: nil, image_url: nil, **properties) super(semantic_id, **properties) @@ -16,7 +15,7 @@ module DfcProvider end # Temporary solution, will be replaced by "dfc_b:image" in future version of the DFC connector registerSemanticProperty("ofn:image") do - self.image + image end end end diff --git a/engines/dfc_provider/spec/services/supplied_product_builder_spec.rb b/engines/dfc_provider/spec/services/supplied_product_builder_spec.rb index 21d4c8fcbb..464cc73036 100644 --- a/engines/dfc_provider/spec/services/supplied_product_builder_spec.rb +++ b/engines/dfc_provider/spec/services/supplied_product_builder_spec.rb @@ -49,7 +49,7 @@ describe SuppliedProductBuilder do end it "assigns an image_url type" do - image = Spree::Image.create!( + Spree::Image.create!( attachment: white_logo_file, viewable_id: variant.product.id, viewable_type: 'Spree::Product'