From f2a2cbd3f9c1822b18f46450da1e911071fd00e0 Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Thu, 25 Mar 2021 17:09:09 +1100 Subject: [PATCH] Spec stock bug when changing canceled orders We decided to disallow changing canceled orders in a way that would affect stock or totals. --- .../api/v0/shipments_controller_spec.rb | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/spec/controllers/api/v0/shipments_controller_spec.rb b/spec/controllers/api/v0/shipments_controller_spec.rb index cf04568a78..fe249ba2b7 100644 --- a/spec/controllers/api/v0/shipments_controller_spec.rb +++ b/spec/controllers/api/v0/shipments_controller_spec.rb @@ -154,6 +154,30 @@ describe Api::V0::ShipmentsController, type: :controller do }.to change { existing_variant.reload.on_hand }.by(2) end end + + context "for canceled orders" do + before do + expect(order.cancel).to eq true + end + + it "doesn't adjusts stock when adding a variant" do + pending "https://github.com/openfoodfoundation/openfoodnetwork/issues/7166" + + expect { + api_put :add, params.merge(variant_id: existing_variant.to_param) + expect(response.status).to eq(422) + }.to_not change { existing_variant.reload.on_hand } + end + + it "doesn't adjusts stock when removing a variant" do + pending "https://github.com/openfoodfoundation/openfoodnetwork/issues/7166" + + expect { + api_put :remove, params.merge(variant_id: existing_variant.to_param) + expect(response.status).to eq(422) + }.to_not change { existing_variant.reload.on_hand } + end + end end context "can transition a shipment from ready to ship" do