diff --git a/app/models/spree/order.rb b/app/models/spree/order.rb index 58e1c7304b..ce992107fb 100644 --- a/app/models/spree/order.rb +++ b/app/models/spree/order.rb @@ -765,13 +765,6 @@ module Spree address end - # Update attributes of a record in the database without callbacks, validations etc. - # This was originally an extension to ActiveRecord in Spree but only used for Spree::Order - def update_attributes_without_callbacks(attributes) - assign_attributes(attributes) - Spree::Order.where(id: id).update_all(attributes) - end - private def process_each_payment diff --git a/engines/order_management/app/services/order_management/order/updater.rb b/engines/order_management/app/services/order_management/order/updater.rb index e7cb051a4f..6ff7ef5ef6 100644 --- a/engines/order_management/app/services/order_management/order/updater.rb +++ b/engines/order_management/app/services/order_management/order/updater.rb @@ -32,7 +32,7 @@ module OrderManagement # update totals a second time in case updated adjustments have an effect on the total update_totals - order.update_attributes_without_callbacks( + order.update_columns( payment_state: order.payment_state, shipment_state: order.shipment_state, item_total: order.item_total, diff --git a/engines/order_management/spec/services/order_management/order/updater_spec.rb b/engines/order_management/spec/services/order_management/order/updater_spec.rb index 1bd901d37c..1af1aa2326 100644 --- a/engines/order_management/spec/services/order_management/order/updater_spec.rb +++ b/engines/order_management/spec/services/order_management/order/updater_spec.rb @@ -5,7 +5,7 @@ require 'spec_helper' module OrderManagement module Order describe Updater do - let(:order) { build(:order) } + let(:order) { create(:order) } let(:updater) { OrderManagement::Order::Updater.new(order) } before { allow(order).to receive(:backordered?) { false } } diff --git a/spec/models/spree/order/updating_spec.rb b/spec/models/spree/order/updating_spec.rb index 068fde6be9..d31421e53c 100644 --- a/spec/models/spree/order/updating_spec.rb +++ b/spec/models/spree/order/updating_spec.rb @@ -3,7 +3,7 @@ require 'spec_helper' describe Spree::Order do - let(:order) { build(:order) } + let(:order) { create(:order) } context "#update!" do let(:line_items) { [build(:line_item, amount: 5)] }