From f034e46aedde6589a40cbc23076e66c5deeae4da Mon Sep 17 00:00:00 2001 From: David Cook Date: Fri, 24 Nov 2023 14:21:26 +1100 Subject: [PATCH] Fix label Strangely, the spec passed when run locally, but not in CI. It's a curious case of the wrong letter case. --- app/views/admin/products_v3/_table.html.haml | 2 +- spec/system/admin/products_v3/products_spec.rb | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/views/admin/products_v3/_table.html.haml b/app/views/admin/products_v3/_table.html.haml index 5794133f23..8deccd2d84 100644 --- a/app/views/admin/products_v3/_table.html.haml +++ b/app/views/admin/products_v3/_table.html.haml @@ -95,7 +95,7 @@ .field.checkbox = variant_form.label :on_demand do = variant_form.check_box :on_demand, 'data-action': 'change->toggle-control#disableIfPresent change->popout#closeIfChecked' - = t('admin.products_page.columns.on_demand') + = t(:on_demand) %td.align-left .content= variant.product.supplier&.name # same as product %td.align-left diff --git a/spec/system/admin/products_v3/products_spec.rb b/spec/system/admin/products_v3/products_spec.rb index 218d63ac9d..b4294bdc4d 100644 --- a/spec/system/admin/products_v3/products_spec.rb +++ b/spec/system/admin/products_v3/products_spec.rb @@ -244,9 +244,9 @@ describe 'As an admin, I can see the new product page', feature: :admin_style_v3 it "switches stock to on-demand" do within row_containing_name("Medium box") do click_on "On Hand" # activate stock popout - check "On Demand" + check "On demand" - expect(page).to have_css "button[aria-label='On Hand']", text: "On Demand" + expect(page).to have_css "button[aria-label='On Hand']", text: "On demand" end expect { @@ -256,7 +256,7 @@ describe 'As an admin, I can see the new product page', feature: :admin_style_v3 }.to change{ variant_a1.on_demand }.to(true) within row_containing_name("Medium box") do - expect(page).to have_css "button[aria-label='On Hand']", text: "On Demand" + expect(page).to have_css "button[aria-label='On Hand']", text: "On demand" end pending