From ef9e43fbd3a8fe24fae6723408e8521a5f4bb529 Mon Sep 17 00:00:00 2001 From: Rob Harrington Date: Wed, 5 Apr 2017 11:56:19 +1000 Subject: [PATCH] Replacing mock_model objects with instance_doubles --- spec/controllers/base_controller_spec.rb | 5 ++--- spec/models/spree/calculator/flat_percent_item_total_spec.rb | 4 +++- spec/models/spree/calculator/flexi_rate_spec.rb | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/spec/controllers/base_controller_spec.rb b/spec/controllers/base_controller_spec.rb index 4ea2e31ff2..166fc091c0 100644 --- a/spec/controllers/base_controller_spec.rb +++ b/spec/controllers/base_controller_spec.rb @@ -1,9 +1,8 @@ require 'spec_helper' describe BaseController, :type => :controller do - let(:oc) { mock_model(OrderCycle) } - let(:hub) { mock_model(Enterprise, ready_for_checkout?: true) } - let(:order) { mock_model(Spree::Order, distributor: hub) } + let(:oc) { instance_double(OrderCycle, id: 1) } + let(:order) { instance_double(Spree::Order) } controller(BaseController) do def index render text: "" diff --git a/spec/models/spree/calculator/flat_percent_item_total_spec.rb b/spec/models/spree/calculator/flat_percent_item_total_spec.rb index 02b6e5d1ae..edef70b5bc 100644 --- a/spec/models/spree/calculator/flat_percent_item_total_spec.rb +++ b/spec/models/spree/calculator/flat_percent_item_total_spec.rb @@ -1,6 +1,8 @@ +require 'spec_helper' + describe Spree::Calculator::FlatPercentItemTotal do let(:calculator) { Spree::Calculator::FlatPercentItemTotal.new } - let(:line_item) { mock_model(Spree::LineItem, amount: 10) } + let(:line_item) { instance_double(Spree::LineItem, amount: 10) } before { calculator.stub :preferred_flat_percent => 10 } diff --git a/spec/models/spree/calculator/flexi_rate_spec.rb b/spec/models/spree/calculator/flexi_rate_spec.rb index a242429dca..276e09b4b6 100644 --- a/spec/models/spree/calculator/flexi_rate_spec.rb +++ b/spec/models/spree/calculator/flexi_rate_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' describe Spree::Calculator::FlexiRate do let(:calculator) { Spree::Calculator::FlexiRate.new } - let(:line_item) { mock_model(Spree::LineItem, amount: 10, quantity: 4) } + let(:line_item) { instance_double(Spree::LineItem, amount: 10, quantity: 4) } describe "computing for a single line item" do it "returns the first item rate" do