From ef00dca5a003b96d19ff262246a2be85dc12d7d3 Mon Sep 17 00:00:00 2001 From: Rob Harrington Date: Wed, 16 Nov 2016 15:49:47 +1100 Subject: [PATCH] Changing format of changes object in standing order placement job --- app/jobs/standing_order_placement_job.rb | 7 +++---- spec/jobs/standing_order_placement_job_spec.rb | 6 ++---- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/app/jobs/standing_order_placement_job.rb b/app/jobs/standing_order_placement_job.rb index 7b5eea1b15..c415c7831f 100644 --- a/app/jobs/standing_order_placement_job.rb +++ b/app/jobs/standing_order_placement_job.rb @@ -38,11 +38,10 @@ class StandingOrderPlacementJob def cap_quantity_and_store_changes(order) insufficient_stock_lines = order.insufficient_stock_lines - return [] unless insufficient_stock_lines.present? - insufficient_stock_lines.map do |line_item| - quantity_was = line_item.quantity + return {} unless insufficient_stock_lines.present? + insufficient_stock_lines.each_with_object({}) do |line_item, changes| + changes[line_item.id] = line_item.quantity line_item.cap_quantity_at_stock! - { line_item: line_item, quantity_was: quantity_was } end end diff --git a/spec/jobs/standing_order_placement_job_spec.rb b/spec/jobs/standing_order_placement_job_spec.rb index 87275cc79a..c6e6298541 100644 --- a/spec/jobs/standing_order_placement_job_spec.rb +++ b/spec/jobs/standing_order_placement_job_spec.rb @@ -49,10 +49,8 @@ describe StandingOrderPlacementJob do expect(line_item1.reload.quantity).to be 3 # not capped expect(line_item2.reload.quantity).to be 2 # capped expect(line_item3.reload.quantity).to be 0 # capped - expect(changes).to eq [ - { line_item: line_item2, quantity_was: 3}, - { line_item: line_item3, quantity_was: 3} - ] + expect(changes[line_item2.id]).to be 3 + expect(changes[line_item3.id]).to be 3 end end