From eedf31e44910daf566a87229040a4bf53baa5522 Mon Sep 17 00:00:00 2001 From: Luis Ramos Date: Tue, 16 Jun 2020 17:50:43 +0100 Subject: [PATCH] Make migration a bit easier to read --- ...calculators_outside_the_spree_namespace.rb | 38 +++++++++++-------- 1 file changed, 23 insertions(+), 15 deletions(-) diff --git a/db/migrate/20200616162646_move_all_calculators_outside_the_spree_namespace.rb b/db/migrate/20200616162646_move_all_calculators_outside_the_spree_namespace.rb index 78f132303a..b357242db2 100644 --- a/db/migrate/20200616162646_move_all_calculators_outside_the_spree_namespace.rb +++ b/db/migrate/20200616162646_move_all_calculators_outside_the_spree_namespace.rb @@ -2,28 +2,36 @@ class MoveAllCalculatorsOutsideTheSpreeNamespace < ActiveRecord::Migration def up - convert_calculator("Spree::Calculator::DefaultTax", "Calculator::DefaultTax") - convert_calculator("Spree::Calculator::FlatPercentItemTotal", - "Calculator::FlatPercentItemTotal") - convert_calculator("Spree::Calculator::FlatRate", "Calculator::FlatRate") - convert_calculator("Spree::Calculator::FlexiRate", "Calculator::FlexiRate") - convert_calculator("Spree::Calculator::PerItem", "Calculator::PerItem") - convert_calculator("Spree::Calculator::PriceSack", "Calculator::PriceSack") + convert_calculator("DefaultTax") + convert_calculator("FlatPercentItemTotal") + convert_calculator("FlatRate") + convert_calculator("FlexiRate") + convert_calculator("PerItem") + convert_calculator("PriceSack") end def down - convert_calculator("Calculator::DefaultTax", "Spree::Calculator::DefaultTax") - convert_calculator("Calculator::FlatPercentItemTotal", - "Spree::Calculator::FlatPercentItemTotal") - convert_calculator("Calculator::FlatRate", "Spree::Calculator::FlatRate") - convert_calculator("Calculator::FlexiRate", "Spree::Calculator::FlexiRate") - convert_calculator("Calculator::PerItem", "Spree::Calculator::PerItem") - convert_calculator("Calculator::PriceSack", "Spree::Calculator::PriceSack") + revert_calculator("DefaultTax") + revert_calculator("FlatPercentItemTotal") + revert_calculator("FlatRate") + revert_calculator("FlexiRate") + revert_calculator("PerItem") + revert_calculator("PriceSack") end private - def convert_calculator(from, to) + def convert_calculator(calculator_base_name) + update_calculator("Spree::Calculator::" + calculator_base_name, + "Calculator::" + calculator_base_name) + end + + def revert_calculator(calculator_base_name) + update_calculator("Calculator::" + calculator_base_name, + "Spree::Calculator::" + calculator_base_name) + end + + def update_calculator(from, to) Spree::Calculator.connection.execute( "UPDATE spree_calculators SET type = '" + to + "' WHERE type = '" + from + "'" )