raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-02-27 01:43:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace space by -, to match angular tag functionality

Browse Source
This commit is contained in:
Gaetan Craig-Riou
2025-09-24 12:59:26 +10:00
parent c2c2a9503c
commit ede7650fc9
3 changed files with 27 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
spec/javascripts/stimulus/tag_list_input_controller_test.js
View File

@@ -16,7 +16,7 @@ describe("TagListInputController", () => {
document.body.innerHTML = `
<div data-controller="tag-list-input">
<input
value="tag 1,tag 2,tag 3"
value="tag-1,tag-2,tag-3"
data-tag-list-input-target="tagList"
type="hidden"
name="variant_tag_list" id="variant_tag_list"
@@ -37,7 +37,7 @@ describe("TagListInputController", () => {
</template>
<li class="tag-item">
<div class="tag-template">
<span>tag 1</span>
<span>tag-1</span>
<a
class="remove-button"
data-action="click->tag-list-input#removeTag"
@@ -46,7 +46,7 @@ describe("TagListInputController", () => {
</li>
<li class="tag-item">
<div class="tag-template">
<span>tag 2</span>
<span>tag-2</span>
<a
class="remove-button"
data-action="click->tag-list-input#removeTag"
@@ -55,7 +55,7 @@ describe("TagListInputController", () => {
</li>
<li class="tag-item">
<div class="tag-template">
<span>tag 3</span>
<span>tag-3</span>
<a
class="remove-button"
data-action="click->tag-list-input#removeTag"
@@ -83,7 +83,7 @@ describe("TagListInputController", () => {
});
it("updates the hidden input tag list", () => {
expect(variant_tag_list.value).toBe("tag 1,tag 2,tag 3,new_tag");
expect(variant_tag_list.value).toBe("tag-1,tag-2,tag-3,new_tag");
});
it("adds the new tag to the HTML tag list", () => {
@@ -97,6 +97,22 @@ describe("TagListInputController", () => {
expect(variant_add_tag.value).toBe("");
});
describe("with a tag with spaces", () => {
it("replaces spaces by -", () => {
variant_add_tag.value = "tag other";
variant_add_tag.dispatchEvent(new KeyboardEvent("keydown", { key: "Enter" }));
const tagList = document.getElementsByClassName("tag-list")[0];
// 1 template + 3 tags + new tag (added in the beforeEach) + tag other
expect(tagList.childElementCount).toBe(6);
// Get the last span which is the last added tag
const spans = document.getElementsByTagName("span");
const span = spans.item(spans.length - 1);
expect(span.innerText).toBe("tag-other");
});
});
describe("with an empty new tag", () => {
it("doesn't add the tag", () => {
variant_add_tag.value = " ";
@@ -193,12 +209,12 @@ describe("TagListInputController", () => {
describe("removeTag", () => {
beforeEach(() => {
const removeButtons = document.getElementsByClassName("remove-button");
// Click on tag 2
// Click on tag-2
removeButtons[1].click();
});
it("updates the hidden input tag list", () => {
expect(variant_tag_list.value).toBe("tag 1,tag 3");
expect(variant_tag_list.value).toBe("tag-1,tag-3");
});
it("removes the tag from the HTML tag list", () => {
@@ -237,7 +253,7 @@ describe("TagListInputController", () => {
</template>
<li class="tag-item">
<div class="tag-template">
<span>tag 1</span>
<span>tag-1</span>
<a
class="remove-button"
data-action="click->tag-list-input#removeTag"