From edae56345b5f1090aa913c8b34c14bd60a8bbe46 Mon Sep 17 00:00:00 2001 From: filipefurtad0 Date: Mon, 5 Feb 2024 16:36:30 +0000 Subject: [PATCH] Removes unnecessary Stripe api key / secret declaration --- spec/controllers/spree/credit_cards_controller_spec.rb | 2 -- spec/lib/stripe/credit_card_cloner_spec.rb | 4 ---- spec/lib/stripe/payment_intent_validator_spec.rb | 5 ----- spec/models/spree/gateway/stripe_sca_spec.rb | 3 --- spec/models/stripe_account_spec.rb | 5 ----- spec/services/stripe_payment_status_spec.rb | 8 -------- 6 files changed, 27 deletions(-) diff --git a/spec/controllers/spree/credit_cards_controller_spec.rb b/spec/controllers/spree/credit_cards_controller_spec.rb index e41beb724d..e9ed1981b2 100644 --- a/spec/controllers/spree/credit_cards_controller_spec.rb +++ b/spec/controllers/spree/credit_cards_controller_spec.rb @@ -5,10 +5,8 @@ require 'spec_helper' describe Spree::CreditCardsController, type: :controller do describe "using VCR", :vcr, :stripe_version do let(:user) { create(:user) } - let(:secret) { ENV.fetch('STRIPE_SECRET_TEST_API_KEY', nil) } before do - Stripe.api_key = secret allow(controller).to receive(:spree_current_user) { user } end diff --git a/spec/lib/stripe/credit_card_cloner_spec.rb b/spec/lib/stripe/credit_card_cloner_spec.rb index e4edc192cb..69cb669e7f 100644 --- a/spec/lib/stripe/credit_card_cloner_spec.rb +++ b/spec/lib/stripe/credit_card_cloner_spec.rb @@ -8,11 +8,7 @@ module Stripe let!(:user) { create(:user, email: "apple.customer@example.com") } let!(:enterprise) { create(:enterprise) } - let(:secret) { ENV.fetch('STRIPE_SECRET_TEST_API_KEY', nil) } - describe "#find_or_clone", :vcr, :stripe_version do - before { Stripe.api_key = secret } - let(:customer) do Stripe::Customer.create({ name: 'Apple Customer', diff --git a/spec/lib/stripe/payment_intent_validator_spec.rb b/spec/lib/stripe/payment_intent_validator_spec.rb index d0bba0800c..70480ac2dd 100644 --- a/spec/lib/stripe/payment_intent_validator_spec.rb +++ b/spec/lib/stripe/payment_intent_validator_spec.rb @@ -4,7 +4,6 @@ require 'spec_helper' require 'stripe/payment_intent_validator' describe Stripe::PaymentIntentValidator do - let(:secret) { ENV.fetch('STRIPE_SECRET_TEST_API_KEY', nil) } let(:payment_method) { create(:stripe_sca_payment_method, distributor_ids: [create(:distributor_enterprise).id], @@ -13,10 +12,6 @@ describe Stripe::PaymentIntentValidator do let(:year_valid) { Time.zone.now.year.next } - before { - Stripe.api_key = secret - } - describe "#call", :vcr, :stripe_version do let(:payment) { create(:payment, amount: payment_intent.amount, payment_method:, diff --git a/spec/models/spree/gateway/stripe_sca_spec.rb b/spec/models/spree/gateway/stripe_sca_spec.rb index 645733134c..3c704b80fc 100644 --- a/spec/models/spree/gateway/stripe_sca_spec.rb +++ b/spec/models/spree/gateway/stripe_sca_spec.rb @@ -3,7 +3,6 @@ require 'spec_helper' describe Spree::Gateway::StripeSCA, type: :model do - let(:secret) { ENV.fetch('STRIPE_SECRET_TEST_API_KEY', nil) } let(:order) { create(:order_ready_for_payment) } @@ -26,8 +25,6 @@ describe Spree::Gateway::StripeSCA, type: :model do { order_id: order.number } } - before { Stripe.api_key = secret } - let(:pm_card) do Stripe::PaymentMethod.create({ type: 'card', diff --git a/spec/models/stripe_account_spec.rb b/spec/models/stripe_account_spec.rb index d890152bb7..770759c97a 100644 --- a/spec/models/stripe_account_spec.rb +++ b/spec/models/stripe_account_spec.rb @@ -10,16 +10,11 @@ describe StripeAccount do let(:client_id) { ENV.fetch('STRIPE_CLIENT_ID', nil) } let(:stripe_user_id) { ENV.fetch('STRIPE_ACCOUNT', nil) } let(:stripe_publishable_key) { ENV.fetch('STRIPE_PUBLIC_TEST_API_KEY', nil) } - let(:secret) { ENV.fetch('STRIPE_SECRET_TEST_API_KEY', nil) } let!(:stripe_account) { create(:stripe_account, enterprise:, stripe_user_id:) } - before do - Stripe.api_key = secret - end - context "when the Stripe API disconnect fails" do before { Stripe.client_id = "bogus_client_id" } diff --git a/spec/services/stripe_payment_status_spec.rb b/spec/services/stripe_payment_status_spec.rb index 5405f30925..3e9b17fa21 100644 --- a/spec/services/stripe_payment_status_spec.rb +++ b/spec/services/stripe_payment_status_spec.rb @@ -5,8 +5,6 @@ require 'spec_helper' describe StripePaymentStatus, :vcr, :stripe_version do subject { StripePaymentStatus.new(payment) } - let(:secret) { ENV.fetch('STRIPE_SECRET_TEST_API_KEY', nil) } - let(:credit_card) { create(:credit_card, gateway_payment_profile_id: pm_card.id) } let(:payment_method) { @@ -14,8 +12,6 @@ describe StripePaymentStatus, :vcr, :stripe_version do preferred_enterprise_id: create(:enterprise).id) } - before { Stripe.api_key = secret } - let(:pm_card) do Stripe::PaymentMethod.create({ type: 'card', @@ -46,10 +42,6 @@ describe StripePaymentStatus, :vcr, :stripe_version do ) } - before { - Stripe.api_key = secret - } - describe '#stripe_status' do context "when the payment is not a Stripe payment or does not have a payment intent" do before { payment.update!(response_code: nil) }