From ed207e3df64ff1d467d48d5b830a844c514f281d Mon Sep 17 00:00:00 2001
From: David Cook <david@redcliffs.net>
Date: Thu, 21 Sep 2023 09:37:46 +1000
Subject: [PATCH] DRY up code

---
 app/webpacker/controllers/bulk_form_controller.js | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/app/webpacker/controllers/bulk_form_controller.js b/app/webpacker/controllers/bulk_form_controller.js
index 9b959d1d93..526aa1d5b5 100644
--- a/app/webpacker/controllers/bulk_form_controller.js
+++ b/app/webpacker/controllers/bulk_form_controller.js
@@ -35,8 +35,7 @@ export default class BulkFormController extends Controller {
 
   toggleModified(e) {
     const element = e.target;
-    const modified = element.value != element.defaultValue;
-    element.classList.toggle("modified", modified);
+    element.classList.toggle("modified", this.#isModified(element));
 
     this.toggleFormModified();
   }
@@ -44,7 +43,7 @@ export default class BulkFormController extends Controller {
   toggleFormModified() {
     // For each record, check if any fields are modified
     const modifiedRecordCount = Object.values(this.recordElements).filter((elements) =>
-      elements.some((element) => element.value != element.defaultValue)
+      elements.some(this.#isModified)
     ).length;
     const formModified = modifiedRecordCount > 0;
 
@@ -85,4 +84,8 @@ export default class BulkFormController extends Controller {
       });
     }
   }
+
+  #isModified(element) {
+    return element.value != element.defaultValue;
+  }
 }