From ecb303fef576bcb737eccb6af2241bb8e2e725a3 Mon Sep 17 00:00:00 2001 From: Carlos Chitty Date: Wed, 26 Mar 2025 11:10:58 -0400 Subject: [PATCH] Correct Style/SlicingWithRange rubocop offenses --- .rubocop_todo.yml | 8 -------- app/helpers/spree/admin/navigation_helper.rb | 2 +- app/services/embedded_page_service.rb | 2 +- .../services/order_management/subscriptions/validator.rb | 2 +- 4 files changed, 3 insertions(+), 11 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index ef6215f14a..5ded3b62a4 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -677,11 +677,3 @@ Style/ReturnNilInPredicateMethodDefinition: - 'app/models/order_cycle.rb' - 'app/serializers/api/admin/customer_serializer.rb' - 'engines/order_management/app/services/order_management/subscriptions/validator.rb' - -# Offense count: 3 -# This cop supports unsafe autocorrection (--autocorrect-all). -Style/SlicingWithRange: - Exclude: - - 'app/helpers/spree/admin/navigation_helper.rb' - - 'app/services/embedded_page_service.rb' - - 'engines/order_management/app/services/order_management/subscriptions/validator.rb' diff --git a/app/helpers/spree/admin/navigation_helper.rb b/app/helpers/spree/admin/navigation_helper.rb index d39ac5b3cc..7b408e5ef5 100644 --- a/app/helpers/spree/admin/navigation_helper.rb +++ b/app/helpers/spree/admin/navigation_helper.rb @@ -122,7 +122,7 @@ module Spree end else if html_options['data-update'].nil? && html_options[:remote] - object_name, action = url.split('/')[-2..-1] + object_name, action = url.split('/')[-2..] html_options['data-update'] = [action, object_name.singularize].join('_') end diff --git a/app/services/embedded_page_service.rb b/app/services/embedded_page_service.rb index 52fc4b98c4..6e979c9722 100644 --- a/app/services/embedded_page_service.rb +++ b/app/services/embedded_page_service.rb @@ -81,7 +81,7 @@ class EmbeddedPageService def current_referer_without_www return unless current_referer - current_referer.start_with?('www.') ? current_referer[4..-1] : current_referer + current_referer.start_with?('www.') ? current_referer[4..] : current_referer end def set_embedded_layout diff --git a/engines/order_management/app/services/order_management/subscriptions/validator.rb b/engines/order_management/app/services/order_management/subscriptions/validator.rb index 4808d7353c..1dc04bfd5d 100644 --- a/engines/order_management/app/services/order_management/subscriptions/validator.rb +++ b/engines/order_management/app/services/order_management/subscriptions/validator.rb @@ -128,7 +128,7 @@ module OrderManagement end def build_msg_from(key, msg) - return msg[1..-1] if msg.starts_with?("^") + return msg[1..] if msg.starts_with?("^") errors.full_message(key, msg) end