From ec953e1db0a8f704bd5fbde5d50a06b4dd967a91 Mon Sep 17 00:00:00 2001
From: Maikel Linke <maikel@email.org.au>
Date: Thu, 13 Sep 2018 17:22:01 +1000
Subject: [PATCH] Style cache refreshment class

---
 .rubocop_todo.yml                             |  6 -----
 .../products_cache_refreshment.rb             | 26 ++++++++++---------
 2 files changed, 14 insertions(+), 18 deletions(-)

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index eaff617a86..7798d41309 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -185,7 +185,6 @@ Layout/EmptyLines:
     - 'lib/open_food_network/order_cycle_permissions.rb'
     - 'lib/open_food_network/products_cache.rb'
     - 'lib/open_food_network/products_cache_integrity_checker.rb'
-    - 'lib/open_food_network/products_cache_refreshment.rb'
     - 'lib/open_food_network/products_renderer.rb'
     - 'lib/open_food_network/property_merge.rb'
     - 'lib/open_food_network/reports/bulk_coop_report.rb'
@@ -560,7 +559,6 @@ Layout/MultilineOperationIndentation:
     - 'app/models/variant_override_set.rb'
     - 'lib/open_food_network/accounts_and_billing_settings_validator.rb'
     - 'lib/open_food_network/order_cycle_permissions.rb'
-    - 'lib/open_food_network/products_cache_refreshment.rb'
     - 'lib/open_food_network/sales_tax_report.rb'
     - 'lib/open_food_network/users_and_enterprises_report.rb'
 
@@ -986,7 +984,6 @@ Lint/IneffectiveAccessModifier:
     - 'app/models/variant_override.rb'
     - 'lib/open_food_network/feature_toggle.rb'
     - 'lib/open_food_network/products_cache.rb'
-    - 'lib/open_food_network/products_cache_refreshment.rb'
     - 'lib/open_food_network/property_merge.rb'
     - 'spec/lib/open_food_network/reports/report_spec.rb'
 
@@ -1096,7 +1093,6 @@ Lint/UselessAccessModifier:
     - 'app/models/column_preference.rb'
     - 'lib/open_food_network/feature_toggle.rb'
     - 'lib/open_food_network/products_cache.rb'
-    - 'lib/open_food_network/products_cache_refreshment.rb'
     - 'lib/open_food_network/property_merge.rb'
     - 'lib/open_food_network/reports/bulk_coop_report.rb'
     - 'spec/lib/open_food_network/reports/report_spec.rb'
@@ -1505,7 +1501,6 @@ Rails/TimeZone:
     - 'lib/open_food_network/users_and_enterprises_report.rb'
     - 'spec/controllers/api/statuses_controller_spec.rb'
     - 'spec/jobs/heartbeat_job_spec.rb'
-    - 'spec/lib/open_food_network/products_cache_refreshment_spec.rb'
     - 'spec/lib/open_food_network/products_cache_spec.rb'
     - 'spec/models/enterprise_relationship_spec.rb'
     - 'spec/models/variant_override_spec.rb'
@@ -1861,7 +1856,6 @@ Style/GuardClause:
     - 'lib/open_food_network/accounts_and_billing_settings_validator.rb'
     - 'lib/open_food_network/order_cycle_form_applicator.rb'
     - 'lib/open_food_network/products_cache.rb'
-    - 'lib/open_food_network/products_cache_refreshment.rb'
     - 'lib/open_food_network/products_renderer.rb'
     - 'lib/open_food_network/rack_request_blocker.rb'
     - 'lib/open_food_network/variant_and_line_item_naming.rb'
diff --git a/lib/open_food_network/products_cache_refreshment.rb b/lib/open_food_network/products_cache_refreshment.rb
index 17efd2acd5..e9ebc67029 100644
--- a/lib/open_food_network/products_cache_refreshment.rb
+++ b/lib/open_food_network/products_cache_refreshment.rb
@@ -21,21 +21,23 @@ module OpenFoodNetwork
       enqueue_job(job) unless pending_job?(job)
     end
 
-    private
+    class << self
+      private
 
-    def self.refresh_job(distributor, order_cycle)
-      RefreshProductsCacheJob.new(distributor.id, order_cycle.id)
-    end
+      def refresh_job(distributor, order_cycle)
+        RefreshProductsCacheJob.new(distributor.id, order_cycle.id)
+      end
 
-    def self.pending_job?(job)
-      Delayed::Job.
-        where(locked_at: nil).
-        where(handler: job.to_yaml).
-        exists?
-    end
+      def pending_job?(job)
+        Delayed::Job.
+          where(locked_at: nil).
+          where(handler: job.to_yaml).
+          exists?
+      end
 
-    def self.enqueue_job(job)
-      Delayed::Job.enqueue job, priority: 10
+      def enqueue_job(job)
+        Delayed::Job.enqueue job, priority: 10
+      end
     end
   end
 end