diff --git a/app/controllers/api/order_cycles_controller.rb b/app/controllers/api/order_cycles_controller.rb index d4ce2cdc7b..b06f302169 100644 --- a/app/controllers/api/order_cycles_controller.rb +++ b/app/controllers/api/order_cycles_controller.rb @@ -6,6 +6,8 @@ module Api skip_authorization_check def products + render_no_products unless order_cycle.open? + products = ProductsRenderer.new( distributor, order_cycle, @@ -15,7 +17,7 @@ module Api render json: products rescue ProductsRenderer::NoProducts - render status: :not_found, json: '' + render_no_products end def taxons @@ -35,6 +37,10 @@ module Api private + def render_no_products + render status: :not_found, json: '' + end + def product_properties Spree::Property. joins(:products).