From b0ac1884302813bb7aba015747d5037e1e2d3ab5 Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Fri, 10 Jul 2020 15:33:20 +1000 Subject: [PATCH] Make broken spec fail reliably and set it pending This spec has been broken for a long time, at least eight months. But it regularly passed because the search filter is applied with a delay and in that time the content matches. And once the filter is applied, no products are shown and the negative matchers pass. --- spec/features/consumer/shopping/shopping_spec.rb | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/spec/features/consumer/shopping/shopping_spec.rb b/spec/features/consumer/shopping/shopping_spec.rb index cf825ca475..b28dcbefec 100644 --- a/spec/features/consumer/shopping/shopping_spec.rb +++ b/spec/features/consumer/shopping/shopping_spec.rb @@ -194,14 +194,16 @@ feature "As a consumer I want to shop with a distributor", js: true do end it "returns search results for products where the search term matches one of the product's variant names" do + pending "has been broken for a while" + visit shop_path fill_in "search", with: "Badg" # For variant with display_name "Badgers" within('div.pad-top') do - expect(page).to have_content product.name - expect(page).to have_content variant2.display_name expect(page).not_to have_content product2.name expect(page).not_to have_content variant3.display_name + expect(page).to have_content product.name + expect(page).to have_content variant2.display_name end end