From e7dbb56b2eb1e89f49b00a3e1fcf6bf612f1906b Mon Sep 17 00:00:00 2001 From: Ana Nunes da Silva Date: Mon, 8 Apr 2024 16:17:14 +0100 Subject: [PATCH] remove duplicate instance methods sso_secret and sso_url --- .rubocop_todo.yml | 5 ----- lib/discourse/single_sign_on.rb | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 5709efec0e..13f9fea84d 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -23,11 +23,6 @@ Lint/ConstantDefinitionInBlock: - 'spec/validators/date_time_string_validator_spec.rb' - 'spec/validators/integer_array_validator_spec.rb' -# Offense count: 2 -Lint/DuplicateMethods: - Exclude: - - 'lib/discourse/single_sign_on.rb' - # Offense count: 16 # Configuration parameters: AllowComments, AllowEmptyLambdas. Lint/EmptyBlock: diff --git a/lib/discourse/single_sign_on.rb b/lib/discourse/single_sign_on.rb index 5e2db79461..e7e7af8da9 100644 --- a/lib/discourse/single_sign_on.rb +++ b/lib/discourse/single_sign_on.rb @@ -12,7 +12,7 @@ module Discourse :suppress_welcome_message].freeze NONCE_EXPIRY_TIME = 10.minutes - attr_accessor(*ACCESSORS, :sso_secret, :sso_url) + attr_accessor(*ACCESSORS) def self.sso_secret raise "sso_secret not implemented on class, be sure to set it on instance"