From e5cd8e5216417ccc5828d1e3d5693b1bc9ea460a Mon Sep 17 00:00:00 2001 From: Gaetan Craig-Riou Date: Mon, 19 Feb 2024 13:51:40 +1100 Subject: [PATCH] Log error when something goes wrong Plus spec. The old implementation would swallow the error, all we had was a flash message feedback --- app/controllers/spree/admin/payments_controller.rb | 1 + spec/requests/spree/admin/payments_spec.rb | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/app/controllers/spree/admin/payments_controller.rb b/app/controllers/spree/admin/payments_controller.rb index 40dcd40adc..4bf6ebcdcc 100644 --- a/app/controllers/spree/admin/payments_controller.rb +++ b/app/controllers/spree/admin/payments_controller.rb @@ -59,6 +59,7 @@ module Spree flash[:error] = t(:cannot_perform_operation) end rescue StandardError => e + logger.error e.message flash[:error] = e.message ensure redirect_to request.referer diff --git a/spec/requests/spree/admin/payments_spec.rb b/spec/requests/spree/admin/payments_spec.rb index 1c63e1dba3..14829a5cde 100644 --- a/spec/requests/spree/admin/payments_spec.rb +++ b/spec/requests/spree/admin/payments_spec.rb @@ -107,7 +107,7 @@ describe Spree::Admin::PaymentsController, type: :request do allow(payment).to receive(:void_transaction!).and_raise(StandardError, "Unexpected !") end - pending "log the error message" do + it "log the error message" do # The redirect_do also calls Rails.logger.error expect(Rails.logger).to receive(:error).with("Unexpected !").ordered expect(Rails.logger).to receive(:error).with(/Redirected/).ordered