From e5afa3a26ece50d6f43d31b5a5c8995694a8f916 Mon Sep 17 00:00:00 2001 From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com> Date: Tue, 29 Jun 2021 12:00:26 +0100 Subject: [PATCH] Simplify #pagy calls without default item counts Pagy will pick up the :per_page param by default now, so we don't need to specify `items: params[:per_page]` unless we want to use something beyond that param's value. --- app/controllers/admin/bulk_line_items_controller.rb | 2 +- app/controllers/api/v0/states_controller.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/controllers/admin/bulk_line_items_controller.rb b/app/controllers/admin/bulk_line_items_controller.rb index 297945ee65..67156648bb 100644 --- a/app/controllers/admin/bulk_line_items_controller.rb +++ b/app/controllers/admin/bulk_line_items_controller.rb @@ -16,7 +16,7 @@ module Admin reorder('spree_line_items.order_id ASC, spree_line_items.id ASC') pagy = nil - pagy, @line_items = pagy(@line_items, items: params[:per_page]) if pagination_required? + pagy, @line_items = pagy(@line_items) if pagination_required? render json: { line_items: serialized_line_items, diff --git a/app/controllers/api/v0/states_controller.rb b/app/controllers/api/v0/states_controller.rb index fa4ee7dc11..911146c23a 100644 --- a/app/controllers/api/v0/states_controller.rb +++ b/app/controllers/api/v0/states_controller.rb @@ -32,7 +32,7 @@ module Api includes(:country).order('name ASC') if pagination? - _pagy, states = pagy(states, items: params[:per_page]) + _pagy, states = pagy(states) end states