From dfda30f4cbb9fae2274bc825ee9b14d192f589da Mon Sep 17 00:00:00 2001 From: Rob Harrington Date: Sat, 24 Jun 2017 13:33:57 +1000 Subject: [PATCH] Rubocop: Regenerate rubocop_todo.yml using --exclude-limit 100 --- .rubocop_todo.yml | 924 ++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 884 insertions(+), 40 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 7182721abb..e1cd53f9ff 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by -# `rubocop --auto-gen-config` -# on 2017-05-21 09:22:19 +1000 using RuboCop version 0.48.1. +# `rubocop --auto-gen-config --exclude-limit 100` +# on 2017-06-24 13:07:01 +1000 using RuboCop version 0.48.1. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -111,7 +111,36 @@ Lint/UnderscorePrefixedVariableName: # Cop supports --auto-correct. # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments. Lint/UnusedBlockArgument: - Enabled: false + Exclude: + - 'app/controllers/admin/column_preferences_controller.rb' + - 'app/controllers/admin/enterprises_controller.rb' + - 'app/controllers/admin/order_cycles_controller.rb' + - 'app/controllers/spree/orders_controller_decorator.rb' + - 'app/models/column_preference.rb' + - 'app/models/model_set.rb' + - 'app/models/product_importer.rb' + - 'app/models/spree/order_decorator.rb' + - 'app/models/spree/order_populator_decorator.rb' + - 'lib/open_food_network/bulk_coop_report.rb' + - 'lib/open_food_network/enterprise_fee_calculator.rb' + - 'lib/open_food_network/group_buy_report.rb' + - 'lib/open_food_network/option_value_namer.rb' + - 'lib/open_food_network/order_cycle_form_applicator.rb' + - 'lib/open_food_network/order_grouper.rb' + - 'lib/open_food_network/orders_and_fulfillments_report.rb' + - 'lib/open_food_network/packing_report.rb' + - 'lib/open_food_network/reports/bulk_coop_allocation_report.rb' + - 'lib/open_food_network/reports/bulk_coop_supplier_report.rb' + - 'lib/open_food_network/sales_tax_report.rb' + - 'lib/open_food_network/xero_invoices_report.rb' + - 'spec/factories.rb' + - 'spec/lib/open_food_network/order_grouper_spec.rb' + - 'spec/support/cancan_helper.rb' + - 'spec/support/delayed_job_helper.rb' + - 'spec/support/matchers/delegate_matchers.rb' + - 'spec/support/matchers/select2_matchers.rb' + - 'spec/support/matchers/table_matchers.rb' + - 'spec/support/performance_helper.rb' # Offense count: 16 # Cop supports --auto-correct. @@ -147,8 +176,8 @@ Lint/UselessAccessModifier: # Offense count: 340 Lint/Void: Exclude: - - app/serializers/api/enterprise_serializer.rb - - spec/**/* + - app/serializers/api/enterprise_serializer.rb + - spec/**/* # Offense count: 706 # Configuration parameters: CountComments, ExcludedMethods. @@ -396,14 +425,54 @@ Style/AlignArray: # SupportedColonStyles: key, separator, table # SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit Style/AlignHash: - Enabled: false + Exclude: + - 'app/overrides/add_capture_order_shortcut.rb' + - 'app/overrides/replace_shipping_address_form_with_distributor_details.rb' + - 'lib/open_food_network/bulk_coop_report.rb' + - 'lib/open_food_network/orders_and_fulfillments_report.rb' + - 'lib/open_food_network/packing_report.rb' + - 'lib/open_food_network/payments_report.rb' + - 'spec/archive/features/consumer/checkout_spec.rb' + - 'spec/factories.rb' + - 'spec/features/admin/bulk_product_update_spec.rb' + - 'spec/features/admin/order_cycles_spec.rb' + - 'spec/features/admin/products_spec.rb' + - 'spec/features/admin/variant_overrides_spec.rb' + - 'spec/lib/open_food_network/customers_report_spec.rb' + - 'spec/lib/open_food_network/enterprise_fee_calculator_spec.rb' + - 'spec/lib/open_food_network/permissions_spec.rb' + - 'spec/lib/open_food_network/products_and_inventory_report_spec.rb' + - 'spec/lib/open_food_network/user_balance_calculator_spec.rb' + - 'spec/models/enterprise_relationship_spec.rb' + - 'spec/models/exchange_spec.rb' + - 'spec/models/order_cycle_spec.rb' + - 'spec/models/spree/shipping_method_spec.rb' + - 'spec/models/spree/variant_spec.rb' # Offense count: 42 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth. # SupportedStyles: with_first_parameter, with_fixed_indentation Style/AlignParameters: - Enabled: false + Exclude: + - 'app/controllers/spree/orders_controller_decorator.rb' + - 'app/helpers/injection_helper.rb' + - 'app/models/enterprise.rb' + - 'app/models/enterprise_group.rb' + - 'app/models/enterprise_relationship.rb' + - 'app/models/spree/variant_decorator.rb' + - 'app/serializers/api/address_serializer.rb' + - 'app/serializers/api/enterprise_serializer.rb' + - 'app/serializers/api/shipping_method_serializer.rb' + - 'lib/spree/product_filters.rb' + - 'lib/tasks/dev.rake' + - 'spec/controllers/enterprises_controller_spec.rb' + - 'spec/controllers/shop_controller_spec.rb' + - 'spec/features/admin/enterprise_relationships_spec.rb' + - 'spec/features/consumer/shopping/checkout_spec.rb' + - 'spec/helpers/enterprises_helper_spec.rb' + - 'spec/lib/open_food_network/user_balance_calculator_spec.rb' + - 'spec/support/request/authentication_workflow.rb' # Offense count: 35 # Cop supports --auto-correct. @@ -460,7 +529,76 @@ Style/BlockEndNewline: # Configuration parameters: EnforcedStyle, SupportedStyles. # SupportedStyles: braces, no_braces, context_dependent Style/BracesAroundHashParameters: - Enabled: false + Exclude: + - 'app/controllers/admin/enterprises_controller.rb' + - 'app/controllers/api/enterprises_controller.rb' + - 'app/controllers/checkout_controller.rb' + - 'app/controllers/spree/admin/products_controller_decorator.rb' + - 'app/controllers/spree/admin/search_controller_decorator.rb' + - 'app/controllers/spree/orders_controller_decorator.rb' + - 'app/helpers/admin/account_helper.rb' + - 'app/helpers/admin/business_model_configuration_helper.rb' + - 'app/helpers/angular_form_builder.rb' + - 'app/helpers/checkout_helper.rb' + - 'app/helpers/spree/admin/orders_helper_decorator.rb' + - 'app/jobs/finalize_account_invoices.rb' + - 'app/jobs/update_account_invoices.rb' + - 'app/jobs/update_billable_periods.rb' + - 'app/models/billable_period.rb' + - 'app/models/cart.rb' + - 'app/models/exchange.rb' + - 'app/models/spree/adjustment_decorator.rb' + - 'app/models/spree/line_item_decorator.rb' + - 'app/models/spree/order_decorator.rb' + - 'app/serializers/api/admin/order_cycle_serializer.rb' + - 'lib/open_food_network/order_cycle_form_applicator.rb' + - 'lib/open_food_network/reports/rule.rb' + - 'lib/open_food_network/variant_and_line_item_naming.rb' + - 'lib/open_food_network/xero_invoices_report.rb' + - 'spec/controllers/admin/accounts_and_billing_settings_controller_spec.rb' + - 'spec/controllers/admin/business_model_configuration_controller_spec.rb' + - 'spec/controllers/admin/enterprises_controller_spec.rb' + - 'spec/controllers/admin/order_cycles_controller_spec.rb' + - 'spec/controllers/api/order_cycles_controller_spec.rb' + - 'spec/controllers/cart_controller_spec.rb' + - 'spec/controllers/enterprise_confirmations_controller_spec.rb' + - 'spec/controllers/enterprises_controller_spec.rb' + - 'spec/controllers/line_items_controller_spec.rb' + - 'spec/controllers/spree/admin/adjustments_controller_spec.rb' + - 'spec/controllers/spree/admin/base_controller_spec.rb' + - 'spec/controllers/spree/admin/orders_controller_spec.rb' + - 'spec/controllers/spree/admin/payment_methods_controller_spec.rb' + - 'spec/controllers/spree/admin/products_controller_spec.rb' + - 'spec/controllers/spree/admin/reports_controller_spec.rb' + - 'spec/controllers/spree/api/products_controller_spec.rb' + - 'spec/controllers/spree/api/variants_controller_spec.rb' + - 'spec/controllers/spree/orders_controller_spec.rb' + - 'spec/factories.rb' + - 'spec/features/admin/accounts_and_billing_settings_spec.rb' + - 'spec/features/admin/business_model_configuration_spec.rb' + - 'spec/features/admin/order_cycles_spec.rb' + - 'spec/features/admin/products_spec.rb' + - 'spec/features/admin/reports_spec.rb' + - 'spec/features/admin/tax_settings_spec.rb' + - 'spec/helpers/order_cycles_helper_spec.rb' + - 'spec/jobs/finalize_account_invoices_spec.rb' + - 'spec/jobs/update_account_invoices_spec.rb' + - 'spec/lib/open_food_network/feature_toggle_spec.rb' + - 'spec/lib/open_food_network/order_cycle_form_applicator_spec.rb' + - 'spec/lib/open_food_network/xero_invoices_report_spec.rb' + - 'spec/models/billable_period_spec.rb' + - 'spec/models/product_distribution_spec.rb' + - 'spec/models/spree/ability_spec.rb' + - 'spec/models/spree/order_populator_spec.rb' + - 'spec/models/spree/order_spec.rb' + - 'spec/models/spree/product_spec.rb' + - 'spec/models/spree/taxon_spec.rb' + - 'spec/serializers/admin/customer_serializer_spec.rb' + - 'spec/serializers/orders_by_distributor_serializer_spec.rb' + - 'spec/spec_helper.rb' + - 'spec/support/cancan_helper.rb' + - 'spec/support/request/authentication_workflow.rb' + - 'spec/support/request/shop_workflow.rb' # Offense count: 2 Style/CaseEquality: @@ -481,7 +619,86 @@ Style/CaseIndentation: # Configuration parameters: EnforcedStyle, SupportedStyles. # SupportedStyles: nested, compact Style/ClassAndModuleChildren: - Enabled: false + Exclude: + - 'app/controllers/admin/account_controller.rb' + - 'app/controllers/admin/accounts_and_billing_settings_controller.rb' + - 'app/controllers/admin/business_model_configuration_controller.rb' + - 'app/controllers/admin/cache_settings_controller.rb' + - 'app/controllers/admin/invoice_settings_controller.rb' + - 'app/controllers/admin/product_import_controller.rb' + - 'app/controllers/spree/store_controller_decorator.rb' + - 'app/helpers/angular_form_helper.rb' + - 'app/models/calculator/flat_percent_per_item.rb' + - 'app/models/open_food_network/calculator/weight.rb' + - 'app/models/spree/gateway/migs.rb' + - 'app/models/spree/gateway/pin.rb' + - 'app/models/spree/preferences/file_configuration.rb' + - 'app/models/spree/product_set.rb' + - 'app/models/tag_rule/discount_order.rb' + - 'app/models/tag_rule/filter_order_cycles.rb' + - 'app/models/tag_rule/filter_payment_methods.rb' + - 'app/models/tag_rule/filter_shipping_methods.rb' + - 'app/serializers/api/address_serializer.rb' + - 'app/serializers/api/admin/basic_enterprise_fee_serializer.rb' + - 'app/serializers/api/admin/basic_enterprise_serializer.rb' + - 'app/serializers/api/admin/basic_order_cycle_serializer.rb' + - 'app/serializers/api/admin/calculator/flat_percent_item_total_serializer.rb' + - 'app/serializers/api/admin/calculator_serializer.rb' + - 'app/serializers/api/admin/column_preference_serializer.rb' + - 'app/serializers/api/admin/customer_serializer.rb' + - 'app/serializers/api/admin/enterprise_fee_serializer.rb' + - 'app/serializers/api/admin/enterprise_relationship_permission_serializer.rb' + - 'app/serializers/api/admin/enterprise_relationship_serializer.rb' + - 'app/serializers/api/admin/enterprise_role_serializer.rb' + - 'app/serializers/api/admin/enterprise_serializer.rb' + - 'app/serializers/api/admin/exchange_serializer.rb' + - 'app/serializers/api/admin/for_order_cycle/enterprise_serializer.rb' + - 'app/serializers/api/admin/for_order_cycle/supplied_product_serializer.rb' + - 'app/serializers/api/admin/id_name_serializer.rb' + - 'app/serializers/api/admin/id_serializer.rb' + - 'app/serializers/api/admin/index_enterprise_serializer.rb' + - 'app/serializers/api/admin/inventory_item_serializer.rb' + - 'app/serializers/api/admin/line_item_serializer.rb' + - 'app/serializers/api/admin/order_cycle_serializer.rb' + - 'app/serializers/api/admin/order_serializer.rb' + - 'app/serializers/api/admin/payment_method_serializer.rb' + - 'app/serializers/api/admin/product_serializer.rb' + - 'app/serializers/api/admin/shipping_method_serializer.rb' + - 'app/serializers/api/admin/tag_rule_serializer.rb' + - 'app/serializers/api/admin/tax_category_serializer.rb' + - 'app/serializers/api/admin/taxon_serializer.rb' + - 'app/serializers/api/admin/units_product_serializer.rb' + - 'app/serializers/api/admin/units_variant_serializer.rb' + - 'app/serializers/api/admin/user_serializer.rb' + - 'app/serializers/api/admin/variant_override_serializer.rb' + - 'app/serializers/api/admin/variant_serializer.rb' + - 'app/serializers/api/country_serializer.rb' + - 'app/serializers/api/currency_config_serializer.rb' + - 'app/serializers/api/current_order_serializer.rb' + - 'app/serializers/api/enterprise_serializer.rb' + - 'app/serializers/api/id_name_serializer.rb' + - 'app/serializers/api/id_serializer.rb' + - 'app/serializers/api/image_serializer.rb' + - 'app/serializers/api/line_item_serializer.rb' + - 'app/serializers/api/payment_method_serializer.rb' + - 'app/serializers/api/product_serializer.rb' + - 'app/serializers/api/property_serializer.rb' + - 'app/serializers/api/shipping_method_serializer.rb' + - 'app/serializers/api/state_serializer.rb' + - 'app/serializers/api/taxon_image_serializer.rb' + - 'app/serializers/api/taxon_serializer.rb' + - 'app/serializers/api/variant_serializer.rb' + - 'lib/open_food_network/locking.rb' + - 'lib/open_food_network/reports/bulk_coop_allocation_report.rb' + - 'lib/open_food_network/reports/bulk_coop_report.rb' + - 'lib/open_food_network/reports/bulk_coop_supplier_report.rb' + - 'lib/open_food_network/reports/report.rb' + - 'lib/open_food_network/reports/row.rb' + - 'lib/open_food_network/reports/rule.rb' + - 'spec/controllers/spree/admin/base_controller_spec.rb' + - 'spec/lib/open_food_network/reports/report_spec.rb' + - 'spec/lib/open_food_network/reports/row_spec.rb' + - 'spec/lib/open_food_network/reports/rule_spec.rb' # Offense count: 3 # Cop supports --auto-correct. @@ -566,7 +783,7 @@ Style/EmptyElse: - 'app/models/spreadsheet_entry.rb' - 'app/serializers/api/admin/basic_order_cycle_serializer.rb' -# Offense count: 222 +# Offense count: 223 # Cop supports --auto-correct. Style/EmptyLines: Enabled: false @@ -581,19 +798,102 @@ Style/EmptyLinesAroundAccessModifier: - 'spec/helpers/products_helper_spec.rb' - 'spec/support/request/web_helper.rb' -# Offense count: 72 +# Offense count: 73 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. # SupportedStyles: empty_lines, no_empty_lines Style/EmptyLinesAroundBlockBody: - Enabled: false + Exclude: + - 'app/controllers/spree/admin/orders_controller_decorator.rb' + - 'app/controllers/spree/admin/payments_controller_decorator.rb' + - 'app/controllers/spree/admin/reports_controller_decorator.rb' + - 'app/controllers/spree/admin/variants_controller_decorator.rb' + - 'app/controllers/spree/api/orders_controller_decorator.rb' + - 'app/controllers/spree/api/products_controller_decorator.rb' + - 'app/controllers/spree/checkout_controller_decorator.rb' + - 'app/models/spree/adjustment_decorator.rb' + - 'app/models/spree/calculator/default_tax_decorator.rb' + - 'app/models/spree/calculator_decorator.rb' + - 'app/models/spree/money_decorator.rb' + - 'app/models/spree/option_value_decorator.rb' + - 'app/models/spree/payment_decorator.rb' + - 'lib/open_food_network/group_buy_report.rb' + - 'lib/spree/money_decorator.rb' + - 'lib/tasks/dev.rake' + - 'lib/tasks/users.rake' + - 'spec/controllers/admin/tag_rules_controller_spec.rb' + - 'spec/controllers/cart_controller_spec.rb' + - 'spec/controllers/enterprise_confirmations_controller_spec.rb' + - 'spec/controllers/spree/admin/line_items_controller_spec.rb' + - 'spec/controllers/spree/admin/orders_controller_spec.rb' + - 'spec/controllers/spree/admin/reports_controller_spec.rb' + - 'spec/controllers/spree/api/orders_controller_spec.rb' + - 'spec/controllers/spree/orders_controller_spec.rb' + - 'spec/controllers/user_registrations_controller_spec.rb' + - 'spec/features/admin/caching_spec.rb' + - 'spec/features/admin/orders_spec.rb' + - 'spec/features/admin/reports_spec.rb' + - 'spec/features/admin/variant_overrides_spec.rb' + - 'spec/features/consumer/shopping/shopping_spec.rb' + - 'spec/features/consumer/shopping/variant_overrides_spec.rb' + - 'spec/helpers/admin/business_model_configuration_helper_spec.rb' + - 'spec/helpers/injection_helper_spec.rb' + - 'spec/helpers/shared_helper_spec.rb' + - 'spec/helpers/shop_helper_spec.rb' + - 'spec/helpers/spree/orders_helper_spec.rb' + - 'spec/jobs/update_billable_periods_spec.rb' + - 'spec/lib/open_food_network/group_buy_report_spec.rb' + - 'spec/lib/open_food_network/lettuce_share_report_spec.rb' + - 'spec/lib/open_food_network/order_and_distributor_report_spec.rb' + - 'spec/lib/open_food_network/order_grouper_spec.rb' + - 'spec/lib/open_food_network/referer_parser_spec.rb' + - 'spec/lib/open_food_network/user_balance_calculator_spec.rb' + - 'spec/models/billable_period_spec.rb' + - 'spec/models/cart_spec.rb' + - 'spec/models/product_distribution_spec.rb' + - 'spec/models/spree/ability_spec.rb' + - 'spec/models/spree/product_spec.rb' + - 'spec/models/tag_rule/filter_payment_methods_spec.rb' + - 'spec/models/tag_rule/filter_products_spec.rb' + - 'spec/models/tag_rule/filter_shipping_methods_spec.rb' + - 'spec/serializers/admin/for_order_cycle/enterprise_serializer_spec.rb' + - 'spec/serializers/admin/for_order_cycle/supplied_product_serializer_spec.rb' + - 'spec/serializers/order_serializer_spec.rb' + - 'spec/serializers/orders_by_distributor_serializer_spec.rb' + - 'spec/support/matchers/delegate_matchers.rb' + - 'spec/support/matchers/select2_matchers.rb' + - 'spec/support/matchers/table_matchers.rb' # Offense count: 27 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines Style/EmptyLinesAroundClassBody: - Enabled: false + Exclude: + - 'app/controllers/admin/account_controller.rb' + - 'app/controllers/admin/cache_settings_controller.rb' + - 'app/controllers/admin/enterprise_fees_controller.rb' + - 'app/controllers/admin/inventory_items_controller.rb' + - 'app/controllers/admin/invoice_settings_controller.rb' + - 'app/controllers/admin/product_import_controller.rb' + - 'app/controllers/admin/tag_rules_controller.rb' + - 'app/controllers/api/enterprises_controller.rb' + - 'app/controllers/application_controller.rb' + - 'app/controllers/home_controller.rb' + - 'app/mailers/producer_mailer.rb' + - 'app/models/coordinator_fee.rb' + - 'app/models/producer_property.rb' + - 'app/models/spree/preferences/file_configuration.rb' + - 'app/serializers/api/admin/enterprise_fee_serializer.rb' + - 'app/serializers/api/admin/index_enterprise_serializer.rb' + - 'app/serializers/api/currency_config_serializer.rb' + - 'app/serializers/api/product_serializer.rb' + - 'lib/discourse/single_sign_on.rb' + - 'lib/open_food_network/distribution_change_validator.rb' + - 'lib/open_food_network/lettuce_share_report.rb' + - 'lib/open_food_network/order_and_distributor_report.rb' + - 'lib/open_food_network/rack_request_blocker.rb' + - 'lib/open_food_network/reports/bulk_coop_report.rb' # Offense count: 7 # Cop supports --auto-correct. @@ -656,11 +956,48 @@ Style/EmptyMethod: - 'app/controllers/shops_controller.rb' - 'app/controllers/spree/admin/products_controller_decorator.rb' -# Offense count: 53 +# Offense count: 54 # Cop supports --auto-correct. # Configuration parameters: AllowForAlignment, ForceEqualSignAlignment. Style/ExtraSpacing: - Enabled: false + Exclude: + - 'app/controllers/admin/enterprises_controller.rb' + - 'app/controllers/checkout_controller.rb' + - 'app/controllers/spree/admin/payments_controller_decorator.rb' + - 'app/helpers/admin/injection_helper.rb' + - 'app/models/enterprise.rb' + - 'app/models/spree/classification_decorator.rb' + - 'app/models/spree/product_set.rb' + - 'app/serializers/api/enterprise_serializer.rb' + - 'config.ru' + - 'lib/open_food_network/bulk_coop_report.rb' + - 'lib/open_food_network/option_value_namer.rb' + - 'lib/open_food_network/paperclippable.rb' + - 'lib/open_food_network/variant_and_line_item_naming.rb' + - 'lib/spree/product_filters.rb' + - 'lib/tasks/karma.rake' + - 'spec/controllers/admin/accounts_and_billing_settings_controller_spec.rb' + - 'spec/factories.rb' + - 'spec/features/admin/bulk_order_management_spec.rb' + - 'spec/features/admin/bulk_product_update_spec.rb' + - 'spec/features/admin/orders_spec.rb' + - 'spec/features/admin/product_import_spec.rb' + - 'spec/features/admin/reports_spec.rb' + - 'spec/features/admin/variant_overrides_spec.rb' + - 'spec/features/consumer/groups_spec.rb' + - 'spec/features/consumer/shopping/shopping_spec.rb' + - 'spec/lib/open_food_network/enterprise_fee_calculator_spec.rb' + - 'spec/lib/open_food_network/reports/rule_spec.rb' + - 'spec/lib/open_food_network/xero_invoices_report_spec.rb' + - 'spec/models/enterprise_fee_spec.rb' + - 'spec/models/enterprise_spec.rb' + - 'spec/models/order_cycle_spec.rb' + - 'spec/models/spree/adjustment_spec.rb' + - 'spec/models/spree/order_spec.rb' + - 'spec/models/variant_override_spec.rb' + - 'spec/serializers/admin/for_order_cycle/enterprise_serializer_spec.rb' + - 'spec/serializers/admin/for_order_cycle/supplied_product_serializer_spec.rb' + - 'spec/support/request/web_helper.rb' # Offense count: 2 # Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts, AllowedAcronyms. @@ -678,10 +1015,59 @@ Style/FirstParameterIndentation: Exclude: - 'lib/open_food_network/permissions.rb' -# Offense count: 87 +# Offense count: 88 # Configuration parameters: MinBodyLength. Style/GuardClause: - Enabled: false + Exclude: + - 'app/controllers/admin/accounts_and_billing_settings_controller.rb' + - 'app/controllers/admin/enterprise_fees_controller.rb' + - 'app/controllers/admin/enterprises_controller.rb' + - 'app/controllers/admin/order_cycles_controller.rb' + - 'app/controllers/admin/product_import_controller.rb' + - 'app/controllers/application_controller.rb' + - 'app/controllers/base_controller.rb' + - 'app/controllers/checkout_controller.rb' + - 'app/controllers/enterprises_controller.rb' + - 'app/controllers/home_controller.rb' + - 'app/controllers/spree/admin/adjustments_controller_decorator.rb' + - 'app/controllers/spree/admin/base_controller_decorator.rb' + - 'app/controllers/spree/admin/orders_controller_decorator.rb' + - 'app/controllers/spree/admin/products_controller_decorator.rb' + - 'app/controllers/spree/admin/resource_controller_decorator.rb' + - 'app/controllers/spree/admin/shipping_methods_controller_decorator.rb' + - 'app/controllers/spree/admin/variants_controller_decorator.rb' + - 'app/controllers/spree/orders_controller_decorator.rb' + - 'app/controllers/spree/paypal_controller_decorator.rb' + - 'app/jobs/products_cache_integrity_checker_job.rb' + - 'app/jobs/update_account_invoices.rb' + - 'app/jobs/update_billable_periods.rb' + - 'app/mailers/producer_mailer.rb' + - 'app/models/enterprise.rb' + - 'app/models/enterprise_group.rb' + - 'app/models/producer_property.rb' + - 'app/models/product_importer.rb' + - 'app/models/spree/classification_decorator.rb' + - 'app/models/spree/order_decorator.rb' + - 'app/models/spree/order_populator_decorator.rb' + - 'app/models/spree/preference_decorator.rb' + - 'app/models/spree/product_decorator.rb' + - 'app/models/spree/user_decorator.rb' + - 'lib/discourse/single_sign_on.rb' + - 'lib/open_food_network/accounts_and_billing_settings_validator.rb' + - 'lib/open_food_network/cached_products_renderer.rb' + - 'lib/open_food_network/order_cycle_form_applicator.rb' + - 'lib/open_food_network/products_cache.rb' + - 'lib/open_food_network/products_cache_refreshment.rb' + - 'lib/open_food_network/products_renderer.rb' + - 'lib/open_food_network/rack_request_blocker.rb' + - 'lib/open_food_network/variant_and_line_item_naming.rb' + - 'lib/spree/core/controller_helpers/order_decorator.rb' + - 'lib/spree/core/controller_helpers/respond_with_decorator.rb' + - 'lib/tasks/karma.rake' + - 'spec/features/admin/orders_spec.rb' + - 'spec/support/delayed_job_helper.rb' + - 'spec/support/request/distribution_helper.rb' + - 'spec/support/request/shop_workflow.rb' # Offense count: 1241 # Cop supports --auto-correct. @@ -721,7 +1107,23 @@ Style/IndentAssignment: # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth. # SupportedStyles: special_inside_parentheses, consistent, align_braces Style/IndentHash: - Enabled: false + Exclude: + - 'app/controllers/admin/accounts_and_billing_settings_controller.rb' + - 'app/controllers/admin/business_model_configuration_controller.rb' + - 'app/controllers/checkout_controller.rb' + - 'app/controllers/spree/admin/search_controller_decorator.rb' + - 'app/jobs/finalize_account_invoices.rb' + - 'app/jobs/update_account_invoices.rb' + - 'app/jobs/update_billable_periods.rb' + - 'app/models/spree/order_decorator.rb' + - 'spec/controllers/admin/accounts_and_billing_settings_controller_spec.rb' + - 'spec/controllers/admin/business_model_configuration_controller_spec.rb' + - 'spec/controllers/admin/order_cycles_controller_spec.rb' + - 'spec/features/admin/accounts_and_billing_settings_spec.rb' + - 'spec/features/admin/business_model_configuration_spec.rb' + - 'spec/features/admin/tax_settings_spec.rb' + - 'spec/lib/open_food_network/order_cycle_form_applicator_spec.rb' + - 'spec/support/request/authentication_workflow.rb' # Offense count: 1 # Cop supports --auto-correct. @@ -746,11 +1148,28 @@ Style/IndentationConsistency: - 'spec/models/spree/line_item_spec.rb' - 'spec/models/spree/product_spec.rb' -# Offense count: 21 +# Offense count: 20 # Cop supports --auto-correct. # Configuration parameters: Width, IgnoredPatterns. Style/IndentationWidth: - Enabled: false + Exclude: + - 'app/controllers/admin/invoice_settings_controller.rb' + - 'app/controllers/admin/order_cycles_controller.rb' + - 'app/controllers/api/order_cycles_controller.rb' + - 'app/controllers/spree/admin/reports_controller_decorator.rb' + - 'app/models/spree/line_item_decorator.rb' + - 'app/serializers/api/admin/for_order_cycle/enterprise_serializer.rb' + - 'app/serializers/api/admin/for_order_cycle/supplied_product_serializer.rb' + - 'app/serializers/api/admin/order_cycle_serializer.rb' + - 'lib/discourse/single_sign_on.rb' + - 'lib/open_food_network/last_used_address.rb' + - 'spec/features/consumer/shopping/variant_overrides_spec.rb' + - 'spec/helpers/admin/business_model_configuration_helper_spec.rb' + - 'spec/helpers/groups_helper_spec.rb' + - 'spec/lib/open_food_network/enterprise_fee_calculator_spec.rb' + - 'spec/lib/open_food_network/order_grouper_spec.rb' + - 'spec/lib/spree/product_filters_spec.rb' + - 'spec/models/enterprise_spec.rb' # Offense count: 1 # Cop supports --auto-correct. @@ -775,7 +1194,37 @@ Style/InverseMethods: # Offense count: 80 # Cop supports --auto-correct. Style/LeadingCommentSpace: - Enabled: false + Exclude: + - 'Gemfile' + - 'Guardfile' + - 'app/controllers/spree/admin/products_controller_decorator.rb' + - 'app/models/billable_period.rb' + - 'app/models/content_configuration.rb' + - 'app/models/product_importer.rb' + - 'app/models/spreadsheet_entry.rb' + - 'app/models/spree/inventory_unit_decorator.rb' + - 'app/models/spree/taxon_decorator.rb' + - 'app/overrides/add_capture_order_shortcut.rb' + - 'app/serializers/api/address_serializer.rb' + - 'app/serializers/api/enterprise_serializer.rb' + - 'app/serializers/api/product_serializer.rb' + - 'lib/tasks/users.rake' + - 'spec/archive/features/consumer/checkout_spec.rb' + - 'spec/controllers/spree/api/line_items_controller_spec.rb' + - 'spec/factories.rb' + - 'spec/features/admin/products_spec.rb' + - 'spec/features/admin/reports_spec.rb' + - 'spec/features/consumer/shops_spec.rb' + - 'spec/jobs/finalize_account_invoices_spec.rb' + - 'spec/lib/open_food_network/order_and_distributor_report_spec.rb' + - 'spec/lib/open_food_network/order_grouper_spec.rb' + - 'spec/lib/open_food_network/user_balance_calculator_spec.rb' + - 'spec/models/enterprise_spec.rb' + - 'spec/models/spree/order_spec.rb' + - 'spec/spec_helper.rb' + - 'spec/support/cancan_helper.rb' + - 'spec/support/matchers/select2_matchers.rb' + - 'spec/support/request/authentication_workflow.rb' # Offense count: 9 # Cop supports --auto-correct. @@ -837,7 +1286,24 @@ Style/MultilineArrayBraceLayout: # Offense count: 44 # Cop supports --auto-correct. Style/MultilineBlockLayout: - Enabled: false + Exclude: + - 'app/models/spree/calculator/default_tax_decorator.rb' + - 'app/models/spree/product_decorator.rb' + - 'lib/open_food_network/users_and_enterprises_report.rb' + - 'spec/controllers/admin/column_preferences_controller_spec.rb' + - 'spec/controllers/shop_controller_spec.rb' + - 'spec/controllers/spree/orders_controller_spec.rb' + - 'spec/features/admin/variant_overrides_spec.rb' + - 'spec/helpers/enterprises_helper_spec.rb' + - 'spec/jobs/update_billable_periods_spec.rb' + - 'spec/lib/open_food_network/enterprise_fee_calculator_spec.rb' + - 'spec/lib/open_food_network/permissions_spec.rb' + - 'spec/lib/open_food_network/user_balance_calculator_spec.rb' + - 'spec/models/column_preference_spec.rb' + - 'spec/models/order_cycle_spec.rb' + - 'spec/models/spree/product_spec.rb' + - 'spec/models/spree/variant_spec.rb' + - 'spec/serializers/enterprise_serializer_spec.rb' # Offense count: 6 # Cop supports --auto-correct. @@ -875,14 +1341,71 @@ Style/MultilineMethodCallBraceLayout: # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth. # SupportedStyles: aligned, indented, indented_relative_to_receiver Style/MultilineMethodCallIndentation: - Enabled: false + Exclude: + - 'app/controllers/admin/order_cycles_controller.rb' + - 'app/controllers/admin/variant_overrides_controller.rb' + - 'app/controllers/api/order_cycles_controller.rb' + - 'app/controllers/base_controller.rb' + - 'app/controllers/checkout_controller.rb' + - 'app/controllers/spree/admin/orders_controller_decorator.rb' + - 'app/controllers/spree/admin/products_controller_decorator.rb' + - 'app/controllers/spree/admin/reports_controller_decorator.rb' + - 'app/controllers/spree/admin/search_controller_decorator.rb' + - 'app/controllers/spree/api/products_controller_decorator.rb' + - 'app/controllers/spree/orders_controller_decorator.rb' + - 'app/jobs/update_billable_periods.rb' + - 'app/models/column_preference.rb' + - 'app/models/enterprise.rb' + - 'app/models/enterprise_relationship.rb' + - 'app/models/exchange.rb' + - 'app/models/order_cycle.rb' + - 'app/models/product_importer.rb' + - 'app/models/spree/ability_decorator.rb' + - 'app/models/spree/calculator/default_tax_decorator.rb' + - 'app/models/spree/line_item_decorator.rb' + - 'app/models/spree/order_decorator.rb' + - 'app/models/spree/payment_method_decorator.rb' + - 'app/models/spree/product_decorator.rb' + - 'app/models/spree/shipping_method_decorator.rb' + - 'app/models/spree/taxon_decorator.rb' + - 'app/models/spree/user_decorator.rb' + - 'app/models/spree/variant_decorator.rb' + - 'app/serializers/api/admin/exchange_serializer.rb' + - 'lib/open_food_network/lettuce_share_report.rb' + - 'lib/open_food_network/order_cycle_form_applicator.rb' + - 'lib/open_food_network/order_cycle_permissions.rb' + - 'lib/open_food_network/permissions.rb' + - 'lib/open_food_network/products_cache.rb' + - 'spec/controllers/spree/admin/reports_controller_spec.rb' + - 'spec/helpers/order_cycles_helper_spec.rb' + - 'spec/jobs/update_account_invoices_spec.rb' + - 'spec/jobs/update_billable_periods_spec.rb' + - 'spec/lib/open_food_network/enterprise_fee_calculator_spec.rb' + - 'spec/mailers/producer_mailer_spec.rb' + - 'spec/support/matchers/table_matchers.rb' # Offense count: 34 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth. # SupportedStyles: aligned, indented Style/MultilineOperationIndentation: - Enabled: false + Exclude: + - 'app/controllers/application_controller.rb' + - 'app/controllers/spree/admin/payment_methods_controller_decorator.rb' + - 'app/controllers/spree/admin/shipping_methods_controller_decorator.rb' + - 'app/helpers/enterprises_helper.rb' + - 'app/models/producer_property.rb' + - 'app/models/product_importer.rb' + - 'app/models/spree/ability_decorator.rb' + - 'app/models/spree/order_decorator.rb' + - 'app/models/spree/product_set.rb' + - 'app/models/variant_override_set.rb' + - 'lib/open_food_network/accounts_and_billing_settings_validator.rb' + - 'lib/open_food_network/order_cycle_permissions.rb' + - 'lib/open_food_network/products_cache_refreshment.rb' + - 'lib/open_food_network/sales_tax_report.rb' + - 'lib/open_food_network/users_and_enterprises_report.rb' + - 'spec/factories.rb' # Offense count: 8 # Cop supports --auto-correct. @@ -920,7 +1443,7 @@ Style/Next: - 'app/models/product_importer.rb' - 'lib/tasks/data.rake' -# Offense count: 10 +# Offense count: 9 # Cop supports --auto-correct. Style/NilComparison: Exclude: @@ -930,7 +1453,6 @@ Style/NilComparison: - 'spec/features/admin/product_import_spec.rb' - 'spec/features/consumer/shopping/shopping_spec.rb' - 'spec/models/order_cycle_spec.rb' - - 'spec/models/spree/adjustment_spec.rb' - 'spec/models/spree/order_spec.rb' # Offense count: 1 @@ -996,7 +1518,27 @@ Style/ParenthesesAroundCondition: # NamePrefixBlacklist: is_, has_, have_ # NameWhitelist: is_a? Style/PredicateName: - Enabled: false + Exclude: + - 'spec/**/*' + - 'app/mailers/producer_mailer.rb' + - 'app/models/enterprise.rb' + - 'app/models/enterprise_relationship.rb' + - 'app/models/order_cycle.rb' + - 'app/models/product_importer.rb' + - 'app/models/spreadsheet_entry.rb' + - 'app/models/spree/ability_decorator.rb' + - 'app/models/spree/adjustment_decorator.rb' + - 'app/models/spree/line_item_decorator.rb' + - 'app/models/spree/order_decorator.rb' + - 'app/models/spree/payment_method_decorator.rb' + - 'app/models/spree/preferences/file_configuration.rb' + - 'app/models/spree/product_decorator.rb' + - 'app/models/spree/shipping_method_decorator.rb' + - 'lib/open_food_network/customers_report.rb' + - 'lib/open_food_network/order_cycle_management_report.rb' + - 'lib/open_food_network/order_grouper.rb' + - 'lib/open_food_network/packing_report.rb' + - 'lib/tasks/data.rake' # Offense count: 5 # Cop supports --auto-correct. @@ -1070,7 +1612,37 @@ Style/RedundantReturn: # Offense count: 110 # Cop supports --auto-correct. Style/RedundantSelf: - Enabled: false + Exclude: + - 'app/models/billable_period.rb' + - 'app/models/calculator/flat_percent_per_item.rb' + - 'app/models/enterprise.rb' + - 'app/models/exchange.rb' + - 'app/models/open_food_network/calculator/weight.rb' + - 'app/models/order_cycle.rb' + - 'app/models/producer_property.rb' + - 'app/models/product_importer.rb' + - 'app/models/spreadsheet_entry.rb' + - 'app/models/spree/address_decorator.rb' + - 'app/models/spree/calculator/flat_percent_item_total_decorator.rb' + - 'app/models/spree/calculator/flexi_rate_decorator.rb' + - 'app/models/spree/calculator/per_item_decorator.rb' + - 'app/models/spree/gateway/migs.rb' + - 'app/models/spree/gateway/pin.rb' + - 'app/models/spree/line_item_decorator.rb' + - 'app/models/spree/order_decorator.rb' + - 'app/models/spree/payment_method_decorator.rb' + - 'app/models/spree/product_decorator.rb' + - 'app/models/spree/product_option_type_decorator.rb' + - 'app/models/spree/shipping_method_decorator.rb' + - 'app/models/spree/tax_rate_decorator.rb' + - 'app/models/spree/taxon_decorator.rb' + - 'app/models/spree/user_decorator.rb' + - 'app/models/spree/variant_decorator.rb' + - 'app/models/variant_override.rb' + - 'lib/open_food_network/locking.rb' + - 'lib/open_food_network/rack_request_blocker.rb' + - 'lib/open_food_network/reports/report.rb' + - 'lib/open_food_network/variant_and_line_item_naming.rb' # Offense count: 13 # Cop supports --auto-correct. @@ -1110,7 +1682,37 @@ Style/SpaceAfterColon: # Offense count: 58 # Cop supports --auto-correct. Style/SpaceAfterComma: - Enabled: false + Exclude: + - 'app/controllers/admin/order_cycles_controller.rb' + - 'app/controllers/spree/admin/products_controller_decorator.rb' + - 'app/controllers/spree/admin/reports_controller_decorator.rb' + - 'app/controllers/spree/orders_controller_decorator.rb' + - 'app/models/column_preference.rb' + - 'app/models/product_importer.rb' + - 'lib/discourse/single_sign_on.rb' + - 'lib/open_food_network/accounts_and_billing_settings_validator.rb' + - 'lib/open_food_network/business_model_configuration_validator.rb' + - 'lib/open_food_network/order_and_distributor_report.rb' + - 'lib/open_food_network/order_cycle_form_applicator.rb' + - 'lib/open_food_network/users_and_enterprises_report.rb' + - 'spec/controllers/admin/enterprises_controller_spec.rb' + - 'spec/controllers/admin/variant_overrides_controller_spec.rb' + - 'spec/features/admin/bulk_order_management_spec.rb' + - 'spec/features/admin/bulk_product_update_spec.rb' + - 'spec/features/admin/customers_spec.rb' + - 'spec/features/admin/variant_overrides_spec.rb' + - 'spec/jobs/update_account_invoices_spec.rb' + - 'spec/lib/open_food_network/group_buy_report_spec.rb' + - 'spec/lib/open_food_network/order_and_distributor_report_spec.rb' + - 'spec/models/content_configuration_spec.rb' + - 'spec/models/spree/order_spec.rb' + - 'spec/models/tag_rule/discount_order_spec.rb' + - 'spec/models/tag_rule/filter_order_cycles_spec.rb' + - 'spec/models/tag_rule/filter_payment_methods_spec.rb' + - 'spec/models/tag_rule/filter_products_spec.rb' + - 'spec/models/tag_rule/filter_shipping_methods_spec.rb' + - 'spec/spec_helper.rb' + - 'spec/support/cancan_helper.rb' # Offense count: 3 # Cop supports --auto-correct. @@ -1119,18 +1721,86 @@ Style/SpaceAfterSemicolon: - 'spec/controllers/spree/admin/base_controller_spec.rb' - 'spec/models/enterprise_spec.rb' -# Offense count: 66 +# Offense count: 67 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. # SupportedStyles: space, no_space Style/SpaceAroundEqualsInParameterDefault: - Enabled: false + Exclude: + - 'app/controllers/spree/admin/base_controller_decorator.rb' + - 'app/helpers/admin/injection_helper.rb' + - 'app/helpers/angular_form_helper.rb' + - 'app/helpers/checkout_helper.rb' + - 'app/helpers/order_cycles_helper.rb' + - 'app/helpers/spree/base_helper_decorator.rb' + - 'app/models/column_preference_set.rb' + - 'app/models/enterprise_fee.rb' + - 'app/models/enterprise_fee_set.rb' + - 'app/models/enterprise_relationship.rb' + - 'app/models/enterprise_set.rb' + - 'app/models/exchange.rb' + - 'app/models/model_set.rb' + - 'app/models/order_cycle_set.rb' + - 'app/models/product_importer.rb' + - 'app/models/spree/calculator/per_item_decorator.rb' + - 'app/models/spree/payment_decorator.rb' + - 'app/models/spree/payment_method_decorator.rb' + - 'app/models/spree/preferences/file_configuration.rb' + - 'app/models/spree/product_set.rb' + - 'app/models/spree/shipping_method_decorator.rb' + - 'app/models/spree/taxon_decorator.rb' + - 'app/models/variant_override_set.rb' + - 'lib/discourse/single_sign_on.rb' + - 'lib/open_food_network/accounts_and_billing_settings_validator.rb' + - 'lib/open_food_network/bill_calculator.rb' + - 'lib/open_food_network/business_model_configuration_validator.rb' + - 'lib/open_food_network/enterprise_fee_calculator.rb' + - 'lib/open_food_network/enterprise_issue_validator.rb' + - 'lib/open_food_network/order_cycle_form_applicator.rb' + - 'lib/open_food_network/permissions.rb' + - 'lib/open_food_network/scope_variant_to_hub.rb' + - 'lib/open_food_network/tag_rule_applicator.rb' + - 'lib/open_food_network/xero_invoices_report.rb' + - 'lib/spree/money_decorator.rb' + - 'spec/features/admin/enterprise_relationships_spec.rb' + - 'spec/features/admin/reports_spec.rb' + - 'spec/models/enterprise_spec.rb' + - 'spec/support/matchers/select2_matchers.rb' + - 'spec/support/request/distribution_helper.rb' + - 'spec/support/request/web_helper.rb' # Offense count: 58 # Cop supports --auto-correct. # Configuration parameters: AllowForAlignment. Style/SpaceAroundOperators: - Enabled: false + Exclude: + - 'app/controllers/admin/product_import_controller.rb' + - 'app/controllers/checkout_controller.rb' + - 'app/helpers/admin/business_model_configuration_helper.rb' + - 'app/jobs/update_billable_periods.rb' + - 'app/models/product_importer.rb' + - 'app/models/spree/address_decorator.rb' + - 'app/overrides/remove_search_bar.rb' + - 'app/overrides/remove_side_bar.rb' + - 'app/overrides/replace_shipping_address_form_with_distributor_details.rb' + - 'app/serializers/api/enterprise_serializer.rb' + - 'lib/open_food_network/xero_invoices_report.rb' + - 'lib/spree/product_filters.rb' + - 'spec/controllers/admin/enterprises_controller_spec.rb' + - 'spec/controllers/cart_controller_spec.rb' + - 'spec/controllers/spree/orders_controller_spec.rb' + - 'spec/controllers/user_passwords_controller_spec.rb' + - 'spec/factories.rb' + - 'spec/features/admin/bulk_order_management_spec.rb' + - 'spec/features/admin/bulk_product_update_spec.rb' + - 'spec/features/consumer/shopping/checkout_spec.rb' + - 'spec/helpers/checkout_helper_spec.rb' + - 'spec/helpers/order_cycles_helper_spec.rb' + - 'spec/jobs/update_billable_periods_spec.rb' + - 'spec/lib/open_food_network/order_grouper_spec.rb' + - 'spec/models/calculator/weight_spec.rb' + - 'spec/support/cancan_helper.rb' + - 'spec/support/seeds.rb' # Offense count: 6 # Cop supports --auto-correct. @@ -1166,20 +1836,88 @@ Style/SpaceInLambdaLiteral: - 'app/models/spree/product_decorator.rb' - 'app/models/spree/variant_decorator.rb' -# Offense count: 191 +# Offense count: 194 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SupportedStylesForEmptyBraces, SpaceBeforeBlockParameters. # SupportedStyles: space, no_space # SupportedStylesForEmptyBraces: space, no_space Style/SpaceInsideBlockBraces: - Enabled: false + Exclude: + - 'app/controllers/spree/admin/payment_methods_controller_decorator.rb' + - 'app/controllers/spree/admin/payments_controller_decorator.rb' + - 'app/controllers/spree/admin/variants_controller_decorator.rb' + - 'app/controllers/spree/orders_controller_decorator.rb' + - 'app/models/column_preference.rb' + - 'app/models/spree/order_decorator.rb' + - 'lib/spree/product_filters.rb' + - 'lib/tasks/dev.rake' + - 'lib/tasks/karma.rake' + - 'spec/archive/features/consumer/checkout_spec.rb' + - 'spec/controllers/admin/accounts_and_billing_settings_controller_spec.rb' + - 'spec/controllers/admin/business_model_configuration_controller_spec.rb' + - 'spec/controllers/admin/inventory_items_controller_spec.rb' + - 'spec/controllers/admin/tag_rules_controller_spec.rb' + - 'spec/controllers/admin/variant_overrides_controller_spec.rb' + - 'spec/controllers/spree/admin/base_controller_spec.rb' + - 'spec/controllers/spree/admin/orders_controller_spec.rb' + - 'spec/controllers/spree/admin/search_controller_spec.rb' + - 'spec/factories.rb' + - 'spec/features/admin/bulk_order_management_spec.rb' + - 'spec/features/admin/customers_spec.rb' + - 'spec/features/admin/tag_rules_spec.rb' + - 'spec/features/consumer/account_spec.rb' + - 'spec/features/consumer/shopping/products_spec.rb' + - 'spec/features/consumer/shops_spec.rb' + - 'spec/helpers/enterprises_helper_spec.rb' + - 'spec/helpers/injection_helper_spec.rb' + - 'spec/helpers/spree/orders_helper_spec.rb' + - 'spec/jobs/finalize_account_invoices_spec.rb' + - 'spec/jobs/update_account_invoices_spec.rb' + - 'spec/jobs/update_billable_periods_spec.rb' + - 'spec/lib/open_food_network/order_cycle_form_applicator_spec.rb' + - 'spec/lib/open_food_network/order_grouper_spec.rb' + - 'spec/lib/open_food_network/orders_and_fulfillments_report_spec.rb' + - 'spec/lib/open_food_network/products_renderer_spec.rb' + - 'spec/lib/open_food_network/tag_rule_applicator_spec.rb' + - 'spec/models/column_preference_spec.rb' + - 'spec/models/enterprise_relationship_spec.rb' + - 'spec/models/enterprise_spec.rb' + - 'spec/models/spree/line_item_spec.rb' + - 'spec/models/spree/order_spec.rb' + - 'spec/models/spree/payment_spec.rb' + - 'spec/models/spree/product_spec.rb' + - 'spec/models/spree/user_spec.rb' + - 'spec/models/tag_rule/discount_order_spec.rb' + - 'spec/serializers/admin/for_order_cycle/enterprise_serializer_spec.rb' + - 'spec/serializers/admin/for_order_cycle/supplied_product_serializer_spec.rb' + - 'spec/serializers/orders_by_distributor_serializer_spec.rb' + - 'spec/spec_helper.rb' + - 'spec/support/cancan_helper.rb' # Offense count: 140 # Cop supports --auto-correct. Style/SpaceInsideBrackets: - Enabled: false + Exclude: + - 'app/controllers/admin/order_cycles_controller.rb' + - 'app/helpers/spree/reports_helper.rb' + - 'app/models/enterprise.rb' + - 'app/serializers/api/admin/exchange_serializer.rb' + - 'lib/open_food_network/bulk_coop_report.rb' + - 'lib/open_food_network/order_and_distributor_report.rb' + - 'lib/open_food_network/orders_and_fulfillments_report.rb' + - 'lib/open_food_network/packing_report.rb' + - 'lib/open_food_network/payments_report.rb' + - 'lib/open_food_network/users_and_enterprises_report.rb' + - 'spec/controllers/admin/variant_overrides_controller_spec.rb' + - 'spec/controllers/cart_controller_spec.rb' + - 'spec/features/admin/reports_spec.rb' + - 'spec/jobs/update_billable_periods_spec.rb' + - 'spec/lib/open_food_network/order_and_distributor_report_spec.rb' + - 'spec/lib/open_food_network/order_grouper_spec.rb' + - 'spec/lib/open_food_network/users_and_enterprises_report_spec.rb' + - 'spec/performance/orders_controller_spec.rb' -# Offense count: 731 +# Offense count: 729 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SupportedStylesForEmptyBraces. # SupportedStyles: space, no_space, compact @@ -1229,14 +1967,78 @@ Style/StructInheritance: # Configuration parameters: EnforcedStyle, SupportedStyles. # SupportedStyles: percent, brackets Style/SymbolArray: - Enabled: false + Exclude: + - 'Gemfile' + - 'app/controllers/admin/accounts_and_billing_settings_controller.rb' + - 'app/controllers/admin/business_model_configuration_controller.rb' + - 'app/controllers/admin/contents_controller.rb' + - 'app/controllers/admin/enterprise_fees_controller.rb' + - 'app/controllers/admin/enterprise_groups_controller.rb' + - 'app/controllers/admin/enterprises_controller.rb' + - 'app/controllers/admin/order_cycles_controller.rb' + - 'app/controllers/admin/tag_rules_controller.rb' + - 'app/controllers/admin/variant_overrides_controller.rb' + - 'app/controllers/api/enterprises_controller.rb' + - 'app/controllers/spree/admin/adjustments_controller_decorator.rb' + - 'app/controllers/spree/admin/orders_controller_decorator.rb' + - 'app/controllers/spree/admin/payment_methods_controller_decorator.rb' + - 'app/controllers/spree/admin/products_controller_decorator.rb' + - 'app/controllers/spree/admin/reports_controller_decorator.rb' + - 'app/controllers/spree/admin/shipping_methods_controller_decorator.rb' + - 'app/jobs/update_billable_periods.rb' + - 'app/models/enterprise.rb' + - 'app/models/exchange.rb' + - 'app/models/spree/ability_decorator.rb' + - 'app/models/spree/payment_method_decorator.rb' + - 'lib/discourse/single_sign_on.rb' + - 'lib/open_food_network/paperclippable.rb' + - 'spec/controllers/api/order_cycles_controller_spec.rb' + - 'spec/controllers/spree/admin/line_items_controller_spec.rb' + - 'spec/controllers/spree/admin/orders_controller_spec.rb' + - 'spec/controllers/spree/api/products_controller_spec.rb' + - 'spec/controllers/spree/api/variants_controller_spec.rb' + - 'spec/features/admin/enterprise_relationships_spec.rb' + - 'spec/jobs/update_account_invoices_spec.rb' + - 'spec/lib/open_food_network/permissions_spec.rb' + - 'spec/models/column_preference_spec.rb' + - 'spec/models/enterprise_relationship_spec.rb' + - 'spec/models/enterprise_spec.rb' + - 'spec/models/exchange_spec.rb' + - 'spec/models/spree/ability_spec.rb' # Offense count: 97 # Cop supports --auto-correct. # Configuration parameters: IgnoredMethods. # IgnoredMethods: respond_to, define_method Style/SymbolProc: - Enabled: false + Exclude: + - 'app/helpers/angular_form_helper.rb' + - 'app/helpers/spree/admin/navigation_helper_decorator.rb' + - 'app/models/spree/product_decorator.rb' + - 'app/views/json/_producer.rabl' + - 'app/views/json/partials/_enterprise.rabl' + - 'app/views/spree/admin/variants/search.rabl' + - 'app/views/spree/api/products/bulk_show.v1.rabl' + - 'lib/open_food_network/bulk_coop_report.rb' + - 'lib/open_food_network/group_buy_report.rb' + - 'lib/open_food_network/lettuce_share_report.rb' + - 'lib/open_food_network/orders_and_fulfillments_report.rb' + - 'lib/open_food_network/packing_report.rb' + - 'lib/open_food_network/payments_report.rb' + - 'lib/open_food_network/permissions.rb' + - 'lib/open_food_network/reports/bulk_coop_allocation_report.rb' + - 'lib/open_food_network/reports/bulk_coop_supplier_report.rb' + - 'lib/spree/product_filters.rb' + - 'spec/controllers/api/order_cycles_controller_spec.rb' + - 'spec/controllers/spree/admin/line_items_controller_spec.rb' + - 'spec/controllers/spree/admin/orders_controller_spec.rb' + - 'spec/controllers/spree/api/products_controller_spec.rb' + - 'spec/controllers/spree/api/variants_controller_spec.rb' + - 'spec/features/admin/bulk_product_update_spec.rb' + - 'spec/features/admin/order_cycles_spec.rb' + - 'spec/lib/open_food_network/group_buy_report_spec.rb' + - 'spec/lib/open_food_network/order_grouper_spec.rb' + - 'spec/models/spree/user_spec.rb' # Offense count: 6 # Cop supports --auto-correct. @@ -1268,7 +2070,26 @@ Style/TrailingUnderscoreVariable: # Offense count: 32 # Cop supports --auto-correct. Style/TrailingWhitespace: - Enabled: false + Exclude: + - 'app/models/distributor_shipping_method.rb' + - 'app/models/product_importer.rb' + - 'app/models/spree/money_decorator.rb' + - 'app/serializers/api/image_serializer.rb' + - 'app/serializers/api/shipping_method_serializer.rb' + - 'app/views/json/_current_order.rabl' + - 'app/views/json/_enterprises.rabl' + - 'app/views/json/_producer.rabl' + - 'app/views/json/partials/_producer.rabl' + - 'lib/open_food_network/group_buy_report.rb' + - 'lib/tasks/dev.rake' + - 'spec/controllers/spree/store_controller_spec.rb' + - 'spec/features/admin/enterprise_user_spec.rb' + - 'spec/lib/open_food_network/group_buy_report_spec.rb' + - 'spec/lib/open_food_network/option_value_namer_spec.rb' + - 'spec/lib/open_food_network/order_grouper_spec.rb' + - 'spec/serializers/admin/enterprise_serializer_spec.rb' + - 'spec/support/request/menu_helper.rb' + - 'spec/views/json/producers.json.rabl_spec.rb' # Offense count: 1 # Cop supports --auto-correct. @@ -1307,7 +2128,30 @@ Style/UnneededInterpolation: # Offense count: 23 # Cop supports --auto-correct. Style/UnneededPercentQ: - Enabled: false + Exclude: + - 'spec/archive/features/consumer/checkout_spec.rb' + - 'spec/features/admin/adjustments_spec.rb' + - 'spec/features/admin/bulk_order_management_spec.rb' + - 'spec/features/admin/bulk_product_update_spec.rb' + - 'spec/features/admin/content_spec.rb' + - 'spec/features/admin/enterprise_fees_spec.rb' + - 'spec/features/admin/enterprise_groups_spec.rb' + - 'spec/features/admin/enterprise_relationships_spec.rb' + - 'spec/features/admin/enterprise_roles_spec.rb' + - 'spec/features/admin/enterprise_user_spec.rb' + - 'spec/features/admin/enterprises_spec.rb' + - 'spec/features/admin/image_settings_spec.rb' + - 'spec/features/admin/order_cycles_spec.rb' + - 'spec/features/admin/orders_spec.rb' + - 'spec/features/admin/overview_spec.rb' + - 'spec/features/admin/payment_method_spec.rb' + - 'spec/features/admin/products_spec.rb' + - 'spec/features/admin/reports_spec.rb' + - 'spec/features/admin/variant_overrides_spec.rb' + - 'spec/features/admin/variants_spec.rb' + - 'spec/features/consumer/account_spec.rb' + - 'spec/features/consumer/producers_spec.rb' + - 'spec/support/request/web_helper.rb' # Offense count: 4 # Configuration parameters: EnforcedStyle, SupportedStyles.