From df27ee0d3e3a0130bbf2be4d24cba84381adf7e1 Mon Sep 17 00:00:00 2001
From: luisramos0 <luisramos0@gmail.com>
Date: Sun, 14 Jul 2019 16:06:09 +0100
Subject: [PATCH] Refactor line_item_syncer.add_order_update_issue out of
 line_item_syncer.create_new_items

---
 app/services/line_item_syncer.rb | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/app/services/line_item_syncer.rb b/app/services/line_item_syncer.rb
index 4c9354abd0..6e23d12875 100644
--- a/app/services/line_item_syncer.rb
+++ b/app/services/line_item_syncer.rb
@@ -37,14 +37,7 @@ class LineItemSyncer
       next if skip_stock_check?(order) || new_line_item.sufficient_stock?
 
       order.line_items.delete(new_line_item)
-
-      issue_description = "#{new_line_item.product.name} - #{new_line_item.full_name}"
-      if new_line_item.variant.in_stock?
-        issue_description << I18n.t("spree.orders.line_item.insufficient_stock", on_hand: new_line_item.variant.on_hand)
-      else
-        issue_description << I18n.t("spree.orders.line_item.out_of_stock")
-      end
-      order_update_issues.add(order, issue_description)
+      add_order_update_issue(order, new_line_item)
     end
   end
 
@@ -75,4 +68,14 @@ class LineItemSyncer
   def skip_stock_check?(order)
     !order.complete?
   end
+
+  def add_order_update_issue(order, line_item)
+    issue_description = "#{line_item.product.name} - #{line_item.full_name}"
+    if line_item.variant.in_stock?
+      issue_description << I18n.t("spree.orders.line_item.insufficient_stock", on_hand: line_item.variant.on_hand)
+    else
+      issue_description << I18n.t("spree.orders.line_item.out_of_stock")
+    end
+    order_update_issues.add(order, issue_description)
+  end
 end