From de52e21ee942bc23f13468a3c5220505fe01f0c8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois=20Turbelin?= Date: Thu, 26 Feb 2026 18:04:02 +0100 Subject: [PATCH] Remove floating point overkill for prices sum --- app/helpers/reports_helper.rb | 2 +- spec/lib/reports/bulk_coop_report_spec.rb | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/app/helpers/reports_helper.rb b/app/helpers/reports_helper.rb index 09fe3d5d10..e459c43231 100644 --- a/app/helpers/reports_helper.rb +++ b/app/helpers/reports_helper.rb @@ -63,6 +63,6 @@ module ReportsHelper end def prices_sum(prices_list) - prices_list.sum(&:to_f).round(2) + prices_list.sum end end diff --git a/spec/lib/reports/bulk_coop_report_spec.rb b/spec/lib/reports/bulk_coop_report_spec.rb index b07643f9d9..b97175db64 100644 --- a/spec/lib/reports/bulk_coop_report_spec.rb +++ b/spec/lib/reports/bulk_coop_report_spec.rb @@ -182,11 +182,10 @@ module Reporting describe '#customer_payments_amount_owed' do let(:params) { {} } let(:user) { build(:user) } - let!(:line_item) { create(:line_item) } - let(:order) { line_item.order } + let(:order) { create(:order) } + let!(:line_item) { create(:line_item, order: order) } it 'calls #new_outstanding_balance' do - expect_any_instance_of(Spree::Order).to receive(:new_outstanding_balance) CustomerPayments.new(user).__send__(:customer_payments_amount_owed, [line_item]) end end