From de19efca64246ad77794a1abef77ec72faf26115 Mon Sep 17 00:00:00 2001 From: Luis Ramos Date: Thu, 5 Nov 2020 12:11:31 +0000 Subject: [PATCH] Fix rubocop issue and add missing exceptions to manual_todo to get a green rubocop run --- .rubocop_manual_todo.yml | 52 ++++++------------- .../spree/admin/variants_controller.rb | 4 +- 2 files changed, 18 insertions(+), 38 deletions(-) diff --git a/.rubocop_manual_todo.yml b/.rubocop_manual_todo.yml index 1db76f28b0..51eb8c7c6b 100644 --- a/.rubocop_manual_todo.yml +++ b/.rubocop_manual_todo.yml @@ -66,8 +66,9 @@ Layout/LineLength: - app/models/spree/image.rb - app/models/spree/order.rb - app/models/spree/payment_method.rb - - app/models/spree/product_decorator.rb + - app/models/spree/product.rb - app/models/spree/user.rb + - app/models/spree/variant.rb - app/models/subscription.rb - app/models/variant_override.rb - app/models/variant_override_set.rb @@ -363,6 +364,7 @@ Metrics/AbcSize: - app/controllers/spree/admin/variants_controller.rb - app/controllers/spree/credit_cards_controller.rb - app/controllers/spree/orders_controller.rb + - app/controllers/spree/paypal_controller_decorator.rb - app/controllers/spree/user_passwords_controller.rb - app/controllers/spree/user_registrations_controller.rb - app/controllers/spree/users_controller.rb @@ -399,11 +401,12 @@ Metrics/AbcSize: - app/models/spree/preference.rb - app/models/spree/preferences/preferable_class_methods.rb - app/models/spree/preferences/preferable.rb - - app/models/spree/product_decorator.rb + - app/models/spree/product.rb - app/models/spree/return_authorization.rb - app/models/spree/shipment.rb - app/models/spree/taxon.rb - app/models/spree/tax_rate.rb + - app/models/spree/variant.rb - app/models/spree/zone.rb - app/serializers/api/product_serializer.rb - app/serializers/api/variant_serializer.rb @@ -530,7 +533,7 @@ Metrics/CyclomaticComplexity: - app/models/spree/preference.rb - app/models/spree/preferences/preferable.rb - app/models/spree/preferences/preferable_class_methods.rb - - app/models/spree/product_decorator.rb + - app/models/spree/product.rb - app/models/spree/return_authorization.rb - app/models/spree/zone.rb - app/models/variant_override_set.rb @@ -550,39 +553,6 @@ Metrics/CyclomaticComplexity: Metrics/PerceivedComplexity: Max: 7 Exclude: - - app/controllers/admin/enterprise_fees_controller.rb - - app/controllers/admin/enterprises_controller.rb - - app/controllers/spree/admin/taxons_controller.rb - - app/controllers/spree/orders_controller.rb - - app/helpers/checkout_helper.rb - - app/helpers/order_cycles_helper.rb - - app/helpers/spree/admin/base_helper.rb - - app/helpers/spree/admin/navigation_helper.rb - - app/models/enterprise.rb - - app/models/enterprise_relationship.rb - - app/models/spree/ability.rb - - app/models/spree/address.rb - - app/models/spree/order/checkout.rb - - app/models/spree/payment_method.rb - - app/models/spree/payment.rb - - app/models/spree/preferences/preferable.rb - - app/models/spree/preferences/preferable_class_methods.rb - - app/models/spree/product_decorator.rb - - app/models/spree/return_authorization.rb - - app/models/spree/zone.rb - - app/models/variant_override_set.rb - - app/services/cart_service.rb - - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb - - engines/order_management/app/services/order_management/stock/estimator.rb - - lib/active_merchant/billing/gateways/stripe_payment_intents.rb - - lib/discourse/single_sign_on.rb - - lib/open_food_network/enterprise_issue_validator.rb - - lib/spree/core/calculated_adjustments.rb - - lib/spree/core/controller_helpers/order.rb - - lib/spree/core/controller_helpers/respond_with.rb - - lib/spree/core/controller_helpers/ssl.rb - - lib/spree/localized_number.rb - - spec/models/product_importer_spec.rb - app/controllers/admin/enterprises_controller.rb - app/controllers/api/variants_controller.rb - app/controllers/spree/admin/taxons_controller.rb @@ -595,7 +565,10 @@ Metrics/PerceivedComplexity: - app/models/spree/address.rb - app/models/spree/order/checkout.rb - app/models/spree/order.rb - - app/models/spree/product_decorator.rb + - app/models/spree/preferences/preferable_class_methods.rb + - app/models/spree/preferences/preferable.rb + - app/models/spree/product.rb + - app/models/spree/return_authorization.rb - app/models/spree/zone.rb - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb - engines/order_management/app/services/order_management/stock/estimator.rb @@ -639,6 +612,7 @@ Metrics/MethodLength: - app/controllers/spree/admin/variants_controller.rb - app/controllers/spree/credit_cards_controller.rb - app/controllers/spree/orders_controller.rb + - app/controllers/spree/paypal_controller_decorator.rb - app/controllers/spree/user_sessions_controller.rb - app/controllers/stripe/callbacks_controller.rb - app/controllers/user_confirmations_controller.rb @@ -670,11 +644,13 @@ Metrics/MethodLength: - app/models/spree/preferences/preferable_class_methods.rb - app/models/spree/preferences/preferable.rb - app/models/spree/preferences/store.rb + - app/models/spree/product.rb - app/models/spree/product_decorator.rb - app/models/spree/return_authorization.rb - app/models/spree/shipment.rb - app/models/spree/taxon.rb - app/models/spree/tax_rate.rb + - app/models/spree/variant.rb - app/models/spree/zone.rb - app/serializers/api/admin/order_cycle_serializer.rb - app/serializers/api/cached_enterprise_serializer.rb @@ -755,8 +731,10 @@ Metrics/ClassLength: - app/models/spree/line_item.rb - app/models/spree/order.rb - app/models/spree/payment.rb + - app/models/spree/product.rb - app/models/spree/shipment.rb - app/models/spree/user.rb + - app/models/spree/variant.rb - app/models/spree/zone.rb - app/serializers/api/cached_enterprise_serializer.rb - app/serializers/api/enterprise_shopfront_serializer.rb diff --git a/app/controllers/spree/admin/variants_controller.rb b/app/controllers/spree/admin/variants_controller.rb index bfd1c5ead0..d47acc2858 100644 --- a/app/controllers/spree/admin/variants_controller.rb +++ b/app/controllers/spree/admin/variants_controller.rb @@ -23,7 +23,9 @@ module Spree flash[:success] = flash_message_for(@object, :successfully_updated) redirect_to spree.admin_product_variants_url(params[:product_id], @url_filters) else - redirect_to spree.edit_admin_product_variant_url(params[:product_id], @object, @url_filters) + redirect_to spree.edit_admin_product_variant_url(params[:product_id], + @object, + @url_filters) end end