From dc9fd669a25a9461b0af0ca9befcbfb6f8e5ba14 Mon Sep 17 00:00:00 2001 From: David Cook Date: Wed, 13 Dec 2023 14:11:02 +1100 Subject: [PATCH] Remove unnecessary html_safe calls The tag generator methods should already be returning html_safe strings. --- app/helpers/spree/admin/base_helper.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/helpers/spree/admin/base_helper.rb b/app/helpers/spree/admin/base_helper.rb index 5615d4d62a..de2173c674 100644 --- a/app/helpers/spree/admin/base_helper.rb +++ b/app/helpers/spree/admin/base_helper.rb @@ -110,12 +110,12 @@ module Spree object.preferences.keys.map { |key| preference_label = form.label("preferred_#{key}", - Spree.t(key.to_s.gsub("_from_list", "")) + ": ").html_safe + Spree.t(key.to_s.gsub("_from_list", "")) + ": ") preference_field = preference_field_for( form, "preferred_#{key}", { type: object.preference_type(key) }, object - ).html_safe + ) { label: preference_label, field: preference_field } } end