From d8959fd7a5cbc992501e5cd71ff363b7ab7906d8 Mon Sep 17 00:00:00 2001 From: Cillian O'Ruanaidh Date: Fri, 2 May 2025 13:03:41 +0100 Subject: [PATCH] Don't cast remove image parameters to booleans. --- app/models/enterprise.rb | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/app/models/enterprise.rb b/app/models/enterprise.rb index e8ff4b273e..a1c5061a9a 100644 --- a/app/models/enterprise.rb +++ b/app/models/enterprise.rb @@ -270,15 +270,15 @@ class Enterprise < ApplicationRecord end def remove_logo=(value) - self.logo = nil if truthy?(value) + self.logo = nil if value == "1" end def remove_promo_image=(value) - self.promo_image = nil if truthy?(value) + self.promo_image = nil if value == "1" end def remove_white_label_logo=(value) - return if !truthy?(value) + return unless value == "1" self.white_label_logo = nil self.white_label_logo_link = nil # Link not needed if there's no logo @@ -492,10 +492,6 @@ class Enterprise < ApplicationRecord private - def truthy?(value) - ActiveModel::Type::Boolean.new.cast(value) - end - def validate_white_label_logo_link return if white_label_logo.blank?