From d7d253e58d72d10c557c2fefec98a27c3b0d3316 Mon Sep 17 00:00:00 2001 From: Gaetan Craig-Riou Date: Mon, 1 Jul 2024 13:00:30 +1000 Subject: [PATCH] Fix Unit Price service --- app/services/unit_price.rb | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/app/services/unit_price.rb b/app/services/unit_price.rb index 0b28c973d5..004ec68332 100644 --- a/app/services/unit_price.rb +++ b/app/services/unit_price.rb @@ -3,12 +3,11 @@ class UnitPrice def initialize(variant) @variant = variant - @product = variant.product end def denominator # catches any case where unit is not kg, lb, or L. - return @variant.unit_value if @product&.variant_unit == "items" + return @variant.unit_value if @variant.variant_unit == "items" case unit when "lb" @@ -23,13 +22,13 @@ class UnitPrice def unit return "lb" if WeightsAndMeasures.new(@variant).system == "imperial" - case @product&.variant_unit + case @variant.variant_unit when "weight" "kg" when "volume" "L" else - @product.variant_unit_name.presence || I18n.t("item") + @variant.variant_unit_name.presence || I18n.t("item") end end end