From d77a94335bfcd4cbd5ed929d4297c22147c3c5ac Mon Sep 17 00:00:00 2001 From: Kristina Lim Date: Mon, 6 Aug 2018 18:23:44 +0800 Subject: [PATCH] Update .rubocop_todo.yml --- .rubocop_todo.yml | 96 +++++------------------------------------------ 1 file changed, 9 insertions(+), 87 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index b9bd3d0908..65e05628ca 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,12 +1,12 @@ # This configuration was generated by # `rubocop --auto-gen-config --exclude-limit 1400` -# on 2018-07-20 18:57:26 +0200 using RuboCop version 0.55.0. +# on 2018-08-06 18:22:59 +0800 using RuboCop version 0.55.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 36 +# Offense count: 35 # Cop supports --auto-correct. # Configuration parameters: Include, TreatCommentsAsGroupSeparators. # Include: **/*.gemfile, **/Gemfile, **/gems.rb @@ -263,7 +263,7 @@ Layout/EmptyLinesAroundArguments: Exclude: - 'spec/archive/features/consumer/checkout_spec.rb' -# Offense count: 65 +# Offense count: 64 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: empty_lines, no_empty_lines @@ -364,7 +364,7 @@ Layout/EndAlignment: - 'app/serializers/api/admin/for_order_cycle/supplied_product_serializer.rb' - 'app/serializers/api/admin/order_cycle_serializer.rb' -# Offense count: 49 +# Offense count: 48 # Cop supports --auto-correct. # Configuration parameters: AllowForAlignment, ForceEqualSignAlignment. Layout/ExtraSpacing: @@ -387,7 +387,6 @@ Layout/ExtraSpacing: - 'spec/features/admin/bulk_order_management_spec.rb' - 'spec/features/admin/bulk_product_update_spec.rb' - 'spec/features/admin/orders_spec.rb' - - 'spec/features/admin/product_import_spec.rb' - 'spec/features/admin/reports_spec.rb' - 'spec/features/consumer/groups_spec.rb' - 'spec/features/consumer/shopping/shopping_spec.rb' @@ -794,7 +793,7 @@ Layout/SpaceInsideBlockBraces: - 'spec/spec_helper.rb' - 'spec/support/cancan_helper.rb' -# Offense count: 798 +# Offense count: 772 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. # SupportedStyles: space, no_space, compact @@ -976,11 +975,6 @@ Lint/AmbiguousOperator: Exclude: - 'spec/controllers/spree/admin/payments_controller_spec.rb' -# Offense count: 2 -Lint/BooleanSymbol: - Exclude: - - 'spec/features/consumer/shopping/embedded_groups_spec.rb' - # Offense count: 4 Lint/DuplicateMethods: Exclude: @@ -1030,7 +1024,7 @@ Lint/ShadowingOuterLocalVariable: - 'app/models/spree/product_set.rb' - 'spec/models/model_set_spec.rb' -# Offense count: 7 +# Offense count: 6 # Cop supports --auto-correct. Lint/StringConversionInInterpolation: Exclude: @@ -1040,7 +1034,6 @@ Lint/StringConversionInInterpolation: - 'app/helpers/injection_helper.rb' - 'app/helpers/spree/products_helper_decorator.rb' - 'app/serializers/api/admin/tag_rule_serializer.rb' - - 'spec/features/admin/product_import_spec.rb' # Offense count: 2 Lint/UnderscorePrefixedVariableName: @@ -1171,7 +1164,7 @@ Lint/Void: - 'spec/serializers/enterprise_serializer_spec.rb' - 'spec/support/request/web_helper.rb' -# Offense count: 998 +# Offense count: 993 # Configuration parameters: CountComments, ExcludedMethods. Metrics/BlockLength: Max: 776 @@ -1326,76 +1319,6 @@ Performance/UnneededSort: - 'app/models/spree/product_decorator.rb' - 'spec/features/admin/order_cycles_spec.rb' -# Offense count: 206 -# Cop supports --auto-correct. -Rails/ActiveRecordAliases: - Exclude: - - 'app/controllers/admin/bulk_line_items_controller.rb' - - 'app/controllers/admin/enterprises_controller.rb' - - 'app/controllers/admin/subscriptions_controller.rb' - - 'app/controllers/api/customers_controller.rb' - - 'app/controllers/api/enterprises_controller.rb' - - 'app/controllers/api/product_images_controller.rb' - - 'app/controllers/checkout_controller.rb' - - 'app/controllers/spree/admin/line_items_controller_decorator.rb' - - 'app/controllers/spree/credit_cards_controller.rb' - - 'app/controllers/spree/orders_controller_decorator.rb' - - 'app/helpers/i18n_helper.rb' - - 'app/jobs/subscription_placement_job.rb' - - 'app/jobs/update_account_invoices.rb' - - 'app/jobs/update_billable_periods.rb' - - 'app/models/billable_period.rb' - - 'app/models/spree/adjustment_decorator.rb' - - 'app/models/spree/line_item_decorator.rb' - - 'app/models/spree/order_decorator.rb' - - 'app/models/spree/product_set.rb' - - 'app/services/create_mail_method.rb' - - 'app/services/line_item_syncer.rb' - - 'app/services/order_factory.rb' - - 'app/services/order_syncer.rb' - - 'lib/open_food_network/order_cycle_form_applicator.rb' - - 'lib/open_food_network/subscription_payment_updater.rb' - - 'lib/stripe/profile_storer.rb' - - 'spec/controllers/admin/proxy_orders_controller_spec.rb' - - 'spec/controllers/admin/subscriptions_controller_spec.rb' - - 'spec/controllers/line_items_controller_spec.rb' - - 'spec/controllers/spree/admin/payment_methods_controller_spec.rb' - - 'spec/controllers/spree/orders_controller_spec.rb' - - 'spec/features/admin/bulk_order_management_spec.rb' - - 'spec/features/admin/order_cycles_spec.rb' - - 'spec/features/admin/orders_spec.rb' - - 'spec/features/admin/subscriptions_spec.rb' - - 'spec/features/admin/variants_spec.rb' - - 'spec/features/consumer/account_spec.rb' - - 'spec/features/consumer/registration_spec.rb' - - 'spec/features/consumer/shopping/cart_spec.rb' - - 'spec/features/consumer/shopping/orders_spec.rb' - - 'spec/features/consumer/shopping/shopping_spec.rb' - - 'spec/jobs/subscription_confirm_job_spec.rb' - - 'spec/jobs/subscription_placement_job_spec.rb' - - 'spec/jobs/update_account_invoices_spec.rb' - - 'spec/jobs/update_billable_periods_spec.rb' - - 'spec/lib/open_food_network/products_cache_refreshment_spec.rb' - - 'spec/lib/open_food_network/products_cache_spec.rb' - - 'spec/lib/open_food_network/proxy_order_syncer_spec.rb' - - 'spec/models/customer_spec.rb' - - 'spec/models/enterprise_caching_spec.rb' - - 'spec/models/exchange_spec.rb' - - 'spec/models/order_cycle_spec.rb' - - 'spec/models/producer_property_spec.rb' - - 'spec/models/proxy_order_spec.rb' - - 'spec/models/spree/adjustment_spec.rb' - - 'spec/models/spree/credit_card_spec.rb' - - 'spec/models/spree/line_item_spec.rb' - - 'spec/models/spree/order_spec.rb' - - 'spec/models/spree/product_spec.rb' - - 'spec/models/spree/user_spec.rb' - - 'spec/models/spree/variant_spec.rb' - - 'spec/models/variant_override_spec.rb' - - 'spec/requests/checkout/stripe_connect_spec.rb' - - 'spec/services/order_syncer_spec.rb' - - 'spec/services/subscription_estimator_spec.rb' - # Offense count: 11 # Cop supports --auto-correct. # Configuration parameters: NilOrEmpty, NotPresent, UnlessPresent. @@ -1951,7 +1874,7 @@ Style/GuardClause: - 'spec/support/request/distribution_helper.rb' - 'spec/support/request/shop_workflow.rb' -# Offense count: 970 +# Offense count: 968 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols. # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys @@ -2080,7 +2003,6 @@ Style/HashSyntax: - 'spec/features/admin/subscriptions_spec.rb' - 'spec/features/admin/variant_overrides_spec.rb' - 'spec/features/consumer/account/cards_spec.rb' - - 'spec/features/consumer/shopping/embedded_groups_spec.rb' - 'spec/features/consumer/shopping/products_spec.rb' - 'spec/features/consumer/shopping/shopping_spec.rb' - 'spec/jobs/subscription_placement_job_spec.rb' @@ -2538,7 +2460,7 @@ Style/UnneededPercentQ: - 'spec/features/consumer/producers_spec.rb' - 'spec/support/request/web_helper.rb' -# Offense count: 6631 +# Offense count: 6607 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. # URISchemes: http, https Metrics/LineLength: