From d3b80b7fc9b384b393868064064f75a1c3b5fb5e Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Tue, 31 Jan 2023 15:40:33 +1100 Subject: [PATCH] Clarify expecting a hash, not keyword arguments The syntax was ambiguous and nwer version of rspec-rails catch that. --- .../spree/admin/base_controller_spec.rb | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/spec/controllers/spree/admin/base_controller_spec.rb b/spec/controllers/spree/admin/base_controller_spec.rb index 7e53deb55e..15d763aee0 100644 --- a/spec/controllers/spree/admin/base_controller_spec.rb +++ b/spec/controllers/spree/admin/base_controller_spec.rb @@ -24,7 +24,7 @@ describe Spree::Admin::BaseController, type: :controller do it "passes a prefix to the serializer method and renders with serializer" do expect(controller).to receive(:serializer).with(prefix) { "SerializerClass" } - expect(controller).to receive(:render).with(json: data, serializer: "SerializerClass") + expect(controller).to receive(:render).with({ json: data, serializer: "SerializerClass" }) controller.send(:render_as_json, data, ams_prefix: prefix) end end @@ -34,7 +34,7 @@ describe Spree::Admin::BaseController, type: :controller do it "does not pass a prefix to the serializer method and renders with serializer" do expect(controller).to receive(:serializer).with(prefix) { "SerializerClass" } - expect(controller).to receive(:render).with(json: data, serializer: "SerializerClass") + expect(controller).to receive(:render).with({ json: data, serializer: "SerializerClass" }) controller.send(:render_as_json, data, ams_prefix: prefix) end end @@ -48,8 +48,9 @@ describe Spree::Admin::BaseController, type: :controller do it "passes a prefix to the serializer method and renders with each_serializer" do expect(controller).to receive(:serializer).with(prefix) { "SerializerClass" } - expect(controller).to receive(:render).with(json: data, - each_serializer: "SerializerClass") + expect(controller).to receive(:render).with( + { json: data, each_serializer: "SerializerClass" } + ) controller.send(:render_as_json, data, ams_prefix: prefix) end end @@ -59,8 +60,9 @@ describe Spree::Admin::BaseController, type: :controller do it "does not pass a prefix to the serializer method and renders with each_serializer" do expect(controller).to receive(:serializer).with(prefix) { "SerializerClass" } - expect(controller).to receive(:render).with(json: data, - each_serializer: "SerializerClass") + expect(controller).to receive(:render).with( + { json: data, each_serializer: "SerializerClass" } + ) controller.send(:render_as_json, data, ams_prefix: prefix) end end