From d3319cfd6929322d90a984ac27315680a2a64fb5 Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Fri, 10 Oct 2025 16:39:15 +1100 Subject: [PATCH] Replace global spec helpers with faster `let` --- spec/requests/api/v1/customers_spec.rb | 2 ++ spec/support/api_helper.rb | 8 -------- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/spec/requests/api/v1/customers_spec.rb b/spec/requests/api/v1/customers_spec.rb index 0d10c3ef0c..9f158e1de4 100644 --- a/spec/requests/api/v1/customers_spec.rb +++ b/spec/requests/api/v1/customers_spec.rb @@ -19,6 +19,8 @@ RSpec.describe "Customers", swagger_doc: "v1.yaml", feature: :api_v1 do } let!(:customer2) { create(:customer, enterprise: enterprise1, created_manually: true,) } let!(:customer3) { create(:customer, enterprise: enterprise2, created_manually: true,) } + let(:json_response_ids) { json_response[:data]&.pluck(:id) } + let(:json_error_detail) { json_response[:errors][0][:detail] } before do login_as enterprise1.owner diff --git a/spec/support/api_helper.rb b/spec/support/api_helper.rb index 4319f032ed..6bfcd82510 100644 --- a/spec/support/api_helper.rb +++ b/spec/support/api_helper.rb @@ -6,14 +6,6 @@ module OpenFoodNetwork response.parsed_body end - def json_response_ids - json_response[:data]&.pluck(:id) - end - - def json_error_detail - json_response[:errors][0][:detail] - end - def assert_unauthorized! expect(json_response).to eq("error" => "You are not authorized to perform that action.") expect(response).to have_http_status :unauthorized