From d2736002dcf4c0acafeafaf0ec246ca850770e22 Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Tue, 30 Jan 2024 12:34:57 +1100 Subject: [PATCH] Remove dead code from ReportsController That code was rendering the report in the request but we only do it in the background now. --- app/controllers/admin/reports_controller.rb | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/app/controllers/admin/reports_controller.rb b/app/controllers/admin/reports_controller.rb index 7e944cd341..70fa0a7b7b 100644 --- a/app/controllers/admin/reports_controller.rb +++ b/app/controllers/admin/reports_controller.rb @@ -22,14 +22,10 @@ module Admin def show @report = report_class.new(spree_current_user, params, render: render_data?) - if request.post? + if render_data? rendering_options # stores user preferences - return background(report_format) - end - - if params[:report_format].present? - export_report + background(report_format) else show_report end @@ -37,13 +33,8 @@ module Admin private - def export_report - send_data @report.render_as(report_format), filename: report_filename - end - def show_report assign_view_data - @table = @report.render_as(:html) if render_data? render "show" end