From d129665d439671d82eeba89f7cb8c80e4eb0920a Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Tue, 12 Mar 2019 17:10:13 +1100 Subject: [PATCH] Wait for orders being loaded in bulk order manage The bulk order management page tried to wait for orders being loaded. But instead of receiving a request object with an a promise to wait for the page received a simple array without promise. As a result, the page didn't wait for orders being loaded. When loading of orders took longer than loading of line items they or at least not all of them were enriched with distributors and order cycles and the line items were missing some orders. That lead to random spec failures. --- .../javascripts/admin/resources/services/orders.js.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/assets/javascripts/admin/resources/services/orders.js.coffee b/app/assets/javascripts/admin/resources/services/orders.js.coffee index 5eef10eecb..3d266aa48d 100644 --- a/app/assets/javascripts/admin/resources/services/orders.js.coffee +++ b/app/assets/javascripts/admin/resources/services/orders.js.coffee @@ -9,7 +9,7 @@ angular.module("admin.resources").factory 'Orders', ($q, OrderResource, RequestM request = OrderResource.index params, (data) => @load(data) (callback || angular.noop)(data) - RequestMonitor.load(request.$promise) + @all.$promise = request.$promise @all load: (data) ->