From d0bb52f70945358d86e087e9ce7dbc2739d77c5b Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Mon, 7 Feb 2022 16:55:45 +1100 Subject: [PATCH] Update Rubocop todo list --- .rubocop_todo.yml | 199 +++++++++++----------------------------------- 1 file changed, 48 insertions(+), 151 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index da8a202961..4f11093dbf 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,11 +1,19 @@ # This configuration was generated by # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 1400` -# on 2021-12-09 22:28:37 UTC using RuboCop version 1.22.2. +# on 2022-02-07 05:53:22 UTC using RuboCop version 1.22.2. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include. +# Include: **/*.gemfile, **/Gemfile, **/gems.rb +Bundler/OrderedGems: + Exclude: + - 'Gemfile' + # Offense count: 4 # Configuration parameters: Include. # Include: **/*.gemspec @@ -45,7 +53,7 @@ Layout/LeadingCommentSpace: Exclude: - 'spec/system/admin/enterprises_spec.rb' -# Offense count: 814 +# Offense count: 815 # Cop supports --auto-correct. # Configuration parameters: Max, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. # URISchemes: http, https @@ -59,11 +67,13 @@ Layout/LineLength: - 'app/controllers/admin/schedules_controller.rb' - 'app/controllers/admin/subscriptions_controller.rb' - 'app/controllers/api/v0/order_cycles_controller.rb' - - 'app/controllers/checkout_controller.rb' + - 'app/controllers/payment_gateways/paypal_controller.rb' - 'app/controllers/spree/admin/reports_controller.rb' - - 'app/controllers/spree/paypal_controller.rb' + - 'app/controllers/spree/users_controller.rb' + - 'app/controllers/user_confirmations_controller.rb' - 'app/helpers/angular_form_builder.rb' - 'app/helpers/angular_form_helper.rb' + - 'app/helpers/checkout_helper.rb' - 'app/helpers/enterprises_helper.rb' - 'app/helpers/order_cycles_helper.rb' - 'app/helpers/spree/orders_helper.rb' @@ -101,7 +111,6 @@ Layout/LineLength: - 'app/services/variant_units/variant_and_line_item_naming.rb' - 'engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb' - 'engines/order_management/app/services/order_management/subscriptions/validator.rb' - - 'engines/order_management/spec/services/order_management/order/stripe_sca_payment_authorize_spec.rb' - 'engines/order_management/spec/services/order_management/order/updater_spec.rb' - 'engines/web/app/helpers/web/cookies_policy_helper.rb' - 'engines/web/spec/features/consumer/cookies_spec.rb' @@ -147,6 +156,7 @@ Layout/LineLength: - 'spec/controllers/checkout_controller_spec.rb' - 'spec/controllers/enterprises_controller_spec.rb' - 'spec/controllers/line_items_controller_spec.rb' + - 'spec/controllers/registration_controller_spec.rb' - 'spec/controllers/shops_controller_spec.rb' - 'spec/controllers/spree/admin/orders/customer_details_controller_spec.rb' - 'spec/controllers/spree/admin/orders/invoices_spec.rb' @@ -159,8 +169,8 @@ Layout/LineLength: - 'spec/controllers/stripe/callbacks_controller_spec.rb' - 'spec/controllers/stripe/webhooks_controller_spec.rb' - 'spec/controllers/user_confirmations_controller_spec.rb' + - 'spec/factories/order_factory.rb' - 'spec/factories/stock_location_factory.rb' - - 'spec/features/consumer/multilingual_spec.rb' - 'spec/helpers/enterprises_helper_spec.rb' - 'spec/helpers/injection_helper_spec.rb' - 'spec/helpers/order_cycles_helper_spec.rb' @@ -198,7 +208,6 @@ Layout/LineLength: - 'spec/models/spree/address_spec.rb' - 'spec/models/spree/adjustment_spec.rb' - 'spec/models/spree/classification_spec.rb' - - 'spec/models/spree/gateway/stripe_connect_spec.rb' - 'spec/models/spree/inventory_unit_spec.rb' - 'spec/models/spree/line_item_spec.rb' - 'spec/models/spree/order/checkout_spec.rb' @@ -219,7 +228,7 @@ Layout/LineLength: - 'spec/models/variant_override_spec.rb' - 'spec/requests/api/orders_spec.rb' - 'spec/requests/checkout/failed_checkout_spec.rb' - - 'spec/requests/embedded_shopfronts_headers_spec.rb' + - 'spec/routing/stripe_spec.rb' - 'spec/serializers/api/admin/exchange_serializer_spec.rb' - 'spec/serializers/api/admin/order_cycle_serializer_spec.rb' - 'spec/services/address_geocoder_spec.rb' @@ -280,7 +289,6 @@ Layout/LineLength: - 'spec/system/consumer/shopping/checkout_auth_spec.rb' - 'spec/system/consumer/shopping/checkout_spec.rb' - 'spec/system/consumer/shopping/checkout_stripe_spec.rb' - - 'spec/system/consumer/shopping/embedded_shopfronts_spec.rb' - 'spec/system/consumer/shopping/products_spec.rb' - 'spec/system/consumer/shopping/shopping_spec.rb' - 'spec/system/consumer/shopping/unit_price_spec.rb' @@ -303,7 +311,7 @@ Layout/MultilineMethodCallBraceLayout: Exclude: - 'lib/reporting/queries/joins.rb' -# Offense count: 15 +# Offense count: 17 # Cop supports --auto-correct. # Configuration parameters: AllowInHeredoc. Layout/TrailingWhitespace: @@ -338,6 +346,11 @@ Lint/DuplicateMethods: Exclude: - 'lib/discourse/single_sign_on.rb' +# Offense count: 1 +Lint/DuplicateRequire: + Exclude: + - 'spec/lib/open_food_network/scope_variants_to_search_spec.rb' + # Offense count: 1 # Configuration parameters: AllowComments. Lint/EmptyFile: @@ -392,7 +405,7 @@ Lint/UselessMethodDefinition: - 'app/controllers/spree/user_registrations_controller.rb' - 'app/models/spree/gateway.rb' -# Offense count: 262 +# Offense count: 261 # Configuration parameters: IgnoredMethods, CountRepeatedAttributes, Max. Metrics/AbcSize: Exclude: @@ -414,8 +427,11 @@ Metrics/AbcSize: - 'app/controllers/api/v0/taxons_controller.rb' - 'app/controllers/api/v0/variants_controller.rb' - 'app/controllers/checkout_controller.rb' + - 'app/controllers/concerns/order_completion.rb' - 'app/controllers/discourse_sso_controller.rb' - 'app/controllers/enterprises_controller.rb' + - 'app/controllers/payment_gateways/paypal_controller.rb' + - 'app/controllers/payment_gateways/stripe_controller.rb' - 'app/controllers/split_checkout_controller.rb' - 'app/controllers/spree/admin/adjustments_controller.rb' - 'app/controllers/spree/admin/general_settings_controller.rb' @@ -435,8 +451,6 @@ Metrics/AbcSize: - 'app/controllers/spree/admin/variants_controller.rb' - 'app/controllers/spree/credit_cards_controller.rb' - 'app/controllers/spree/orders_controller.rb' - - 'app/controllers/spree/paypal_controller.rb' - - 'app/controllers/spree/user_passwords_controller.rb' - 'app/controllers/spree/user_sessions_controller.rb' - 'app/controllers/spree/users_controller.rb' - 'app/controllers/stripe/callbacks_controller.rb' @@ -564,7 +578,7 @@ Metrics/AbcSize: - 'spec/system/consumer/shopping/shopping_spec.rb' - 'spec/system/consumer/shopping/variant_overrides_spec.rb' -# Offense count: 48 +# Offense count: 46 # Configuration parameters: CountComments, Max, CountAsOne, ExcludedMethods, IgnoredMethods. # IgnoredMethods: refine Metrics/BlockLength: @@ -582,7 +596,6 @@ Metrics/BlockLength: - 'spec/factories/line_item_factory.rb' - 'spec/factories/order_cycle_factory.rb' - 'spec/factories/order_factory.rb' - - 'spec/factories/payment_method_factory.rb' - 'spec/factories/product_factory.rb' - 'spec/factories/shipment_factory.rb' - 'spec/factories/shipping_method_factory.rb' @@ -598,7 +611,6 @@ Metrics/BlockLength: - 'spec/swagger_helper.rb' - 'spec/system/admin/order_cycles/complex_updating_specific_time_spec.rb' - 'spec/system/consumer/shopping/checkout_spec.rb' - - 'spec/system/consumer/shopping/embedded_shopfronts_spec.rb' # Offense count: 1 # Configuration parameters: CountBlocks, Max. @@ -619,6 +631,7 @@ Metrics/ClassLength: - 'app/controllers/api/v0/products_controller.rb' - 'app/controllers/application_controller.rb' - 'app/controllers/checkout_controller.rb' + - 'app/controllers/payment_gateways/paypal_controller.rb' - 'app/controllers/spree/admin/orders_controller.rb' - 'app/controllers/spree/admin/payment_methods_controller.rb' - 'app/controllers/spree/admin/payments_controller.rb' @@ -626,7 +639,6 @@ Metrics/ClassLength: - 'app/controllers/spree/admin/reports_controller.rb' - 'app/controllers/spree/admin/users_controller.rb' - 'app/controllers/spree/orders_controller.rb' - - 'app/controllers/spree/paypal_controller.rb' - 'app/models/enterprise.rb' - 'app/models/order_cycle.rb' - 'app/models/product_import/entry_processor.rb' @@ -660,7 +672,7 @@ Metrics/ClassLength: - 'lib/open_food_network/users_and_enterprises_report.rb' - 'lib/open_food_network/xero_invoices_report.rb' -# Offense count: 72 +# Offense count: 71 # Configuration parameters: IgnoredMethods, Max. Metrics/CyclomaticComplexity: Exclude: @@ -723,7 +735,7 @@ Metrics/CyclomaticComplexity: - 'spec/models/product_importer_spec.rb' - 'spec/support/i18n_translations_checker.rb' -# Offense count: 254 +# Offense count: 258 # Configuration parameters: CountComments, Max, CountAsOne, ExcludedMethods, IgnoredMethods. Metrics/MethodLength: Exclude: @@ -743,6 +755,9 @@ Metrics/MethodLength: - 'app/controllers/api/v0/shipments_controller.rb' - 'app/controllers/api/v0/taxons_controller.rb' - 'app/controllers/api/v0/variants_controller.rb' + - 'app/controllers/checkout_controller.rb' + - 'app/controllers/concerns/order_completion.rb' + - 'app/controllers/payment_gateways/paypal_controller.rb' - 'app/controllers/shop_controller.rb' - 'app/controllers/split_checkout_controller.rb' - 'app/controllers/spree/admin/orders/customer_details_controller.rb' @@ -757,8 +772,8 @@ Metrics/MethodLength: - 'app/controllers/spree/admin/variants_controller.rb' - 'app/controllers/spree/credit_cards_controller.rb' - 'app/controllers/spree/orders_controller.rb' - - 'app/controllers/spree/paypal_controller.rb' - 'app/controllers/spree/user_sessions_controller.rb' + - 'app/controllers/spree/users_controller.rb' - 'app/controllers/stripe/callbacks_controller.rb' - 'app/controllers/user_confirmations_controller.rb' - 'app/controllers/user_passwords_controller.rb' @@ -861,7 +876,7 @@ Metrics/MethodLength: - 'spec/system/admin/reports_spec.rb' - 'spec/system/consumer/shopping/variant_overrides_spec.rb' -# Offense count: 19 +# Offense count: 20 # Configuration parameters: CountComments, Max, CountAsOne. Metrics/ModuleLength: Exclude: @@ -877,6 +892,7 @@ Metrics/ModuleLength: - 'engines/order_management/spec/services/order_management/subscriptions/validator_spec.rb' - 'lib/open_food_network/column_preference_defaults.rb' - 'spec/controllers/admin/order_cycles_controller_spec.rb' + - 'spec/controllers/api/v0/orders_controller_spec.rb' - 'spec/lib/open_food_network/order_cycle_form_applicator_spec.rb' - 'spec/lib/open_food_network/order_cycle_permissions_spec.rb' - 'spec/models/spree/adjustment_spec.rb' @@ -895,14 +911,13 @@ Metrics/ParameterLists: - 'spec/support/controller_requests_helper.rb' - 'spec/system/admin/reports_spec.rb' -# Offense count: 46 +# Offense count: 45 # Configuration parameters: IgnoredMethods, Max. Metrics/PerceivedComplexity: Exclude: - 'app/controllers/admin/enterprises_controller.rb' - 'app/controllers/api/v0/variants_controller.rb' - 'app/controllers/spree/admin/orders_controller.rb' - - 'app/controllers/spree/admin/payment_methods_controller.rb' - 'app/controllers/spree/admin/payments_controller.rb' - 'app/controllers/spree/admin/taxons_controller.rb' - 'app/controllers/spree/admin/users_controller.rb' @@ -1004,12 +1019,13 @@ Rails/ApplicationController: Exclude: - 'engines/dfc_provider/app/controllers/dfc_provider/api/base_controller.rb' -# Offense count: 5 +# Offense count: 6 # Cop supports --auto-correct. Rails/ApplicationJob: Exclude: - 'app/jobs/bulk_invoice_job.rb' - 'app/jobs/heartbeat_job.rb' + - 'app/jobs/order_cycle_closing_job.rb' - 'app/jobs/order_cycle_notification_job.rb' - 'app/jobs/subscription_confirm_job.rb' - 'app/jobs/subscription_placement_job.rb' @@ -1043,22 +1059,15 @@ Rails/Date: Exclude: - 'spec/system/flatpickr_spec.rb' -# Offense count: 15 +# Offense count: 4 # Configuration parameters: EnforcedStyle. # SupportedStyles: slashes, arguments Rails/FilePath: Exclude: - 'app/models/product_import/product_importer.rb' - 'lib/tasks/karma.rake' - - 'spec/controllers/api/v0/logos_controller_spec.rb' - - 'spec/controllers/api/v0/product_images_controller_spec.rb' - - 'spec/controllers/api/v0/promo_images_controller_spec.rb' - - 'spec/controllers/api/v0/terms_and_conditions_controller_spec.rb' - - 'spec/factories/product_factory.rb' - 'spec/models/content_configuration_spec.rb' - - 'spec/serializers/api/admin/enterprise_serializer_spec.rb' - 'spec/support/downloads_helper.rb' - - 'spec/system/admin/enterprises/images_spec.rb' # Offense count: 11 # Configuration parameters: Include. @@ -1119,7 +1128,7 @@ Rails/HelperInstanceVariable: - 'app/helpers/spree/orders_helper.rb' # Offense count: 36 -# Configuration parameters: Include. +# Configuration parameters: IgnoreScopes, Include. # Include: app/models/**/*.rb Rails/InverseOf: Exclude: @@ -1143,7 +1152,7 @@ Rails/InverseOf: - 'app/models/spree/variant.rb' - 'app/models/subscription_line_item.rb' -# Offense count: 39 +# Offense count: 38 # Configuration parameters: Include. # Include: app/controllers/**/*.rb Rails/LexicallyScopedActionFilter: @@ -1167,7 +1176,6 @@ Rails/LexicallyScopedActionFilter: - 'app/controllers/spree/admin/users_controller.rb' - 'app/controllers/spree/admin/zones_controller.rb' - 'app/controllers/spree/users_controller.rb' - - 'app/controllers/user_passwords_controller.rb' # Offense count: 18 Rails/OutputSafety: @@ -1188,125 +1196,17 @@ Rails/OutputSafety: # Offense count: 1 # Cop supports --auto-correct. -# Configuration parameters: AutoCorrect. Rails/RelativeDateConstant: Exclude: - 'lib/tasks/data/remove_transient_data.rb' -# Offense count: 297 +# Offense count: 4 # Configuration parameters: ForbiddenMethods, AllowedMethods. # ForbiddenMethods: decrement!, decrement_counter, increment!, increment_counter, insert, insert!, insert_all, insert_all!, toggle!, touch, touch_all, update_all, update_attribute, update_column, update_columns, update_counters, upsert, upsert_all Rails/SkipsModelValidations: Exclude: - - 'app/controllers/admin/resource_controller.rb' - - 'app/controllers/checkout_controller.rb' - - 'app/controllers/spree/admin/payment_methods_controller.rb' - - 'app/controllers/spree/admin/shipping_methods_controller.rb' - - 'app/controllers/spree/admin/taxons_controller.rb' - - 'app/controllers/spree/credit_cards_controller.rb' - - 'app/jobs/subscription_confirm_job.rb' - - 'app/models/concerns/line_item_stock_changes.rb' - - 'app/models/enterprise.rb' - - 'app/models/enterprise_relationship.rb' - - 'app/models/product_import/inventory_reset_strategy.rb' - - 'app/models/proxy_order.rb' - - 'app/models/spree/address.rb' - - 'app/models/spree/adjustment.rb' - - 'app/models/spree/credit_card.rb' - - 'app/models/spree/gateway/pay_pal_express.rb' - - 'app/models/spree/inventory_unit.rb' - - 'app/models/spree/item_adjustments.rb' - - 'app/models/spree/order.rb' - - 'app/models/spree/order/checkout.rb' - - 'app/models/spree/payment.rb' - - 'app/models/spree/product.rb' - - 'app/models/spree/shipment.rb' - - 'app/models/spree/shipping_method.rb' - - 'app/models/spree/tax_category.rb' - - 'app/models/spree/taxonomy.rb' - - 'app/models/spree/variant.rb' - - 'app/models/spree/zone.rb' - - 'app/models/subscription.rb' - 'app/models/variant_override.rb' - - 'app/services/order_factory.rb' - - 'app/services/place_proxy_order.rb' - - 'engines/order_management/app/services/order_management/order/updater.rb' - - 'engines/order_management/spec/services/order_management/reports/enterprise_fee_summary/report_service_spec.rb' - - 'engines/order_management/spec/services/order_management/subscriptions/stripe_payment_setup_spec.rb' - - 'lib/spree/core/controller_helpers/order.rb' - - 'lib/tasks/data/anonymize_data.rake' - - 'lib/tasks/sample_data/product_factory.rb' - - 'lib/tasks/users.rake' - - 'spec/controllers/admin/bulk_line_items_controller_spec.rb' - - 'spec/controllers/admin/customers_controller_spec.rb' - - 'spec/controllers/admin/subscription_line_items_controller_spec.rb' - - 'spec/controllers/admin/variant_overrides_controller_spec.rb' - - 'spec/controllers/api/v0/order_cycles_controller_spec.rb' - - 'spec/controllers/api/v0/orders_controller_spec.rb' - - 'spec/controllers/api/v0/products_controller_spec.rb' - - 'spec/controllers/api/v0/shipments_controller_spec.rb' - - 'spec/controllers/api/v0/variants_controller_spec.rb' - - 'spec/controllers/checkout_controller_spec.rb' - - 'spec/controllers/enterprises_controller_spec.rb' - - 'spec/controllers/spree/admin/orders/invoices_spec.rb' - - 'spec/controllers/spree/admin/orders/payments/payments_controller_spec.rb' - - 'spec/controllers/spree/admin/overview_controller_spec.rb' - - 'spec/controllers/spree/admin/payment_methods_controller_spec.rb' - - 'spec/controllers/spree/credit_cards_controller_spec.rb' - - 'spec/controllers/spree/orders_controller_spec.rb' - - 'spec/factories.rb' - - 'spec/factories/order_factory.rb' - - 'spec/factories/shipment_factory.rb' - - 'spec/helpers/enterprises_helper_spec.rb' - - 'spec/helpers/order_cycles_helper_spec.rb' - - 'spec/lib/open_food_network/address_finder_spec.rb' - - 'spec/lib/open_food_network/enterprise_fee_calculator_spec.rb' - - 'spec/lib/open_food_network/orders_and_fulfillments_report_spec.rb' - - 'spec/lib/open_food_network/permissions_spec.rb' - - 'spec/lib/open_food_network/products_and_inventory_report_spec.rb' - - 'spec/lib/open_food_network/scope_variant_to_hub_spec.rb' - - 'spec/lib/reports/packing/packing_report_spec.rb' - - 'spec/lib/stripe/credit_card_cloner_spec.rb' - - 'spec/lib/tasks/data/remove_transient_data_spec.rb' - - 'spec/models/concerns/variant_stock_spec.rb' - - 'spec/models/enterprise_relationship_spec.rb' - - 'spec/models/exchange_spec.rb' - - 'spec/models/spree/adjustment_spec.rb' - - 'spec/models/spree/asset_spec.rb' - 'spec/models/spree/line_item_spec.rb' - - 'spec/models/spree/order/tax_spec.rb' - - 'spec/models/spree/order_inventory_spec.rb' - - 'spec/models/spree/order_spec.rb' - - 'spec/models/spree/tax_category_spec.rb' - - 'spec/models/spree/tax_rate_spec.rb' - - 'spec/models/spree/variant_spec.rb' - - 'spec/queries/customers_with_balance_spec.rb' - - 'spec/queries/outstanding_balance_spec.rb' - - 'spec/serializers/api/admin/subscription_line_item_serializer_spec.rb' - - 'spec/services/cache_service_spec.rb' - - 'spec/services/cap_quantity_spec.rb' - - 'spec/services/order_cart_reset_spec.rb' - - 'spec/services/order_checkout_restart_spec.rb' - - 'spec/services/order_cycle_distributed_products_spec.rb' - - 'spec/services/order_factory_spec.rb' - - 'spec/services/order_syncer_spec.rb' - - 'spec/services/process_payment_intent_spec.rb' - - 'spec/services/product_tag_rules_filterer_spec.rb' - - 'spec/services/products_renderer_spec.rb' - - 'spec/support/request/shop_workflow.rb' - - 'spec/system/admin/bulk_order_management_spec.rb' - - 'spec/system/admin/bulk_product_update_spec.rb' - - 'spec/system/admin/configuration/tax_rates_spec.rb' - - 'spec/system/admin/order_cycles/complex_editing_spec.rb' - - 'spec/system/admin/order_cycles/simple_spec.rb' - - 'spec/system/admin/order_spec.rb' - - 'spec/system/admin/payments_spec.rb' - - 'spec/system/consumer/caching/shops_caching_spec.rb' - - 'spec/system/consumer/shopping/checkout_spec.rb' - - 'spec/system/consumer/shopping/products_spec.rb' - - 'spec/system/consumer/shopping/shopping_spec.rb' - - 'spec/system/consumer/shopping/unit_price_spec.rb' - - 'spec/views/spree/shared/_order_details.html.haml_spec.rb' # Offense count: 5 # Cop supports --auto-correct. @@ -1331,12 +1231,11 @@ Rails/UniqueValidationWithoutIndex: - 'app/models/spree/tax_category.rb' - 'app/models/spree/zone.rb' -# Offense count: 2 +# Offense count: 1 # Configuration parameters: Environments. # Environments: development, test, production Rails/UnknownEnv: Exclude: - - 'app/controllers/spree/admin/payment_methods_controller.rb' - 'app/models/spree/app_configuration.rb' # Offense count: 1 @@ -1424,7 +1323,7 @@ Style/GlobalStdStream: - 'lib/tasks/subscriptions/debug.rake' - 'lib/tasks/subscriptions/test.rake' -# Offense count: 41 +# Offense count: 39 # Configuration parameters: MinBodyLength. Style/GuardClause: Exclude: @@ -1575,6 +1474,7 @@ Style/Send: - 'engines/order_management/spec/services/order_management/reports/bulk_coop/bulk_coop_report_spec.rb' - 'spec/controllers/admin/subscriptions_controller_spec.rb' - 'spec/controllers/checkout_controller_spec.rb' + - 'spec/controllers/payment_gateways/paypal_controller_spec.rb' - 'spec/controllers/spree/admin/base_controller_spec.rb' - 'spec/controllers/spree/orders_controller_spec.rb' - 'spec/helpers/order_cycles_helper_spec.rb' @@ -1594,7 +1494,6 @@ Style/Send: - 'spec/models/calculator/weight_spec.rb' - 'spec/models/enterprise_spec.rb' - 'spec/models/exchange_spec.rb' - - 'spec/models/spree/gateway/stripe_connect_spec.rb' - 'spec/models/spree/order_inventory_spec.rb' - 'spec/models/spree/order_spec.rb' - 'spec/models/spree/payment_spec.rb' @@ -1625,7 +1524,7 @@ Style/SlicingWithRange: - 'lib/discourse/single_sign_on.rb' - 'spec/lib/open_food_network/order_grouper_spec.rb' -# Offense count: 41 +# Offense count: 31 # Cop supports --auto-correct. # Configuration parameters: Mode. Style/StringConcatenation: @@ -1646,12 +1545,10 @@ Style/StringConcatenation: - 'lib/open_food_network/orders_and_fulfillments_report/customer_totals_report.rb' - 'lib/spree/api/controller_setup.rb' - 'lib/spree/core/environment_extension.rb' - - 'spec/controllers/user_confirmations_controller_spec.rb' - 'spec/lib/open_food_network/order_grouper_spec.rb' - 'spec/models/spree/line_item_spec.rb' - 'spec/models/spree/product_spec.rb' - 'spec/models/spree/variant_spec.rb' - - 'spec/requests/embedded_shopfronts_headers_spec.rb' - 'spec/services/embedded_page_service_spec.rb' - 'spec/support/api_helper.rb' - 'spec/support/features/datepicker_helper.rb'