From d05bb508de7a9a081081661ecdef014f4307ee08 Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Mon, 13 Feb 2023 12:23:45 +1100 Subject: [PATCH] Avoid flaky spec by avoiding variable name conflict Specs were sharing the same variable and could influence each other. --- .../controllers/variant_overrides_controller_spec.js.coffee | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/javascripts/unit/admin/controllers/variant_overrides_controller_spec.js.coffee b/spec/javascripts/unit/admin/controllers/variant_overrides_controller_spec.js.coffee index 1c860e8e91..ec70842a20 100644 --- a/spec/javascripts/unit/admin/controllers/variant_overrides_controller_spec.js.coffee +++ b/spec/javascripts/unit/admin/controllers/variant_overrides_controller_spec.js.coffee @@ -37,8 +37,8 @@ describe "VariantOverridesCtrl", -> describe "when more than one hub is available", -> beforeEach -> inject ($controller) -> - hubs = [{id: 1, name: 'Hub1'}, {id: 12, name: 'Hub2'}] - $controller 'AdminVariantOverridesCtrl', { $scope: scope, hubs: hubs, producers: [], products: [], hubPermissions: []} + two_hubs = [{id: 1, name: 'Hub1'}, {id: 12, name: 'Hub2'}] + $controller 'AdminVariantOverridesCtrl', { $scope: scope, hubs: two_hubs, producers: [], products: [], hubPermissions: []} it "initialises the hub list and the selects the only hub in the list", -> expect(scope.hubs).toEqual { 1: {id: 1, name: 'Hub1'}, 12: {id: 12, name: 'Hub2'} }